[Home]

Summary:ASTERISK-14352: [patch] Russian syntax. app_voicemail forgets to say "messages" when there are no new and old messages in the mailbox.
Reporter:Romik_g (romik)Labels:
Date Opened:2009-06-22 04:02:20Date Closed:2011-06-07 14:10:21
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail.c.diff
Description:Russian syntax.
app_voicemail forgets to say "messages" when there are no new and old messages in the mailbox.

****** STEPS TO REPRODUCE ******

   -- Executing [999@DLPN_allow_all_for_all:1] VoiceMailMain("SIP/199-b78df4c0", "199@default") in new stack
   -- <SIP/199-b78df4c0> Playing 'vm-password' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-youhave' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-no' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-opts' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-goodbye' (language 'ru')
 == Auto fallthrough, channel 'SIP/199-b78df4c0' status is 'UNKNOWN'


****** ADDITIONAL INFORMATION ******

Should be:
   -- Executing [999@DLPN_allow_all_for_all:1] VoiceMailMain("SIP/199-b78df4c0", "199@default") in new stack
   -- <SIP/199-b78df4c0> Playing 'vm-password' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-youhave' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-no' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-messagex2' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-opts' (language 'ru')
   -- <SIP/199-b78df4c0> Playing 'vm-goodbye' (language 'ru')
 == Auto fallthrough, channel 'SIP/199-b78df4c0' status is 'UNKNOWN'

--- asterisk-1.4.25.1/apps/app_voicemail.c.bak  2009-06-22 12:56:19.000000000 +0400
+++ asterisk-1.4.25.1/apps/app_voicemail.c      2009-06-22 12:56:36.000000000 +0400
@@ -6074,6 +6074,7 @@
       if (!res) {
               if (lastnum == 0) {
                       res = ast_play_and_wait(chan, "vm-no");
+                       res = ast_say_counted_noun(chan, lastnum, "vm-message");
               }
               if (!res) {
                       res = ast_say_counted_noun(chan, lastnum, "vm-message");

Comments:By: Tilghman Lesher (tilghman) 2009-08-25 15:24:04

This is incorrect.  The line immediately following this is for saying the word, but it only executes if not interrupted either by hangup or DTMF.
By: Leif Madsen (lmadsen) 2009-09-22 08:38:39

Closing this per Tilghman's note that this is incorrect, and we haven't heard from the reporter for a month now. Please reopen if you're able to move this issue forward. Thanks!