| Summary: | ASTERISK-14347: recent commit on svn 1.4 chan_sip failed to load | ||
| Reporter: | Ronald Chan (loloski) | Labels: | |
| Date Opened: | 2009-06-20 11:00:47 | Date Closed: | 2009-06-20 12:51:43 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | https://reviewboard.asterisk.org/r/287/ compilation warning but leads to unloadable chan_sip :( chan_sip.c: In function âtry_suggested_sip_codecâ: chan_sip.c:3733: warning: implicit declaration of function âsip_pvt_unlockâ chan_sip.c:3735: warning: implicit declaration of function âsip_pvt_lockâ ****** ADDITIONAL INFORMATION ****** r202022 | mnicholson | 2009-06-20 05:21:15 +0800 (Sat, 20 Jun 2009) | 4 lines Added deadlock protection to try_suggested_sip_codec in chan_sip.c. Review: https://reviewboard.asterisk.org/r/287/ | ||
| Comments: | By: Digium Subversion (svnbot) 2009-06-20 12:51:42 Repository: asterisk Revision: 202153 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r202153 | seanbright | 2009-06-20 12:51:42 -0500 (Sat, 20 Jun 2009) | 5 lines Since we don't have sip_pvt_lock() in 1.4, we need to use ast_mutex_* directly. (closes issue ASTERISK-14347) Reported by: loloski ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=202153 | ||