Summary:	ASTERISK-14324: [patch] Deadlock when performing directed pickup
Reporter:	Laurent Steffan (lmsteffan)	Labels:
Date Opened:	2009-06-16 22:46:37	Date Closed:	2009-09-17 17:41:33
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) deadlock.patch ( 1) deadlock.txt
Description:	When a phone tries to pickup a ringing extension (through SIP INVITE with Replace) there sometimes occurs a deadlock. The attached file contains a snapshot of such a deadlock. Two threads have interlocked, each one waiting on a lock already owned by the other (the first lock protects the channel clonechan/chan, the other protects its sip_pvt part p/i) The included patch assumes that it is necessary to unlock the sip_pvt pointer before hanging up the channel to which it belongs. Can someone confirm that ?
Comments:	By: Donny Kavanagh (donnyk) 2009-06-16 23:33:25 Reporter requested via irc to change category.  As his/her reported bug/patch resides within chan_sip. By: Leif Madsen (lmadsen) 2009-09-08 09:31:36 Assigned to Tilghman for review, and possible commit. I have this marked as a possible blocker for 1.4.27. By: Digium Subversion (svnbot) 2009-09-17 17:39:16 Repository: asterisk Revision: 219371 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r219371 | dvossel | 2009-09-17 17:39:16 -0500 (Thu, 17 Sep 2009) | 9 lines fixes deadlock when performing directed pickup w Invite/replaces (closes issue ASTERISK-14324) Reported by: lmsteffan Patches:      deadlock.patch uploaded by lmsteffan (license 779) Tested by: lmsteffan ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=219371 By: Digium Subversion (svnbot) 2009-09-17 17:40:35 Repository: asterisk Revision: 219376 _U  branches/1.6.2/ U   branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r219376 | dvossel | 2009-09-17 17:40:34 -0500 (Thu, 17 Sep 2009) | 15 lines Merged revisions 219371 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r219371 | dvossel | 2009-09-17 17:37:28 -0500 (Thu, 17 Sep 2009) | 9 lines    fixes deadlock when performing directed pickup w Invite/replaces    (closes issue ASTERISK-14324)  Reported by: lmsteffan  Patches:        deadlock.patch uploaded by lmsteffan (license 779)  Tested by: lmsteffan ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=219376 By: Digium Subversion (svnbot) 2009-09-17 17:41:12 Repository: asterisk Revision: 219378 _U  branches/1.6.1/ ------------------------------------------------------------------------ r219378 | dvossel | 2009-09-17 17:41:12 -0500 (Thu, 17 Sep 2009) | 14 lines Blocked revisions 219371 via svnmerge ........  r219371 | dvossel | 2009-09-17 17:37:28 -0500 (Thu, 17 Sep 2009) | 9 lines    fixes deadlock when performing directed pickup w Invite/replaces    (closes issue ASTERISK-14324)  Reported by: lmsteffan  Patches:        deadlock.patch uploaded by lmsteffan (license 779)  Tested by: lmsteffan ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=219378 By: Digium Subversion (svnbot) 2009-09-17 17:41:32 Repository: asterisk Revision: 219379 _U  branches/1.6.0/ ------------------------------------------------------------------------ r219379 | dvossel | 2009-09-17 17:41:32 -0500 (Thu, 17 Sep 2009) | 14 lines Blocked revisions 219371 via svnmerge ........  r219371 | dvossel | 2009-09-17 17:37:28 -0500 (Thu, 17 Sep 2009) | 9 lines    fixes deadlock when performing directed pickup w Invite/replaces    (closes issue ASTERISK-14324)  Reported by: lmsteffan  Patches:        deadlock.patch uploaded by lmsteffan (license 779)  Tested by: lmsteffan ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=219379