Summary:	ASTERISK-14295: new_find_extension arguments in wrong order
Reporter:	Jim Dickenson (jimdickenson)	Labels:
Date Opened:	2009-06-09 16:21:53	Date Closed:	2009-06-10 15:37:04
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Core/PBX
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	The prototype and all calls to new_find_extension have callerid then label but the function definition has the arguments as label then callerid. Clearly in the wrong order. The problem is on line 1218 of main/pbx.c of 1.6.0.9 code. Still a problem in current svn code. ****** ADDITIONAL INFORMATION ****** The initial problem I was looking for was a segmentation fault. This is actually happening in ast_hashtab_hash_string when str is NULL.
Comments:	By: Leif Madsen (lmadsen) 2009-06-10 11:57:00 Assigned to dbrooks as this looks like it might be an issue he can quickly tackle. Thanks! By: Digium Subversion (svnbot) 2009-06-10 15:00:46 Repository: asterisk Revision: 199957 U   trunk/main/pbx.c ------------------------------------------------------------------------ r199957 | dbrooks | 2009-06-10 15:00:46 -0500 (Wed, 10 Jun 2009) | 10 lines Fixes the argument order in definition of new_find_extension(). In the definition of new_find_extension(), the arguments 'callerid' and 'label' were swapped. The prototype declaration and all calls to the function are ordered 'callerid' then 'label', but the function itself was ordered 'label' then 'callerid'. (closes issue ASTERISK-14295) Reported by: JimDickenson ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=199957 By: Digium Subversion (svnbot) 2009-06-10 15:29:53 Repository: asterisk Revision: 199994 _U  branches/1.6.0/ U   branches/1.6.0/main/pbx.c ------------------------------------------------------------------------ r199994 | dbrooks | 2009-06-10 15:29:53 -0500 (Wed, 10 Jun 2009) | 10 lines Fixes the argument order in definition of new_find_extension(). In the definition of new_find_extension(), the arguments 'callerid' and 'label' were swapped. The prototype declaration and all calls to the function are ordered 'callerid' then 'label', but the function itself was ordered 'label' then 'callerid'. (closes issue ASTERISK-14295) Reported by: JimDickenson ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=199994 By: Digium Subversion (svnbot) 2009-06-10 15:35:06 Repository: asterisk Revision: 199996 _U  branches/1.6.1/ U   branches/1.6.1/main/pbx.c ------------------------------------------------------------------------ r199996 | dbrooks | 2009-06-10 15:35:05 -0500 (Wed, 10 Jun 2009) | 10 lines Fixes the argument order in definition of new_find_extension(). In the definition of new_find_extension(), the arguments 'callerid' and 'label' were swapped. The prototype declaration and all calls to the function are ordered 'callerid' then 'label', but the function itself was ordered 'label' then 'callerid'. (closes issue ASTERISK-14295) Reported by: JimDickenson ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=199996 By: Digium Subversion (svnbot) 2009-06-10 15:37:03 Repository: asterisk Revision: 199998 _U  branches/1.6.2/ U   branches/1.6.2/main/pbx.c ------------------------------------------------------------------------ r199998 | dbrooks | 2009-06-10 15:37:03 -0500 (Wed, 10 Jun 2009) | 10 lines Fixes the argument order in definition of new_find_extension(). In the definition of new_find_extension(), the arguments 'callerid' and 'label' were swapped. The prototype declaration and all calls to the function are ordered 'callerid' then 'label', but the function itself was ordered 'label' then 'callerid'. (closes issue ASTERISK-14295) Reported by: JimDickenson ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=199998