Summary:	ASTERISK-14287: Registrations persist after removal and sip reload
Reporter:	Benny Amorsen (amorsen)	Labels:
Date Opened:	2009-06-09 03:35:48	Date Closed:	2009-06-17 10:39:50
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Registration
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	I have a registry entry in sip.conf, like: register => 4550607774:hiddenpassword@10.10.44.100/4550607774 and that has been registered for a while. Then I remove that entry from sip.conf and issue sip reload, expecting the registry entry to go away. It does indeed disappear from sip show registry after the sip reload, but then I get: WARNING[24870]: chan_sip.c:16334 handle_response_register: Got 200 OK on REGISTER, but there isn't a registry entry for '4550607774' (we probably already got the OK) When I tcpdump I can see that more attempts at registration are sent for that peer.
Comments:	By: Digium Subversion (svnbot) 2009-06-17 10:20:28 Repository: asterisk Revision: 201344 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r201344 | dvossel | 2009-06-17 10:20:27 -0500 (Wed, 17 Jun 2009) | 16 lines SIP registry ref count error During a sip reload, the list of sip_registry objects are supposed to be traversed, unlinked, and destroyed, but destruction never takes place due to a ref counting error. This causes a memory leak when registry items are removed from sip.conf and reloaded.  While the registries are removed from the global list, they are not removed from the scheduler. Because of this, SIP register attempts continue to be sent out for the item even though it may no longer be in the .conf. (closes issue ASTERISK-14287) Reported by: amorsen Review: https://reviewboard.asterisk.org/r/282/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=201344 By: Digium Subversion (svnbot) 2009-06-17 10:25:50 Repository: asterisk Revision: 201360 _U  branches/1.6.2/ U   branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r201360 | dvossel | 2009-06-17 10:25:50 -0500 (Wed, 17 Jun 2009) | 23 lines Merged revisions 201344 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r201344 | dvossel | 2009-06-17 10:20:26 -0500 (Wed, 17 Jun 2009) | 16 lines    SIP registry ref count error    During a sip reload, the list of sip_registry objects are  supposed to be traversed, unlinked, and destroyed, but  destruction never takes place due to a ref counting error.  This causes a memory leak when registry items are removed  from sip.conf and reloaded.  While the registries are removed  from the global list, they are not removed from the scheduler.  Because of this, SIP register attempts continue to be sent  out for the item even though it may no longer be in the .conf.    (closes issue ASTERISK-14287)  Reported by: amorsen    Review: https://reviewboard.asterisk.org/r/282/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=201360 By: Digium Subversion (svnbot) 2009-06-17 10:32:44 Repository: asterisk Revision: 201365 _U  branches/1.6.1/ U   branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r201365 | dvossel | 2009-06-17 10:32:44 -0500 (Wed, 17 Jun 2009) | 23 lines Merged revisions 201344 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r201344 | dvossel | 2009-06-17 10:20:26 -0500 (Wed, 17 Jun 2009) | 16 lines    SIP registry ref count error    During a sip reload, the list of sip_registry objects are  supposed to be traversed, unlinked, and destroyed, but  destruction never takes place due to a ref counting error.  This causes a memory leak when registry items are removed  from sip.conf and reloaded.  While the registries are removed  from the global list, they are not removed from the scheduler.  Because of this, SIP register attempts continue to be sent  out for the item even though it may no longer be in the .conf.    (closes issue ASTERISK-14287)  Reported by: amorsen    Review: https://reviewboard.asterisk.org/r/282/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=201365 By: Digium Subversion (svnbot) 2009-06-17 10:39:50 Repository: asterisk Revision: 201366 _U  branches/1.6.0/ ------------------------------------------------------------------------ r201366 | dvossel | 2009-06-17 10:39:50 -0500 (Wed, 17 Jun 2009) | 22 lines Blocked revisions 201344 via svnmerge ........  r201344 | dvossel | 2009-06-17 10:20:26 -0500 (Wed, 17 Jun 2009) | 16 lines    SIP registry ref count error    During a sip reload, the list of sip_registry objects are  supposed to be traversed, unlinked, and destroyed, but  destruction never takes place due to a ref counting error.  This causes a memory leak when registry items are removed  from sip.conf and reloaded.  While the registries are removed  from the global list, they are not removed from the scheduler.  Because of this, SIP register attempts continue to be sent  out for the item even though it may no longer be in the .conf.    (closes issue ASTERISK-14287)  Reported by: amorsen    Review: https://reviewboard.asterisk.org/r/282/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=201366