[Home]

Summary:ASTERISK-14273: music on hold digit=X non-functional
Reporter:Matthew Beckwell (mbeckwell)Labels:
Date Opened:2009-06-05 21:56:21Date Closed:2009-09-10 14:57:45
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch.txt
Description:As of release 1.6.0.6, the "digit" functionality of music on hold (where the caller can change the music on hold class by pressing a digit) no longer works.

DTMF is still recognized on the channel (per the dtmf logger debug), however the music on hold class does not change.

This worked correctly in 1.6.0.5, but broke in 1.6.0.6, and remains broken as of the SVN revision 199298.

****** ADDITIONAL INFORMATION ******

Simple musiconhold.conf:

[default]
mode=files
directory=/var/lib/asterisk/moh
sort=random
digit=2

[aretha]
mode=files
directory=/var/lib/asterisk/moh/aretha
digit=3
Comments:By: Matthew Beckwell (mbeckwell) 2009-06-05 21:58:43

Reproducible using the following OSes:

Fedora release 10 (Cambridge) i386
CentOS release 5.3 i386
By: Matthias Nick (mnick) 2009-09-03 16:15:34

Posted a patch, ready for testing
By: Matthew Beckwell (mbeckwell) 2009-09-04 11:42:10

Tested patch against SVN-trunk-r216335M.  The expected behavior seems to be restored.  

On a somewhat related note-- I have filed an additional issue (15832) for a persistence problem surrounding the usage of the digit=X inside of app_queue.
By: Digium Subversion (svnbot) 2009-09-10 14:40:56

Repository: asterisk
Revision: 217730

U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r217730 | mnick | 2009-09-10 14:40:56 -0500 (Thu, 10 Sep 2009) | 17 lines


Sets the correct musicclass after an announcement

(closes issue ASTERISK-14273)
Reported by: mbeckwell
Patches:
     patch.txt uploaded by mnick (license )
Tested by: mnick

(closes issue ASTERISK-14772)
Reported by: mbeckwell
Patches:
     patch.txt uploaded by mnick (license 874)
Tested by: mnick



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217730
By: Digium Subversion (svnbot) 2009-09-10 14:54:56

Repository: asterisk
Revision: 217736

_U  branches/1.6.0/
U   branches/1.6.0/res/res_musiconhold.c

------------------------------------------------------------------------
r217736 | mnick | 2009-09-10 14:54:56 -0500 (Thu, 10 Sep 2009) | 22 lines

Merged revisions 217730 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r217730 | mnick | 2009-09-10 14:39:41 -0500 (Thu, 10 Sep 2009) | 17 lines
 
 
 Sets the correct musicclass after an announcement
 
 (closes issue ASTERISK-14273)
 Reported by: mbeckwell
 Patches:
       patch.txt uploaded by mnick (license )
 Tested by: mnick
 
 (closes issue ASTERISK-14772)
 Reported by: mbeckwell
 Patches:
       patch.txt uploaded by mnick (license 874)
 Tested by: mnick
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217736
By: Digium Subversion (svnbot) 2009-09-10 14:57:09

Repository: asterisk
Revision: 217738

_U  branches/1.6.1/
U   branches/1.6.1/res/res_musiconhold.c

------------------------------------------------------------------------
r217738 | mnick | 2009-09-10 14:57:08 -0500 (Thu, 10 Sep 2009) | 22 lines

Merged revisions 217730 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r217730 | mnick | 2009-09-10 14:39:41 -0500 (Thu, 10 Sep 2009) | 17 lines
 
 
 Sets the correct musicclass after an announcement
 
 (closes issue ASTERISK-14273)
 Reported by: mbeckwell
 Patches:
       patch.txt uploaded by mnick (license )
 Tested by: mnick
 
 (closes issue ASTERISK-14772)
 Reported by: mbeckwell
 Patches:
       patch.txt uploaded by mnick (license 874)
 Tested by: mnick
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217738
By: Digium Subversion (svnbot) 2009-09-10 14:57:45

Repository: asterisk
Revision: 217739

_U  branches/1.6.2/
U   branches/1.6.2/res/res_musiconhold.c

------------------------------------------------------------------------
r217739 | mnick | 2009-09-10 14:57:44 -0500 (Thu, 10 Sep 2009) | 22 lines

Merged revisions 217730 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r217730 | mnick | 2009-09-10 14:39:41 -0500 (Thu, 10 Sep 2009) | 17 lines
 
 
 Sets the correct musicclass after an announcement
 
 (closes issue ASTERISK-14273)
 Reported by: mbeckwell
 Patches:
       patch.txt uploaded by mnick (license )
 Tested by: mnick
 
 (closes issue ASTERISK-14772)
 Reported by: mbeckwell
 Patches:
       patch.txt uploaded by mnick (license 874)
 Tested by: mnick
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217739