[Home]

Summary:ASTERISK-14272: [patch] add initial support for AT+CUSD command
Reporter:Artem Makhutov (artem)Labels:
Date Opened:2009-06-05 08:32:48Date Closed:2009-07-29 16:46:29
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Addons/chan_mobile
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cusd.patch
( 1) cusd4.patch
( 2) cusd5.patch
Description:Hello,

this patch adds initial support for the AT+CUSD command.

Using this command it is possible to query the bilance of a prepaid card.

This patch adds a new CLI option: mobile cusd <deviceid> <command>

Example usage: mobile cusd K800i *101#
Comments:By: Matthew Nicholson (mnicholson) 2009-06-05 11:47:48

Please generate a patch using svn diff and post this on http://reviewboard.asterisk.org.  I have some comments about your handle_response_cusd() function.
By: Artem Makhutov (artem) 2009-06-05 16:08:41

Hello,

here it is:

https://reviewboard.asterisk.org/r/274/
By: Matthew Nicholson (mnicholson) 2009-06-08 17:40:13

Ok, the review has been updated with my comments.  Sorry it took so long, reviewboard had some problems with the patch you uploaded.


By: Artem Makhutov (artem) 2009-06-09 13:10:26

Hello,

yes, the review board has really a problem with my patches :(

I have fixed the whitespaces but I have to think about a better parsing of the result. If you have any ideas/proposals I would be glat so see them.
By: Matthew Nicholson (mnicholson) 2009-06-09 13:16:51

Make sure you are generating your patches using 'svn diff'.

See the other parsing functions (hfp_parse_clid?) for ideas.
By: Artem Makhutov (artem) 2009-06-09 13:50:07

Yes, I have generated it using svn diff.

I hope that I have finally managed to publish the new diff correctly. There was a problem with the path.
By: Artem Makhutov (artem) 2009-06-13 06:03:54

I have attached a new version.
By: Artem Makhutov (artem) 2009-07-25 09:30:08

Any comments about the new patch?

Will it be included in chan_mobile?
By: Matthew Nicholson (mnicholson) 2009-07-28 10:55:38

When the parsing routines are made more robust, I will add this to chan_mobile.
By: Artem Makhutov (artem) 2009-07-29 11:32:00

I have reworked the parsing function in cusd5.patch. Is there still something wrong with it?
By: Matthew Nicholson (mnicholson) 2009-07-29 11:41:12

Oh.  This is different than what you have on review board.  I will take a look.
By: Matthew Nicholson (mnicholson) 2009-07-29 11:44:55

Ok.  It looks good to me.  I am going to take another look at it and get it commited later this afternoon or tomorrow sometime.
By: Artem Makhutov (artem) 2009-07-29 11:49:08

Ok, this is great :)
By: Digium Subversion (svnbot) 2009-07-29 16:46:28

Repository: asterisk
Revision: 209484

U   trunk/addons/chan_mobile.c

------------------------------------------------------------------------
r209484 | mnicholson | 2009-07-29 16:46:28 -0500 (Wed, 29 Jul 2009) | 10 lines

This patch adds the ability to send a CUSD command to a bluetooth device.

(closes issue ASTERISK-14272)
Reported by: Artem
Patches:
     cusd5.patch uploaded by Artem (license 800)
Tested by: mnicholson, Artem

Review: https://reviewboard.asterisk.org/r/274/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=209484