| Summary: | ASTERISK-14267: [patch] german time (20:01:00 oh clock) is announced wrong | ||
| Reporter: | Benjamin Kluck (benjamin kluck) | Labels: | |
| Date Opened: | 2009-06-04 11:31:20 | Date Closed: | 2009-08-25 14:49:48 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) say_c.patch | |
| Description: | Hi! This bug is a bit tricky to explain. Please consider the following dialplan: exten => 1,1,Set(CHANNEL(language)=de) exten => 1,n,DateTime(1240336860,Europe/Berlin,HM) asterisk says: "Zwanzig Uhr Eine" ("Eine" is the german female (1F.gsm) of "Eins"(1.gsm)) This is wrong. Correct would be: "Zwanzig Uhr Eins" We only have to say "Eine" if we say "Minute" ("Eine Minute" is correct). So exten => 1,n,DateTime(1240336862,Europe/Berlin,HMS) is working correctly ("Zwanzig Uhr Eine Minute Zwei Sekunden) There is also another problem: In Germany we say "eine Sekunde" and "zwei Sekunden" (just like the english "one second", "two seconds") but asterisk always says "Sekunden". I attached a patch which corrects this behavior. Use it for your needs. Cheers Ben | ||
| Comments: | By: Ronald Chan (loloski) 2009-06-04 12:56:09 please sign your disclaimer, in order for developers to see your patch :) By: Benjamin Kluck (benjamin kluck) 2009-06-05 04:31:13 already did that, it is in state "License PENDING (v3.0)" By: Benjamin Kluck (benjamin kluck) 2009-06-05 07:44:43 disclaimer is "OK" now By: Digium Subversion (svnbot) 2009-08-25 14:27:27 Repository: asterisk Revision: 214068 U branches/1.4/main/say.c ------------------------------------------------------------------------ r214068 | tilghman | 2009-08-25 14:27:27 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue ASTERISK-14267) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214068 By: Digium Subversion (svnbot) 2009-08-25 14:33:25 Repository: asterisk Revision: 214071 _U trunk/ U trunk/main/say.c ------------------------------------------------------------------------ r214071 | tilghman | 2009-08-25 14:33:25 -0500 (Tue, 25 Aug 2009) | 17 lines Merged revisions 214068-214069 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue ASTERISK-14267) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ........ r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines I should always compile before committing... ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214071 By: Digium Subversion (svnbot) 2009-08-25 14:43:14 Repository: asterisk Revision: 214073 _U branches/1.6.0/ U branches/1.6.0/main/say.c ------------------------------------------------------------------------ r214073 | tilghman | 2009-08-25 14:43:14 -0500 (Tue, 25 Aug 2009) | 24 lines Merged revisions 214071 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214071 | tilghman | 2009-08-25 14:32:48 -0500 (Tue, 25 Aug 2009) | 17 lines Merged revisions 214068-214069 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue ASTERISK-14267) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ........ r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines I should always compile before committing... ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214073 By: Digium Subversion (svnbot) 2009-08-25 14:43:26 Repository: asterisk Revision: 214074 _U branches/1.6.2/ U branches/1.6.2/main/say.c ------------------------------------------------------------------------ r214074 | tilghman | 2009-08-25 14:43:26 -0500 (Tue, 25 Aug 2009) | 24 lines Merged revisions 214071 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214071 | tilghman | 2009-08-25 14:32:48 -0500 (Tue, 25 Aug 2009) | 17 lines Merged revisions 214068-214069 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue ASTERISK-14267) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ........ r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines I should always compile before committing... ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214074 By: Digium Subversion (svnbot) 2009-08-25 14:49:48 Repository: asterisk Revision: 214076 _U branches/1.6.1/ U branches/1.6.1/main/say.c ------------------------------------------------------------------------ r214076 | tilghman | 2009-08-25 14:49:48 -0500 (Tue, 25 Aug 2009) | 24 lines Merged revisions 214071 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r214071 | tilghman | 2009-08-25 14:32:48 -0500 (Tue, 25 Aug 2009) | 17 lines Merged revisions 214068-214069 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue ASTERISK-14267) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ........ r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines I should always compile before committing... ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=214076 | ||