| Summary: | ASTERISK-14258: [patch] periodic-announce-frequency suggestion | ||
| Reporter: | Tony Russell (tonils) | Labels: | |
| Date Opened: | 2009-06-03 02:30:27 | Date Closed: | 2009-11-10 16:20:48.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) patch.txt ( 1) relative-periodic-announce14-1.diff ( 2) relative-periodic-announce160-1.diff ( 3) relative-periodic-announce161-1.diff ( 4) relative-periodic-announce162-1.diff | |
| Description: | periodic-announce-frequency is caluclated from the start of the anouncement. So it is effectivly the delay between the start of the last anouncement and the start of the next annoucement. For a small value (e.g. 20 seconds) and the longish anouncement (e.g. 15 seconds), then there is a very short pause between announcements. If one extends the example to include multiple varying length anouncements, you get situations where one anouncement runs into the other as the anouncement length is sometimes greater than the periodic-announce-frequency. One has to work out the length of the longest anouncement and make sure that periodic-announce-frequency is a few seconds longer than that. If the announcements are changed, the process needs to be repeated. It would be be more logical to have periodic-announce-frequency be the delay between the end of the last anouncement and the begining of the next anouncement. In this way setting periodic-announce-frequency to 15 would give a constant 15 second delay between each of the announcements. | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-06-16 12:36:58 mmichelson: this issue looks quite trivial, but useful. I thought you'd be the best one to look at it and be able to identify any reason this isn't a good implementation of what the reporter describes. Thanks! By: Matthew Nicholson (mnicholson) 2009-11-09 10:34:12.000-0600 This will be fixed in trunk. Patches have been provided for the other branches. By: Digium Subversion (svnbot) 2009-11-09 10:34:21.000-0600 Repository: asterisk Revision: 228947 U trunk/CHANGES U trunk/apps/app_queue.c U trunk/configs/queues.conf.sample ------------------------------------------------------------------------ r228947 | mnicholson | 2009-11-09 10:34:20 -0600 (Mon, 09 Nov 2009) | 5 lines Add the 'relative-periodic-announce' option to app_queue to allow for calculating the time of announcments from the end of the previous announcment rather than from the beginning. (closes issue ASTERISK-14258) Reported by: tonils ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=228947 | ||