[Home]

Summary:ASTERISK-14251: Incorrect path in make_version_h
Reporter:Jon Bonilla (manwe)Labels:
Date Opened:2009-06-02 08:25:45Date Closed:2009-06-11 06:59:58
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When .flavor and .version files exist in the root directory of the sources, the build system should set ASTERISK_VERSION to "1.4.25 (flavor version)" but it does not.

The make_version_h file checks incorrect path. Sice we run "make" from the root directory of the sources, the path to check is "." and not "../"

****** ADDITIONAL INFORMATION ******

Changing the path in the file makes it to work as expected:

#!/bin/sh
if [ ! -f .flavor ]; then
   cat << END
/*
* version.h
* Automatically generated
*/
#define ASTERISK_VERSION "${ASTERISKVERSION}"
#define ASTERISK_VERSION_NUM ${ASTERISKVERSIONNUM}

END
else
   aadkver=`cat .version`
   aadkflavor=`cat .flavor`
   cat << END
/*
* version.h
* Automatically generated
*/
#define ASTERISK_VERSION "${ASTERISKVERSION} (${aadkflavor} ${aadkver})"
#define ASTERISK_VERSION_NUM ${ASTERISKVERSIONNUM}

END
fi
Comments:By: David Woolley (davidw) 2009-06-02 10:11:03

Duplicate.  ASTERISK-13815

By: David Woolley (davidw) 2009-06-02 10:14:09

Note that you aren't allowed to provide code except as an attachment, and only after you have agreed the patch submission licence.

By: Jon Bonilla (manwe) 2009-06-02 10:47:20

That's not code nor patch. It can be considered a typo fix :)

By: Leif Madsen (lmadsen) 2009-06-11 06:59:57

Since this is a duplicate of 14737, please track this issue there. Thanks!