| Summary: | ASTERISK-14245: [patch] log does not indicate which function is missing closing parenthesis | ||
| Reporter: | nick_lewis (nick_lewis) | Labels: | |
| Date Opened: | 2009-06-01 10:01:55 | Date Closed: | 2009-08-25 01:37:35 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Core/PBX |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) pbx.c-funcparenthesis.patch ( 1) pbx.c-funcparenthesis.patch2 ( 2) pbx.c-funcparenthesis-1.4.diff | |
| Description: | In complex dialplans there can be many functions nested or in close proximity. If there is a typographical error such that a function is missing parenthesis then pbx.c issues a warning in the log but does not identify the function that is missing the parenthesis | ||
| Comments: | By: David Brooks (dbrooks) 2009-06-01 14:06:39 just fixed a typo and adjusted for 1.6.1 SVN but otherwise works fine By: Ronald Chan (loloski) 2009-06-04 13:36:29 i do agree with Nick here. for those people still in 1.4 SVN branch, i will attach a similar patch for 1.4. I know this can't be commited on 1.4 because of the policy. i will attach the patch anyway here for reference. Kudos to Nick Lewis... By: Digium Subversion (svnbot) 2009-08-25 01:35:20 Repository: asterisk Revision: 213970 U branches/1.4/main/pbx.c ------------------------------------------------------------------------ r213970 | tilghman | 2009-08-25 01:35:20 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue ASTERISK-14245) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213970 By: Digium Subversion (svnbot) 2009-08-25 01:36:13 Repository: asterisk Revision: 213971 _U trunk/ U trunk/main/pbx.c ------------------------------------------------------------------------ r213971 | tilghman | 2009-08-25 01:36:13 -0500 (Tue, 25 Aug 2009) | 14 lines Merged revisions 213970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue ASTERISK-14245) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213971 By: Digium Subversion (svnbot) 2009-08-25 01:37:17 Repository: asterisk Revision: 213972 _U branches/1.6.0/ U branches/1.6.0/main/pbx.c ------------------------------------------------------------------------ r213972 | tilghman | 2009-08-25 01:37:16 -0500 (Tue, 25 Aug 2009) | 21 lines Merged revisions 213971 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r213971 | tilghman | 2009-08-25 01:35:37 -0500 (Tue, 25 Aug 2009) | 14 lines Merged revisions 213970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue ASTERISK-14245) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213972 By: Digium Subversion (svnbot) 2009-08-25 01:37:26 Repository: asterisk Revision: 213973 _U branches/1.6.1/ U branches/1.6.1/main/pbx.c ------------------------------------------------------------------------ r213973 | tilghman | 2009-08-25 01:37:26 -0500 (Tue, 25 Aug 2009) | 21 lines Merged revisions 213971 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r213971 | tilghman | 2009-08-25 01:35:37 -0500 (Tue, 25 Aug 2009) | 14 lines Merged revisions 213970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue ASTERISK-14245) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213973 By: Digium Subversion (svnbot) 2009-08-25 01:37:35 Repository: asterisk Revision: 213974 _U branches/1.6.2/ U branches/1.6.2/main/pbx.c ------------------------------------------------------------------------ r213974 | tilghman | 2009-08-25 01:37:35 -0500 (Tue, 25 Aug 2009) | 21 lines Merged revisions 213971 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r213971 | tilghman | 2009-08-25 01:35:37 -0500 (Tue, 25 Aug 2009) | 14 lines Merged revisions 213970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue ASTERISK-14245) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=213974 | ||