[Home]

Summary:ASTERISK-14238: [patch] If dahdi timing interface is not registered, when we try to unload res_timing_dahdi asterisk crash.
Reporter:Eliel Sardanons (eliel)Labels:
Date Opened:2009-05-30 16:56:50Date Closed:2009-05-30 20:58:54
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Resources/res_timing_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) timing_dahdi1.diff
Description:If dahdi_test_timer() fails for some reason and the module is not properly loaded when unloading the module asterisk crash.

****** ADDITIONAL INFORMATION ******

We are calling ast_unregister_timing_interface(timing_funcs_handle) with timing_funcs_handle == NULL.
Comments:By: Russell Bryant (russell) 2009-05-30 20:00:45

The patch looks good.  Feel free to commit.  :-)
By: Digium Subversion (svnbot) 2009-05-30 20:22:15

Repository: asterisk
Revision: 198437

U   trunk/res/res_timing_dahdi.c

------------------------------------------------------------------------
r198437 | eliel | 2009-05-30 20:22:15 -0500 (Sat, 30 May 2009) | 11 lines

Avoid a crash when res_timing_dahdi is unloaded but wasn't properly loaded.

if dahdi_test_timer() fails, timing_funcs_handle remains NULL causing a crash
when calling ast_unregister_timing_interface() with a NULL pointer.

(closes issue ASTERISK-14238)
Reported by: eliel
Patches:
     timing_dahdi1.diff uploaded by eliel (license 64)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=198437
By: Digium Subversion (svnbot) 2009-05-30 20:48:48

Repository: asterisk
Revision: 198440

_U  branches/1.6.2/
U   branches/1.6.2/res/res_timing_dahdi.c

------------------------------------------------------------------------
r198440 | eliel | 2009-05-30 20:48:48 -0500 (Sat, 30 May 2009) | 17 lines

Merged revisions 198437 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r198437 | eliel | 2009-05-30 21:22:15 -0400 (Sat, 30 May 2009) | 11 lines
 
 Avoid a crash when res_timing_dahdi is unloaded but wasn't properly loaded.
 
 if dahdi_test_timer() fails, timing_funcs_handle remains NULL causing a crash
 when calling ast_unregister_timing_interface() with a NULL pointer.
 
 (closes issue ASTERISK-14238)
 Reported by: eliel
 Patches:
       timing_dahdi1.diff uploaded by eliel (license 64)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=198440
By: Digium Subversion (svnbot) 2009-05-30 20:58:54

Repository: asterisk
Revision: 198441

_U  branches/1.6.1/
U   branches/1.6.1/res/res_timing_dahdi.c

------------------------------------------------------------------------
r198441 | eliel | 2009-05-30 20:58:54 -0500 (Sat, 30 May 2009) | 17 lines

Merged revisions 198437 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r198437 | eliel | 2009-05-30 21:22:15 -0400 (Sat, 30 May 2009) | 11 lines
 
 Avoid a crash when res_timing_dahdi is unloaded but wasn't properly loaded.
 
 if dahdi_test_timer() fails, timing_funcs_handle remains NULL causing a crash
 when calling ast_unregister_timing_interface() with a NULL pointer.
 
 (closes issue ASTERISK-14238)
 Reported by: eliel
 Patches:
       timing_dahdi1.diff uploaded by eliel (license 64)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=198441