| Summary: | ASTERISK-14206: [patch] adding queue member from asterisk console with state_interface parameter not working | ||
| Reporter: | Ronald Chan (loloski) | Labels: | |
| Date Opened: | 2009-05-26 12:28:35 | Date Closed: | 2009-05-27 09:03:02 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 05272009_app_queue.diff | |
| Description: | PBX*CLI> queue add member Sip/100 to cbn-queue penalty 0 as loloski state_interface Sip/100 Usage: queue add member <channel> to <queue> [penalty <penalty> [as <membername> [state_interface <state_interface>]]] PBX*CLI> using a static member with queues.conf with state_interface parameter is working as expected as well as in the dialplan function AddQueueMember. ****** ADDITIONAL INFORMATION ****** Asterisk SVN-branch-1.4-r196116, Copyright (C) 1999 - 2008 Digium, Inc. and others. Created by Mark Spencer <markster@digium.com> Asterisk comes with ABSOLUTELY NO WARRANTY; type 'core show warranty' for details. This is free software, with components licensed under the GNU General Public License version 2 and other licenses; you are welcome to redistribute it under certain conditions. Type 'core show license' for details. ========================================================================= Connected to Asterisk SVN-branch-1.4-r196116 currently running on rev-test (pid = 14525) Verbosity is at least 3 PBX*CLI> | ||
| Comments: | By: Ronald Chan (loloski) 2009-05-26 12:36:30 since i don't have a production machine on 1.6.x series i can't attest that this holds also true for 1.6 By: Sean Bright (seanbright) 2009-05-27 07:42:22 Could you please test the attached patch and report back the results? Thanks. By: Ronald Chan (loloski) 2009-05-27 08:48:17 I can confirm that this patch fix it :) By: Ronald Chan (loloski) 2009-05-27 08:48:28 seanbright, after applying the patch ... rev-test*CLI> queue add member Sip/104 to cbn-queue penalty 0 as loloski state_interface Sip/100 Added interface 'Sip/104' to queue 'cbn-queue' rev-test*CLI> many thanks that fixed it .... By: Digium Subversion (svnbot) 2009-05-27 08:54:36 Repository: asterisk Revision: 197024 U branches/1.4/apps/app_queue.c ------------------------------------------------------------------------ r197024 | seanbright | 2009-05-27 08:54:36 -0500 (Wed, 27 May 2009) | 13 lines Fix handling of the 'state_interface' option of the 'queue add member' CLI command. 'queue add member' allows for specifying an interface to use for device state when adding a queue member via CLI, but the validation code was not properly updated to reflect this optional argument. (closes issue ASTERISK-14206) Reported by: loloski Patches: 05272009_app_queue.diff uploaded by seanbright (license 71) Tested by: loloski ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=197024 By: Digium Subversion (svnbot) 2009-05-27 09:02:15 Repository: asterisk Revision: 197024 U branches/1.4/apps/app_queue.c ------------------------------------------------------------------------ r197024 | seanbright | 2009-05-27 08:54:35 -0500 (Wed, 27 May 2009) | 17 lines Fix handling of the 'state_interface' option of the 'queue add member' CLI command. This change relates to r184980, which was a backport of the state interface changes to app_queue from trunk. trunk and all of the 1.6.x branches are not affected. 'queue add member' allows for specifying an interface to use for device state when adding a queue member via CLI, but the validation code was not properly updated to reflect this optional argument. (closes issue ASTERISK-14206) Reported by: loloski Patches: 05272009_app_queue.diff uploaded by seanbright (license 71) Tested by: loloski ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=197024 By: Digium Subversion (svnbot) 2009-05-27 09:03:02 Repository: asterisk Revision: 197025 _U trunk/ ------------------------------------------------------------------------ r197025 | seanbright | 2009-05-27 09:03:02 -0500 (Wed, 27 May 2009) | 23 lines Blocked revisions 197024 via svnmerge ........ r197024 | seanbright | 2009-05-27 09:54:35 -0400 (Wed, 27 May 2009) | 17 lines Fix handling of the 'state_interface' option of the 'queue add member' CLI command. This change relates to r184980, which was a backport of the state interface changes to app_queue from trunk. trunk and all of the 1.6.x branches are not affected. 'queue add member' allows for specifying an interface to use for device state when adding a queue member via CLI, but the validation code was not properly updated to reflect this optional argument. (closes issue ASTERISK-14206) Reported by: loloski Patches: 05272009_app_queue.diff uploaded by seanbright (license 71) Tested by: loloski ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=197025 | ||