[Home]

Summary:ASTERISK-14193: [patch] trunk no longer compiles in dev-mode
Reporter:Andrew Lindh (andrew)Labels:
Date Opened:2009-05-22 10:16:32Date Closed:2009-05-22 11:51:53
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:
  [CC] res_agi.c -> res_agi.o
cc1: warnings being treated as errors
res_agi.c: In function 'write_htmldump':
res_agi.c:3204: warning: assignment discards qualifiers from pointer target type
make[1]: *** [res_agi.o] Error 1
make: *** [res] Error 2


****** ADDITIONAL INFORMATION ******

This cast seems to resolve the issue..... but there are other ways to do it too.

Index: res/res_agi.c
===================================================================
--- res/res_agi.c       (revision 196184)
+++ res/res_agi.c       (working copy)
@@ -3201,7 +3201,7 @@
               stringptmp = ast_xmldoc_printable(command->usage, 0);
               stringp = stringptmp;
#else
-               stringp = command->usage;
+               stringp = (char *) command->usage;
#endif
               tempstr = strsep(&stringp, "\n");
Comments:By: Digium Subversion (svnbot) 2009-05-22 11:51:23

Repository: asterisk
Revision: 196270

U   trunk/res/res_agi.c

------------------------------------------------------------------------
r196270 | seanbright | 2009-05-22 11:51:23 -0500 (Fri, 22 May 2009) | 9 lines

Fix res_agi compilation after the const-ify the world merge.

Since we are dealing with a 'const char * const' now, we have to create a
temporary copy of the string to work on rather than the original.  Fix inspired
by reporter.  Reviewed by everyone-and-their-mother in #asterisk-dev.

(closes issue ASTERISK-14193)
Reported by: andrew

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=196270
By: Digium Subversion (svnbot) 2009-05-22 11:51:53

Repository: asterisk
Revision: 196271

_U  branches/1.6.2/

------------------------------------------------------------------------
r196271 | seanbright | 2009-05-22 11:51:53 -0500 (Fri, 22 May 2009) | 15 lines

Blocked revisions 196270 via svnmerge

........
 r196270 | seanbright | 2009-05-22 12:51:22 -0400 (Fri, 22 May 2009) | 9 lines
 
 Fix res_agi compilation after the const-ify the world merge.
 
 Since we are dealing with a 'const char * const' now, we have to create a
 temporary copy of the string to work on rather than the original.  Fix inspired
 by reporter.  Reviewed by everyone-and-their-mother in #asterisk-dev.
 
 (closes issue ASTERISK-14193)
 Reported by: andrew
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=196271