Summary:	ASTERISK-14169: [patch] MGCP Business Phone Packages patch
Reporter:	Miloš Kozák (lejmr)	Labels:
Date Opened:	2009-05-19 13:31:20	Date Closed:	2011-06-07 14:00:33
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_mgcp/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) bug_15159_mgcp.diff ( 1) rfc3149.patch ( 2) rfc3149-trunk.patch
Description:	I am sending patch for MGCP signaling channel. This channel implements functionality for business phones defined in RFC 3149. There is full implementation of KY package which handles signals end events corresponding to function keys.. Also there is full implementation of XML package. I am new to asterisk code so please inform me about my asterisk coding rules mistakes. Thanks Milos ****** ADDITIONAL INFORMATION ****** (inline patch removed by lmadsen)
Comments:	By: Gregory Hinton Nietsky (irroot) 2009-05-19 13:33:38 the natives are going to get restless you need to post the patch disclaimed to digium with a licence ... upload the patch as a file ticking the "code/dox" button. By: Leif Madsen (lmadsen) 2009-05-20 07:28:09 What functionality is this patch giving beyond the existing chan_mgcp? (out of curiosity) By: Leif Madsen (lmadsen) 2009-05-20 07:29:55 Additionally, since this is a new feature, please make sure your patch is against Asterisk trunk, and not one of the release branches. For coding guidelines and such, you will want to review the following site: http://www.asterisk.org/developers Specifically:  http://www.asterisk.org/developers/coding-guidelines Thanks! By: Miloš Kozák (lejmr) 2009-05-20 13:20:34 I am sorry about the patch, now I have fixed it.. Yes it is giving new feature which allows you to use function keys and their indications, also it is giving support for LCD display.. So now you can create XML file which describes information showed at LCD display... It is vendor independent.. By: philipp2 (philipp2) 2009-05-20 19:02:45 Which phone(s) did you test this with? By: Miloš Kozák (lejmr) 2009-05-21 01:30:20 I had Swissvoice IP10S only, but this implementation is vendor independent, because in mgcp.conf you specify function which you want use and function key number, that is all.. Example: fk1=FK_DND - assigns function DND to function key 1.. Read RFC 3149, there is everything about those packages.. By: snuffy (snuffy) 2009-08-27 07:05:52 I have updated the patch a bit, pretty much ONLY CODING-GUIDELINES Note: There are warnings and it will still fail to compile under dev-mode chan_mgcp.c: In function 'parse_params': chan_mgcp.c:4374: warning: passing argument 1 of 'strncpy' discards qualifiers from pointer target type chan_mgcp.c: In function 'rfc3149_conf_pickup': chan_mgcp.c:5587: warning: assignment discards qualifiers from pointer target type make[1]: *** [chan_mgcp.o] Error 1 By: Leif Madsen (lmadsen) 2009-09-22 08:41:11 I'm marking this as Ready for Testing even though 'Confirmed' is probably more appropriate, but hey, why not get some testing if we can :) Apparently it compiles... If someone can gather some troops from the asterisk-users and/or asterisk-dev mailing list to test and report back here, that will go a long ways in moving this issue forward. Thanks! By: John Todd (jtodd) 2010-05-18 13:49:42 I would suggest that the topic of this comes up on asterisk-dev or asterisk-users where there may be some MGCP users.  Also look through prior issues for people working on MGCP, and contact them directly to see if they can help you testing.  We really can't commit this without any testing, but it looks like a GREAT feature set. By: Leif Madsen (lmadsen) 2011-05-27 11:00:45 I'm closing this issue as suspended because there has been no movement on this issue in nearly a year. Please feel free to reopen it (or request a bug marshal to reopen it) if you're interested in moving this issue forward.