[Home]

Summary:ASTERISK-14163: [patch] 64 bit system channel name uniqueness
Reporter:Paul Albrecht (palbrecht)Labels:
Date Opened:2009-05-19 09:02:29Date Closed:2009-11-02 15:11:39.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/Channels
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090826__issue15152.diff.txt
Description:For sip channels, the channel name is set in sip_new by calling ast_channel_alloc with format string "SIP/%s-%08x", where the the string is a host address and the number is a pointer to the channel's private data.

The names of the active sip channels are guaranteed to be unique, only if asterisk data pointers are 32 bits, that is, when asterisk is compiled on a 32 bit system.

If, on the other hand, asterisk is compiled on a 64 bit system, pointers are 64 bits and a 32 bit data pointer is ambiguous because heap is allocated both above and below 4 gigabytes.

Comments:By: Digium Subversion (svnbot) 2009-11-02 14:58:12.000-0600

Repository: asterisk
Revision: 226972

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r226972 | dbrooks | 2009-11-02 14:58:11 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226972
By: Digium Subversion (svnbot) 2009-11-02 15:03:04.000-0600

Repository: asterisk
Revision: 226973

_U  trunk/

------------------------------------------------------------------------
r226973 | dbrooks | 2009-11-02 15:03:03 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226973
By: Digium Subversion (svnbot) 2009-11-02 15:04:56.000-0600

Repository: asterisk
Revision: 226974

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r226974 | dbrooks | 2009-11-02 15:04:56 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226974
By: Digium Subversion (svnbot) 2009-11-02 15:09:10.000-0600

Repository: asterisk
Revision: 226975

_U  branches/1.6.0/

------------------------------------------------------------------------
r226975 | dbrooks | 2009-11-02 15:09:10 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226975
By: Digium Subversion (svnbot) 2009-11-02 15:10:42.000-0600

Repository: asterisk
Revision: 226976

U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r226976 | dbrooks | 2009-11-02 15:10:42 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226976
By: Digium Subversion (svnbot) 2009-11-02 15:11:17.000-0600

Repository: asterisk
Revision: 226977

U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r226977 | dbrooks | 2009-11-02 15:11:16 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226977
By: Digium Subversion (svnbot) 2009-11-02 15:11:39.000-0600

Repository: asterisk
Revision: 226978

U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r226978 | dbrooks | 2009-11-02 15:11:38 -0600 (Mon, 02 Nov 2009) | 12 lines

SIP channel name uniqueness

SIP channel names were supposed to be unique by way of a name suffix derived from the
pointer to the channel's private data. Uniqueness was preserved on 32-bit systems, but
not on 64-bit systems. This patch, as suggested by kpfleming, replaces this suffix with
a simple incremented unsigned int.

(closes issue ASTERISK-14163)
Reported by: palbrecht

Review: https://reviewboard.asterisk.org/r/420/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226978