Summary:	ASTERISK-14134: [patch] calling ConfBridge() with no timing source causes segfault
Reporter:	Kevin Otte (kjotte)	Labels:
Date Opened:	2009-12-19 10:38:18.000-0600	Date Closed:	2010-02-18 15:26:43.000-0600
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_confbridge
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) gdb-confbridge-notiming.txt ( 1) M16471.diff
Description:	Calling ConfBridge() with no res_timing_* module loaded causes a segmentation fault and brings down the whole PBX.  Perhaps some check for a valid timing source needs to be made on the way in and drop the call if none exists?
Comments:	By: Kevin Otte (kjotte) 2009-12-19 10:40:52.000-0600 Sorry, reproducibility should be "always".  Just tried it three times in a row and failed each time. By: Clod Patry (junky) 2009-12-20 14:47:23.000-0600 try with this fix. I tested with no res_timing* By: Kevin Otte (kjotte) 2009-12-20 15:12:53.000-0600 Much better! Got [Dec 20 16:11:32] ERROR[21249]: app_confbridge.c:435 join_conference_bridge: Conference bridge '1234' could not be created. as expected. By: Stefan Reuter (srt) 2010-01-21 18:22:30.000-0600 There are more places where bridge->bridge_pvt is accessed without a proper check which cause additional segfaults. Example: In line 275 of bridge/bridge_softmix.c I had to replace ast_timer_ack(timer, 1); by if (bridge->bridge_pvt) {  ast_timer_ack(timer, 1); } By: Digium Subversion (svnbot) 2010-02-18 15:23:49.000-0600 Repository: asterisk Revision: 247770 U   trunk/bridges/bridge_softmix.c ------------------------------------------------------------------------ r247770 | dvossel | 2010-02-18 15:23:49 -0600 (Thu, 18 Feb 2010) | 9 lines fixes confbridge crash when no timing module is loaded. (closes issue ASTERISK-14134) Reported by: kjotte Patches:      M16471.diff uploaded by junky (license 177) Tested by: kjotte, junky ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=247770 By: Digium Subversion (svnbot) 2010-02-18 15:25:03.000-0600 Repository: asterisk Revision: 247776 _U  branches/1.6.2/ U   branches/1.6.2/bridges/bridge_softmix.c ------------------------------------------------------------------------ r247776 | dvossel | 2010-02-18 15:25:03 -0600 (Thu, 18 Feb 2010) | 15 lines Merged revisions 247770 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r247770 | dvossel | 2010-02-18 15:23:48 -0600 (Thu, 18 Feb 2010) | 9 lines    fixes confbridge crash when no timing module is loaded.    (closes issue ASTERISK-14134)  Reported by: kjotte  Patches:        M16471.diff uploaded by junky (license 177)  Tested by: kjotte, junky ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=247776 By: Digium Subversion (svnbot) 2010-02-18 15:26:07.000-0600 Repository: asterisk Revision: 247779 _U  branches/1.6.1/ ------------------------------------------------------------------------ r247779 | dvossel | 2010-02-18 15:26:07 -0600 (Thu, 18 Feb 2010) | 14 lines Blocked revisions 247770 via svnmerge ........  r247770 | dvossel | 2010-02-18 15:23:48 -0600 (Thu, 18 Feb 2010) | 9 lines    fixes confbridge crash when no timing module is loaded.    (closes issue ASTERISK-14134)  Reported by: kjotte  Patches:        M16471.diff uploaded by junky (license 177)  Tested by: kjotte, junky ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=247779 By: Digium Subversion (svnbot) 2010-02-18 15:26:42.000-0600 Repository: asterisk Revision: 247783 _U  branches/1.6.0/ ------------------------------------------------------------------------ r247783 | dvossel | 2010-02-18 15:26:42 -0600 (Thu, 18 Feb 2010) | 14 lines Blocked revisions 247770 via svnmerge ........  r247770 | dvossel | 2010-02-18 15:23:48 -0600 (Thu, 18 Feb 2010) | 9 lines    fixes confbridge crash when no timing module is loaded.    (closes issue ASTERISK-14134)  Reported by: kjotte  Patches:        M16471.diff uploaded by junky (license 177)  Tested by: kjotte, junky ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=247783 By: feyfre (feyfre) 2012-02-29 08:50:17.320-0600 This bug also present in whole 10.x branch. And can be resolved by provided here patch.