[Home]

Summary:ASTERISK-14121: [patch] Directed pickup : picker picks own channel instead of called party's channel
Reporter:Laurent Steffan (lmsteffan)Labels:
Date Opened:2009-05-13 16:09:49Date Closed:2009-09-24 09:17:45
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_directed_pickup
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) pickup.patch
Description:When trying to pickup an extension, Asterisk does not identify the correct channel. The error messages are (picker being 53, called party 52) :

chan_sip.c: Trying to pick up 52@default
channel.c: Can't masquerade channel 'SIP/53-0a273e48' into itself!
app_directed_pickup.c: Unable to masquerade 'SIP/53-0a273e48' into 'SIP/53-0a273e48'app_directed_pickup.c: No target channel found for 52

It appears that the function pickup_by_exten does not check that the channel it has found is not its own. The included patch seems to correct that behaviour.
Comments:By: Digium Subversion (svnbot) 2009-09-14 09:55:30

Repository: asterisk
Revision: 218223

U   branches/1.4/apps/app_directed_pickup.c

------------------------------------------------------------------------
r218223 | mnicholson | 2009-09-14 09:55:29 -0500 (Mon, 14 Sep 2009) | 8 lines

Ensure we don't pickup ourselves when doing pickup by exten.

(closes issue ASTERISK-14121)
Reported by: lmsteffan
Patches:
     (modified) pickup.patch uploaded by lmsteffan (license 779)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218223
By: Digium Subversion (svnbot) 2009-09-14 09:58:55

Repository: asterisk
Revision: 218224

_U  trunk/
U   trunk/apps/app_directed_pickup.c

------------------------------------------------------------------------
r218224 | mnicholson | 2009-09-14 09:58:55 -0500 (Mon, 14 Sep 2009) | 14 lines

Merged revisions 218223 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8 lines
 
 Ensure we don't pickup ourselves when doing pickup by exten.
 
 (closes issue ASTERISK-14121)
 Reported by: lmsteffan
 Patches:
       (modified) pickup.patch uploaded by lmsteffan (license 779)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218224
By: Digium Subversion (svnbot) 2009-09-14 10:19:23

Repository: asterisk
Revision: 218227

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_directed_pickup.c

------------------------------------------------------------------------
r218227 | mnicholson | 2009-09-14 10:19:22 -0500 (Mon, 14 Sep 2009) | 21 lines

Merged revisions 218224 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218224 | mnicholson | 2009-09-14 09:57:23 -0500 (Mon, 14 Sep 2009) | 14 lines
 
 Merged revisions 218223 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8 lines
   
   Ensure we don't pickup ourselves when doing pickup by exten.
   
   (closes issue ASTERISK-14121)
   Reported by: lmsteffan
   Patches:
         (modified) pickup.patch uploaded by lmsteffan (license 779)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218227
By: Digium Subversion (svnbot) 2009-09-14 10:22:13

Repository: asterisk
Revision: 218238

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_directed_pickup.c

------------------------------------------------------------------------
r218238 | mnicholson | 2009-09-14 10:22:13 -0500 (Mon, 14 Sep 2009) | 21 lines

Merged revisions 218224 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218224 | mnicholson | 2009-09-14 09:57:23 -0500 (Mon, 14 Sep 2009) | 14 lines
 
 Merged revisions 218223 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8 lines
   
   Ensure we don't pickup ourselves when doing pickup by exten.
   
   (closes issue ASTERISK-14121)
   Reported by: lmsteffan
   Patches:
         (modified) pickup.patch uploaded by lmsteffan (license 779)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218238
By: Digium Subversion (svnbot) 2009-09-14 10:23:45

Repository: asterisk
Revision: 218244

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_directed_pickup.c

------------------------------------------------------------------------
r218244 | mnicholson | 2009-09-14 10:23:44 -0500 (Mon, 14 Sep 2009) | 21 lines

Merged revisions 218224 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218224 | mnicholson | 2009-09-14 09:57:23 -0500 (Mon, 14 Sep 2009) | 14 lines
 
 Merged revisions 218223 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8 lines
   
   Ensure we don't pickup ourselves when doing pickup by exten.
   
   (closes issue ASTERISK-14121)
   Reported by: lmsteffan
   Patches:
         (modified) pickup.patch uploaded by lmsteffan (license 779)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218244