Summary:	ASTERISK-14108: [patch] Support for event keep-alive for Linksys NAT pinhole
Reporter:	Igor Goncharovsky (igorg)	Labels:
Date Opened:	2009-05-11 22:34:15	Date Closed:	2010-06-18 21:44:57
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Interoperability
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_sip.keepalive.v1.diff
Description:	Two years ago in issue ASTERISK-9057 support of this event was requested, used by Linksys for NAT keepalive. Actually with current implementation there is no problem with NAT, but tons of "489 Bad event" errors confusing for user and make them think that NAT issues exists because this event unsupported
Comments:	By: Leif Madsen (lmadsen) 2009-09-01 16:07:59 Assigned to dvossel for review. By: Digium Subversion (svnbot) 2009-09-02 11:08:45 Repository: asterisk Revision: 215466 U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r215466 | dvossel | 2009-09-02 11:08:45 -0500 (Wed, 02 Sep 2009) | 16 lines SIP support for keep-alive event keep-alive events are used by Sipura/Linksys for NAT keepalive. There currently don't appear to be any problems with NAT, but everytime a keep-alive event is received, Asterisk responds with a "489 Bad event".  This error may indicate to a user that NAT problems exist just because this even is not supported.  Now, rather than respond with an error, the packet is consumed and a "200 ok" is sent just to indicate we received the packet. (issue ASTERISK-14108) Patches:      chan_sip.keepalive.v1.diff uploaded by IgorG (license 20) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=215466 By: Digium Subversion (svnbot) 2009-09-02 11:09:58 Repository: asterisk Revision: 215467 _U  branches/1.6.2/ U   branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r215467 | dvossel | 2009-09-02 11:09:58 -0500 (Wed, 02 Sep 2009) | 21 lines Merged revisions 215466 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r215466 | dvossel | 2009-09-02 11:08:00 -0500 (Wed, 02 Sep 2009) | 16 lines    SIP support for keep-alive event    keep-alive events are used by Sipura/Linksys for NAT keepalive.  There currently don't appear to be any problems with NAT, but  everytime a keep-alive event is received, Asterisk responds with a  "489 Bad event".  This error may indicate to a user that NAT  problems exist just because this even is not supported.  Now,  rather than respond with an error, the packet is consumed and  a "200 ok" is sent just to indicate we received the packet.    (issue ASTERISK-14108)  Patches:        chan_sip.keepalive.v1.diff uploaded by IgorG (license 20) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=215467 By: Digium Subversion (svnbot) 2009-09-02 11:10:41 Repository: asterisk Revision: 215468 _U  branches/1.6.1/ ------------------------------------------------------------------------ r215468 | dvossel | 2009-09-02 11:10:40 -0500 (Wed, 02 Sep 2009) | 20 lines Blocked revisions 215466 via svnmerge ........  r215466 | dvossel | 2009-09-02 11:08:00 -0500 (Wed, 02 Sep 2009) | 16 lines    SIP support for keep-alive event    keep-alive events are used by Sipura/Linksys for NAT keepalive.  There currently don't appear to be any problems with NAT, but  everytime a keep-alive event is received, Asterisk responds with a  "489 Bad event".  This error may indicate to a user that NAT  problems exist just because this even is not supported.  Now,  rather than respond with an error, the packet is consumed and  a "200 ok" is sent just to indicate we received the packet.    (issue ASTERISK-14108)  Patches:        chan_sip.keepalive.v1.diff uploaded by IgorG (license 20) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=215468 By: Digium Subversion (svnbot) 2009-09-02 11:11:05 Repository: asterisk Revision: 215469 _U  branches/1.6.0/ ------------------------------------------------------------------------ r215469 | dvossel | 2009-09-02 11:11:05 -0500 (Wed, 02 Sep 2009) | 20 lines Blocked revisions 215466 via svnmerge ........  r215466 | dvossel | 2009-09-02 11:08:00 -0500 (Wed, 02 Sep 2009) | 16 lines    SIP support for keep-alive event    keep-alive events are used by Sipura/Linksys for NAT keepalive.  There currently don't appear to be any problems with NAT, but  everytime a keep-alive event is received, Asterisk responds with a  "489 Bad event".  This error may indicate to a user that NAT  problems exist just because this even is not supported.  Now,  rather than respond with an error, the packet is consumed and  a "200 ok" is sent just to indicate we received the packet.    (issue ASTERISK-14108)  Patches:        chan_sip.keepalive.v1.diff uploaded by IgorG (license 20) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=215469 By: David Vossel (dvossel) 2009-09-02 11:17:53 I committed the patch into trunk and 1.6.2...  The patch won't apply for 1.4, 1.6.0, and 1.6.1.  It appears handle_request_notify() contains different logic for those branches, and after reviewing it, I'm not even sure a patch is required for them.  Have you tested this with any of those branches to see if the problem exists there as well?  If so, they will need a separate patch.  Thanks for the contribution! By: Igor Goncharovsky (igorg) 2009-09-06 00:54:07 Yes, it is different logic in these versions. When patch developed I assume hat as some new functionality, so no problem to include it only in trunk and 1.6.2. Thank you for you work!