[Home]

Summary:ASTERISK-14106: MOH not closing calls correctly
Reporter:David Vossel (dvossel)Labels:
Date Opened:2009-05-11 09:47:19Date Closed:2009-05-11 17:12:24
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The MusicOnHold app isn't hanging up calls correctly.  For example, if a SIP phone calls extension 1111 in my dial plan, it is directed to MOH.  If that phone hangs up, MOH stays up and the channel is still visible via "core show channels".  CLI output is provided. musiconhold.conf is using files mode.


extensions.conf
exten => 1111,1,Answer()
exten => 1111,n,MusicOnHold()

****** ADDITIONAL INFORMATION ******

*CLI>     -- Accepted AUTHENTICATED TBD call from 10.24.20.218
   -- Accepting DIAL from 10.24.20.218, formats = 0x4
   -- Executing [1111@local:1] Answer("IAX2/iaxy-16379", "") in new stack
   -- Executing [1111@local:2] MusicOnHold("IAX2/iaxy-16379", "") in new stack
   -- Started music on hold, class 'default', on IAX2/iaxy-16379
   -- Accepted AUTHENTICATED TBD call from 10.24.20.218
core show channels
Channel              Location             State   Application(Data)            
IAX2/iaxy-16379      1111@local:2         Up      MusicOnHold()                
1 active channel
1 active call
1 call processed
*CLI>     -- Accepting DIAL from 10.24.20.218, formats = 0x4
   -- Executing [1111@local:1] Answer("IAX2/iaxy-1490", "") in new stack
   -- Executing [1111@local:2] MusicOnHold("IAX2/iaxy-1490", "") in new stack
   -- Started music on hold, class 'default', on IAX2/iaxy-1490

*CLI>
*CLI>
*CLI>
*CLI> core show channels
Channel              Location             State   Application(Data)            
IAX2/iaxy-16379      1111@local:2         Up      MusicOnHold()                
IAX2/iaxy-1490       1111@local:2         Up      MusicOnHold()                
2 active channels
2 active calls
2 calls processed
Comments:By: Digium Subversion (svnbot) 2009-05-11 17:04:44

Repository: asterisk
Revision: 193718

U   trunk/res/res_timing_timerfd.c

------------------------------------------------------------------------
r193718 | russell | 2009-05-11 17:04:43 -0500 (Mon, 11 May 2009) | 12 lines

Fix some timer state corruption.

In res_timer_timerfd, handle the case that set_rate gets called while a timer
is still in continuous mode.  In this case, we want to remember the configured
rate, but not actually set it until continuous mode has been disabled.

Thanks to dvossel for finding and helping to debug the problem.

(closes issue ASTERISK-14106)
Reported by: dvossel
Tested by: dvossel

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=193718

By: Digium Subversion (svnbot) 2009-05-11 17:12:23

Repository: asterisk
Revision: 193719

_U  branches/1.6.2/
U   branches/1.6.2/res/res_timing_timerfd.c

------------------------------------------------------------------------
r193719 | russell | 2009-05-11 17:12:23 -0500 (Mon, 11 May 2009) | 20 lines

Merged revisions 193718 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r193718 | russell | 2009-05-11 17:04:40 -0500 (Mon, 11 May 2009) | 12 lines

Fix some timer state corruption.

In res_timer_timerfd, handle the case that set_rate gets called while a timer
is still in continuous mode.  In this case, we want to remember the configured
rate, but not actually set it until continuous mode has been disabled.

Thanks to dvossel for finding and helping to debug the problem.

(closes issue ASTERISK-14106)
Reported by: dvossel
Tested by: dvossel

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=193719