| Summary: | ASTERISK-14098: [patch] Possible crash in pbx_spool.c - operation on previously freed structure | ||
| Reporter: | Grzegorz Garlewicz (garlew) | Labels: | |
| Date Opened: | 2009-05-09 03:01:21 | Date Closed: | 2009-06-03 15:51:59 |
| Priority: | Critical | Regression? | No |
| Status: | Closed/Complete | Components: | PBX/pbx_spool |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) spool.diff | |
| Description: | see the patch | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-05-12 07:59:32 How are you reproducing this? Or did you just find this in a code review? By: Grzegorz Garlewicz (garlew) 2009-05-12 08:18:05 Just a code review. The reason for review was I got several files stuck in spool directory, strange because it should have been fixed recently. By: Leif Madsen (lmadsen) 2009-05-12 08:31:46 Have you tried checking the latest 1.4 SVN branch to see if it has been resolved post-1.4.24? By: Grzegorz Garlewicz (garlew) 2009-05-12 14:48:10 Sure I have. No commit since 2008-12-03. By: Leif Madsen (lmadsen) 2009-05-12 16:20:38 Thanks for the quick response garlew! By: Grzegorz Garlewicz (garlew) 2009-06-02 14:29:48 Isn't it obvoius enough that it should go in right away? By: David Brooks (dbrooks) 2009-06-03 11:18:49 Patch seems reasonable to me. By: Digium Subversion (svnbot) 2009-06-03 15:39:11 Repository: asterisk Revision: 198957 U branches/1.4/pbx/pbx_spool.c ------------------------------------------------------------------------ r198957 | seanbright | 2009-06-03 15:39:10 -0500 (Wed, 03 Jun 2009) | 11 lines Fix a possible crash in pbx_spool. We were trying to reference members of a struct that had previously been freed. This patch makes sure that we free the struct after it has been removed from the spooler queue. (closes issue ASTERISK-14098) Reported by: garlew Patches: spool.diff uploaded by garlew (license 376) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198957 By: Digium Subversion (svnbot) 2009-06-03 15:49:11 Repository: asterisk Revision: 198958 _U trunk/ ------------------------------------------------------------------------ r198958 | seanbright | 2009-06-03 15:49:11 -0500 (Wed, 03 Jun 2009) | 17 lines Blocked revisions 198957 via svnmerge ........ r198957 | seanbright | 2009-06-03 16:39:10 -0400 (Wed, 03 Jun 2009) | 11 lines Fix a possible crash in pbx_spool. We were trying to reference members of a struct that had previously been freed. This patch makes sure that we free the struct after it has been removed from the spooler queue. (closes issue ASTERISK-14098) Reported by: garlew Patches: spool.diff uploaded by garlew (license 376) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198958 By: Digium Subversion (svnbot) 2009-06-03 15:51:45 Repository: asterisk Revision: 198959 _U branches/1.6.0/ ------------------------------------------------------------------------ r198959 | seanbright | 2009-06-03 15:51:45 -0500 (Wed, 03 Jun 2009) | 23 lines Blocked revisions 198958 via svnmerge ................ r198958 | seanbright | 2009-06-03 16:49:11 -0400 (Wed, 03 Jun 2009) | 17 lines Blocked revisions 198957 via svnmerge ........ r198957 | seanbright | 2009-06-03 16:39:10 -0400 (Wed, 03 Jun 2009) | 11 lines Fix a possible crash in pbx_spool. We were trying to reference members of a struct that had previously been freed. This patch makes sure that we free the struct after it has been removed from the spooler queue. (closes issue ASTERISK-14098) Reported by: garlew Patches: spool.diff uploaded by garlew (license 376) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198959 By: Digium Subversion (svnbot) 2009-06-03 15:51:51 Repository: asterisk Revision: 198960 _U branches/1.6.1/ ------------------------------------------------------------------------ r198960 | seanbright | 2009-06-03 15:51:51 -0500 (Wed, 03 Jun 2009) | 23 lines Blocked revisions 198958 via svnmerge ................ r198958 | seanbright | 2009-06-03 16:49:11 -0400 (Wed, 03 Jun 2009) | 17 lines Blocked revisions 198957 via svnmerge ........ r198957 | seanbright | 2009-06-03 16:39:10 -0400 (Wed, 03 Jun 2009) | 11 lines Fix a possible crash in pbx_spool. We were trying to reference members of a struct that had previously been freed. This patch makes sure that we free the struct after it has been removed from the spooler queue. (closes issue ASTERISK-14098) Reported by: garlew Patches: spool.diff uploaded by garlew (license 376) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198960 By: Digium Subversion (svnbot) 2009-06-03 15:51:58 Repository: asterisk Revision: 198961 _U branches/1.6.2/ ------------------------------------------------------------------------ r198961 | seanbright | 2009-06-03 15:51:58 -0500 (Wed, 03 Jun 2009) | 23 lines Blocked revisions 198958 via svnmerge ................ r198958 | seanbright | 2009-06-03 16:49:11 -0400 (Wed, 03 Jun 2009) | 17 lines Blocked revisions 198957 via svnmerge ........ r198957 | seanbright | 2009-06-03 16:39:10 -0400 (Wed, 03 Jun 2009) | 11 lines Fix a possible crash in pbx_spool. We were trying to reference members of a struct that had previously been freed. This patch makes sure that we free the struct after it has been removed from the spooler queue. (closes issue ASTERISK-14098) Reported by: garlew Patches: spool.diff uploaded by garlew (license 376) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198961 | ||