[Home]

Summary:ASTERISK-14088: [patch] Voicemail password changes not working as expected
Reporter:Jonathan Thurman (jthurman)Labels:
Date Opened:2009-05-07 17:19:40Date Closed:2009-09-14 14:53:24
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) vm_newuser.patch
( 1) vm_newuser-unlimited-retries.patch
Description:When a user is forced to change their voicemail password and they fail to choose a password that is valid (either length, or external check script) more than 'maxlogins' times, then they are asked to try again and voicemail hangs up.

Also if you use the menu option to change your password and you enter an invalid password, it drops you back to the mailbox options menu instead of asking you for your new password again.  If you change your mind about changing your password, you should be able to hit * to return to the mailbox options menu.

****** ADDITIONAL INFORMATION ******

Tested only with plain voicemail.
Asterisk 1.6.1.0
CentOS 5.3 x86_64
Comments:By: Tilghman Lesher (tilghman) 2009-05-07 18:22:50

On the first one, I can certainly understand, and we can work to fix that issue.  On the second issue, that's just a personal preference and not actually a bug.
By: Jonathan Thurman (jthurman) 2009-05-07 21:41:57

I don't know.  While it is not an operational bug, I definitely think it does not flow very well when the voice prompts say "The passwords you entered and reentered do not match.  Please try again, Press 1 to record your unavailable message...".  The addition of the * to exit was just a suggestion to prevent a continuous loop causing the end user to just hangup to get out.  It also follows the standards that the voicemail system uses for returning to a previous menu.
By: Jonathan Thurman (jthurman) 2009-05-07 23:26:24

I found the line that caused this issue.  There was a specific limit of 3 retries in the code.  This just happened to be what my 'maxlogins' was set to.  If that code is removed, the only way out was to hang up.  As a alternative, I added a * command disconnect gracefully.
By: Jonathan Thurman (jthurman) 2009-05-08 00:09:50

It must be getting late... After a little more testing it appears that pressing # does the same thing as my patch for *.  I suggest one of two things.  Either just remove the retry limit and leave the rest of the code the way it was, or make * drop the user back to the initial login prompt.  I will modify my patch in the morning for the first, and look into the second.
By: Jonathan Thurman (jthurman) 2009-05-08 10:05:56

The new patch just removes the 3 tries and your out clause.  Users will need to press #, wait for the timeout, or hangup to abort changing their password for the first time (with forcename or forcegreetings set to yes)
By: Tilghman Lesher (tilghman) 2009-09-14 12:42:55

jthurman:  I don't disagree with you on the prompts, so the prompts will be changed so that it does not do that.  The '*' returning you to the previous menu, though, is a new feature and will only be implemented in trunk (for versions 1.6.3 and later).
By: Jonathan Thurman (jthurman) 2009-09-14 13:59:33

tilghman: That sounds reasonable. I guess I will just keep backporting the * fix until 1.6.3 is stable...
By: Digium Subversion (svnbot) 2009-09-14 14:18:09

Repository: asterisk
Revision: 218331

U   branches/1.4/apps/app_voicemail.c
U   branches/1.4/sounds/Makefile

------------------------------------------------------------------------
r218331 | tilghman | 2009-09-14 14:18:08 -0500 (Mon, 14 Sep 2009) | 4 lines

Don't say "Please try again" if we don't give the user another chance to try again.
(issue ASTERISK-14088, SWP-129)
Reported by: jthurman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218331
By: Digium Subversion (svnbot) 2009-09-14 14:31:22

Repository: asterisk
Revision: 218361

_U  trunk/
U   trunk/apps/app_voicemail.c
U   trunk/configs/voicemail.conf.sample
U   trunk/sounds/Makefile

------------------------------------------------------------------------
r218361 | tilghman | 2009-09-14 14:31:21 -0500 (Mon, 14 Sep 2009) | 11 lines

Recorded merge of revisions 218331 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines
 
 Don't say "Please try again" if we don't give the user another chance to try again.
 (issue ASTERISK-14088, SWP-129)
  Reported by: jthurman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218361
By: Digium Subversion (svnbot) 2009-09-14 14:50:38

Repository: asterisk
Revision: 218362

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_voicemail.c
U   branches/1.6.0/configs/voicemail.conf.sample
U   branches/1.6.0/sounds/Makefile

------------------------------------------------------------------------
r218362 | tilghman | 2009-09-14 14:50:38 -0500 (Mon, 14 Sep 2009) | 18 lines

Merged revisions 218361 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218361 | tilghman | 2009-09-14 14:29:48 -0500 (Mon, 14 Sep 2009) | 11 lines
 
 Recorded merge of revisions 218331 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines
   
   Don't say "Please try again" if we don't give the user another chance to try again.
   (issue ASTERISK-14088, SWP-129)
    Reported by: jthurman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218362
By: Digium Subversion (svnbot) 2009-09-14 14:50:51

Repository: asterisk
Revision: 218363

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_voicemail.c
U   branches/1.6.1/configs/voicemail.conf.sample
U   branches/1.6.1/sounds/Makefile

------------------------------------------------------------------------
r218363 | tilghman | 2009-09-14 14:50:51 -0500 (Mon, 14 Sep 2009) | 18 lines

Merged revisions 218361 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218361 | tilghman | 2009-09-14 14:29:48 -0500 (Mon, 14 Sep 2009) | 11 lines
 
 Recorded merge of revisions 218331 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines
   
   Don't say "Please try again" if we don't give the user another chance to try again.
   (issue ASTERISK-14088, SWP-129)
    Reported by: jthurman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218363
By: Digium Subversion (svnbot) 2009-09-14 14:51:05

Repository: asterisk
Revision: 218364

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c
U   branches/1.6.2/configs/voicemail.conf.sample
U   branches/1.6.2/sounds/Makefile

------------------------------------------------------------------------
r218364 | tilghman | 2009-09-14 14:51:05 -0500 (Mon, 14 Sep 2009) | 18 lines

Merged revisions 218361 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218361 | tilghman | 2009-09-14 14:29:48 -0500 (Mon, 14 Sep 2009) | 11 lines
 
 Recorded merge of revisions 218331 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218331 | tilghman | 2009-09-14 14:16:35 -0500 (Mon, 14 Sep 2009) | 4 lines
   
   Don't say "Please try again" if we don't give the user another chance to try again.
   (issue ASTERISK-14088, SWP-129)
    Reported by: jthurman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218364