[Home]

Summary:ASTERISK-14086: [patch] Vietnamese support for Voicemail
Reporter:Nguyen Dinh Trung (dinhtrung)Labels:
Date Opened:2009-05-07 14:16:03Date Closed:2009-12-30 16:41:24.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail.c.diff
( 1) app_voicemail.patch
( 2) say.c.diff
( 3) vietnamese.ods
Description:My patch helps Asterisk support Vietnamese syntax.
Here is the recording files needed to use for voicemail, and patch I got from svn diff. Don't know if it's the correct way to submit feature request here.
Anyway, plz review this patch.

Best regards,
Comments:By: Tilghman Lesher (tilghman) 2009-05-07 18:25:06

Please do NOT paste patches into the text area.  Instead, we have an online licensing system hooked into the file upload area of this issue, which you should use.


By: Nguyen Dinh Trung (dinhtrung) 2009-05-07 21:11:30

Thanks,
After report the bug, I don't see any upload form. But now I knew how to upload them.
By: John Todd (jtodd) 2009-11-20 15:22:00.000-0600

Hello!
 We are very interested in the language files you have created for Vietnamese language.  However, we cannot accept only partial language files.  We would like to create two different issues out of this:

1) The patch you have created for voicemail is OK, and we can probably accept it.  But first you must look at the top bar of your screen (on http://issues.asterisk.org) which should say "Sign License" or something like that.  Fill that out and we can accept your patch.

2) You would need to read the document here for submitting a new language, and you would also need to have a complete set of prompts so we could include them with Asterisk.   Please create a new ticket with the prompts when you complete them.

http://svn.asterisk.org/svn/asterisk/trunk/doc/lang/language-criteria.txt

JT
By: Nguyen Dinh Trung (dinhtrung) 2009-11-20 19:36:56.000-0600

I already sign license for this patch.
Also, since Asterisk 1.6.2 already has separate say.conf for language configuration, this is no need for merging the patch into Asterisk anymore.
By: John Todd (jtodd) 2009-11-20 19:50:37.000-0600

OK, very good.  Is it possible for you to create the prompts?  We are interested in better support for Vietnamese language in Asterisk, but nobody has created Vietnamese prompts yet for distribution.  You could be the first!
By: Nguyen Dinh Trung (dinhtrung) 2009-11-23 09:36:39.000-0600

After reading your links, I think it is imposible for me to maintain the Vietnamese sound files. But I got a collection of sound files from a partner of mine. They won't help me with new recordings. But for core sound files, I already have all.
Also, I updated the patch for Asterisk 1.6.2 rc6.
By: Nguyen Dinh Trung (dinhtrung) 2009-11-23 09:43:04.000-0600

Sorry, can't upload the full sound files.
Download it from here:
http://118.69.225.241:8081/astsound-main-vi.tar.gz
By: Digium Subversion (svnbot) 2009-12-30 16:30:23.000-0600

Repository: asterisk
Revision: 237050

U   trunk/apps/app_voicemail.c
A   trunk/doc/lang/vietnamese.ods
U   trunk/main/say.c

------------------------------------------------------------------------
r237050 | qwell | 2009-12-30 16:30:22 -0600 (Wed, 30 Dec 2009) | 17 lines

Add app_voicemail and say.c support for Vietnamese.

Also add an XXX comment that I'm baffled nobody has ever complained about.  We
say "first message", and then we go into language-specific stuff where we
proceed to say..."first message".

(closes issue ASTERISK-14086)
Reported by: dinhtrung
Patches:
     vietnamese.ods uploaded by dinhtrung (license 776)
     app_voicemail.c.diff uploaded by dinhtrung (license 776)

(closes issue ASTERISK-14575)
Reported by: dinhtrung
Patches:
     say.c.diff uploaded by dinhtrung (license 776)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237050
By: Digium Subversion (svnbot) 2009-12-30 16:40:55.000-0600

Repository: asterisk
Revision: 237060

_U  branches/1.6.0/

------------------------------------------------------------------------
r237060 | qwell | 2009-12-30 16:40:54 -0600 (Wed, 30 Dec 2009) | 23 lines

Blocked revisions 237050 via svnmerge

........
 r237050 | qwell | 2009-12-30 16:30:21 -0600 (Wed, 30 Dec 2009) | 17 lines
 
 Add app_voicemail and say.c support for Vietnamese.
 
 Also add an XXX comment that I'm baffled nobody has ever complained about.  We
 say "first message", and then we go into language-specific stuff where we
 proceed to say..."first message".
 
 (closes issue ASTERISK-14086)
 Reported by: dinhtrung
 Patches:
       vietnamese.ods uploaded by dinhtrung (license 776)
       app_voicemail.c.diff uploaded by dinhtrung (license 776)
 
 (closes issue ASTERISK-14575)
 Reported by: dinhtrung
 Patches:
       say.c.diff uploaded by dinhtrung (license 776)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237060
By: Digium Subversion (svnbot) 2009-12-30 16:41:11.000-0600

Repository: asterisk
Revision: 237061

_U  branches/1.6.1/

------------------------------------------------------------------------
r237061 | qwell | 2009-12-30 16:41:10 -0600 (Wed, 30 Dec 2009) | 23 lines

Blocked revisions 237050 via svnmerge

........
 r237050 | qwell | 2009-12-30 16:30:21 -0600 (Wed, 30 Dec 2009) | 17 lines
 
 Add app_voicemail and say.c support for Vietnamese.
 
 Also add an XXX comment that I'm baffled nobody has ever complained about.  We
 say "first message", and then we go into language-specific stuff where we
 proceed to say..."first message".
 
 (closes issue ASTERISK-14086)
 Reported by: dinhtrung
 Patches:
       vietnamese.ods uploaded by dinhtrung (license 776)
       app_voicemail.c.diff uploaded by dinhtrung (license 776)
 
 (closes issue ASTERISK-14575)
 Reported by: dinhtrung
 Patches:
       say.c.diff uploaded by dinhtrung (license 776)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237061
By: Digium Subversion (svnbot) 2009-12-30 16:41:23.000-0600

Repository: asterisk
Revision: 237062

_U  branches/1.6.2/

------------------------------------------------------------------------
r237062 | qwell | 2009-12-30 16:41:23 -0600 (Wed, 30 Dec 2009) | 23 lines

Blocked revisions 237050 via svnmerge

........
 r237050 | qwell | 2009-12-30 16:30:21 -0600 (Wed, 30 Dec 2009) | 17 lines
 
 Add app_voicemail and say.c support for Vietnamese.
 
 Also add an XXX comment that I'm baffled nobody has ever complained about.  We
 say "first message", and then we go into language-specific stuff where we
 proceed to say..."first message".
 
 (closes issue ASTERISK-14086)
 Reported by: dinhtrung
 Patches:
       vietnamese.ods uploaded by dinhtrung (license 776)
       app_voicemail.c.diff uploaded by dinhtrung (license 776)
 
 (closes issue ASTERISK-14575)
 Reported by: dinhtrung
 Patches:
       say.c.diff uploaded by dinhtrung (license 776)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=237062