| Summary: | ASTERISK-14070: [patch] ignore both DTMF BEGIN and END from RTP when not in RFC2833 mode | ||
| Reporter: | Dmitry Andrianov (dimas) | Labels: | |
| Date Opened: | 2009-05-05 12:33:04 | Date Closed: | 2009-06-29 16:53:31 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) v1-15036.patch | |
| Description: | I encountered this issue helping with 14815. There is a code in chan_sip which drops AST_FRAME_DTMF frames coming from ast_rtp_read if the dtmfmode is not RFC2833. The problem is that only end frame is ignored while begin frame is still passed to the core of Asterisk causing various effects like continuous tone. The patch makes behavior more consistent by dropping begin frames as well. It also logs debug message to let easier troubleshooting. | ||
| Comments: | By: Digium Subversion (svnbot) 2009-05-06 08:30:53 Repository: asterisk Revision: 192633 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r192633 | file | 2009-05-06 08:30:52 -0500 (Wed, 06 May 2009) | 7 lines Update some old logic to stop both begin and end DTMF frames from reaching the core if rfc2833 is not enabled. (closes issue ASTERISK-14070) Reported by: dimas Patches: v1-15036.patch uploaded by dimas (license 88) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192633 By: Digium Subversion (svnbot) 2009-05-06 08:34:36 Repository: asterisk Revision: 192634 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r192634 | file | 2009-05-06 08:34:36 -0500 (Wed, 06 May 2009) | 14 lines Merged revisions 192633 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192633 | file | 2009-05-06 10:30:51 -0300 (Wed, 06 May 2009) | 7 lines Update some old logic to stop both begin and end DTMF frames from reaching the core if rfc2833 is not enabled. (closes issue ASTERISK-14070) Reported by: dimas Patches: v1-15036.patch uploaded by dimas (license 88) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192634 By: Digium Subversion (svnbot) 2009-05-06 08:36:20 Repository: asterisk Revision: 192635 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r192635 | file | 2009-05-06 08:36:20 -0500 (Wed, 06 May 2009) | 21 lines Merged revisions 192634 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192634 | file | 2009-05-06 10:34:35 -0300 (Wed, 06 May 2009) | 14 lines Merged revisions 192633 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192633 | file | 2009-05-06 10:30:51 -0300 (Wed, 06 May 2009) | 7 lines Update some old logic to stop both begin and end DTMF frames from reaching the core if rfc2833 is not enabled. (closes issue ASTERISK-14070) Reported by: dimas Patches: v1-15036.patch uploaded by dimas (license 88) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192635 By: Digium Subversion (svnbot) 2009-05-06 08:37:16 Repository: asterisk Revision: 192636 _U branches/1.6.1/ U branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r192636 | file | 2009-05-06 08:37:16 -0500 (Wed, 06 May 2009) | 21 lines Merged revisions 192634 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192634 | file | 2009-05-06 10:34:35 -0300 (Wed, 06 May 2009) | 14 lines Merged revisions 192633 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192633 | file | 2009-05-06 10:30:51 -0300 (Wed, 06 May 2009) | 7 lines Update some old logic to stop both begin and end DTMF frames from reaching the core if rfc2833 is not enabled. (closes issue ASTERISK-14070) Reported by: dimas Patches: v1-15036.patch uploaded by dimas (license 88) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192636 By: Digium Subversion (svnbot) 2009-05-06 08:38:14 Repository: asterisk Revision: 192637 _U branches/1.6.2/ U branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r192637 | file | 2009-05-06 08:38:14 -0500 (Wed, 06 May 2009) | 21 lines Merged revisions 192634 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192634 | file | 2009-05-06 10:34:35 -0300 (Wed, 06 May 2009) | 14 lines Merged revisions 192633 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192633 | file | 2009-05-06 10:30:51 -0300 (Wed, 06 May 2009) | 7 lines Update some old logic to stop both begin and end DTMF frames from reaching the core if rfc2833 is not enabled. (closes issue ASTERISK-14070) Reported by: dimas Patches: v1-15036.patch uploaded by dimas (license 88) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192637 | ||