[Home]

Summary:ASTERISK-14067: chan_sip sets PRIREDIRECTREASON incorrectly for reason no-answer
Reporter:Johann Steinwendtner (steinwej)Labels:
Date Opened:2009-05-05 04:41:15Date Closed:2009-10-09 18:15:51
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When a diversion header is received by chan_sip it tries to set the channel var PRIREDIRECTREASON in sip_set_redirstr(struct sip_pvt *p, char *reason);
However, the reason "no-answer" is coded as "NOANSWER" but chan_dahdi expects the PRIREDIRECTREASON "no-answer" as "NO_REPLY".
Comments:By: Leif Madsen (lmadsen) 2009-09-18 08:55:56

This is *probably* enough information, but I think I'll go ahead and ask for the sip debug, sip history, and asterisk console output (with debug enabled) in case a developer needs it to move this issue forward. Thanks!
By: Leif Madsen (lmadsen) 2009-09-30 10:13:58

Well, no feedback from the reporter, but like I mentioned, this is *probably* enough information, so I'll just set this to Acknowledged unless a developer needs more information, in which case they can set this back to feedback.
By: Digium Subversion (svnbot) 2009-10-09 18:12:20

Repository: asterisk
Revision: 223404

U   branches/1.6.0/channels/chan_dahdi.c
U   branches/1.6.0/channels/chan_h323.c

------------------------------------------------------------------------
r223404 | jpeeler | 2009-10-09 18:12:19 -0500 (Fri, 09 Oct 2009) | 13 lines

Fix interpretation of PRIREDIRECTIONREASON set by chan_sip.

This commit is the simplest way to solve a problem that has already been solved
in trunk with the "COLP/CONP and Redirecting party information into Asterisk"
commit. In trunk the redirection reason is translated into a generic redirect
reason. I would have had to do the same fix except chan_sip never reads
PRIREDIRECTREASON. So both chan_dahdi and chan_h323 have been modified to
interpret the one different redirect reason of "no-answer" properly and set the
ISDN reason code 2 of "no reply".

(closes issue ASTERISK-14067)
Reported by: steinwej

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223404
By: Digium Subversion (svnbot) 2009-10-09 18:15:11

Repository: asterisk
Revision: 223405

U   branches/1.6.1/channels/chan_dahdi.c
U   branches/1.6.1/channels/chan_h323.c

------------------------------------------------------------------------
r223405 | jpeeler | 2009-10-09 18:15:10 -0500 (Fri, 09 Oct 2009) | 13 lines

Fix interpretation of PRIREDIRECTIONREASON set by chan_sip.

This commit is the simplest way to solve a problem that has already been solved
in trunk with the "COLP/CONP and Redirecting party information into Asterisk"
commit. In trunk the redirection reason is translated into a generic redirect
reason. I would have had to do the same fix except chan_sip never reads
PRIREDIRECTREASON. So both chan_dahdi and chan_h323 have been modified to
interpret the one different redirect reason of "no-answer" properly and set the
ISDN reason code 2 of "no reply".

(closes issue ASTERISK-14067)
Reported by: steinwej

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223405
By: Digium Subversion (svnbot) 2009-10-09 18:15:51

Repository: asterisk
Revision: 223406

U   branches/1.6.2/channels/chan_dahdi.c
U   branches/1.6.2/channels/chan_h323.c

------------------------------------------------------------------------
r223406 | jpeeler | 2009-10-09 18:15:50 -0500 (Fri, 09 Oct 2009) | 13 lines

Fix interpretation of PRIREDIRECTIONREASON set by chan_sip.

This commit is the simplest way to solve a problem that has already been solved
in trunk with the "COLP/CONP and Redirecting party information into Asterisk"
commit. In trunk the redirection reason is translated into a generic redirect
reason. I would have had to do the same fix except chan_sip never reads
PRIREDIRECTREASON. So both chan_dahdi and chan_h323 have been modified to
interpret the one different redirect reason of "no-answer" properly and set the
ISDN reason code 2 of "no reply".

(closes issue ASTERISK-14067)
Reported by: steinwej

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=223406