Summary:ASTERISK-14037: Rewrite Skinny sub handling
Reporter:Damien Wedhorn (wedhorn)Labels:
Date Opened:2009-04-29 15:18:00Date Closed:2011-06-07 14:00:24
Versions:Frequency of
Description:This is a rewrite of the sub (chan->tech_pvt) handling in skinny. This necessitated a rewrite of the locking. Debugging info also redone to assist in testing. Various other small bits and pieces.

Code is available at http://svn.digium.com/svn/asterisk/team/wedhorn/skinny-subs/

Basic functionality (excluding transfer) work for me. Not tested on new phones (79xx).


Changes are:
- sub changes are universally handled by set_sub_state.
- debugging includes various toggles to limit what's displayed.
- most locking removed, only device and chan locks are used (plus some high level locks).
- display methods differ between new and old phones (see set_call_info).
- lots of other clean ups.
Comments:By: Michiel van Baak (mvanbaak) 2009-04-30 06:53:36

I moved my pbx at home to this code.
Testing it a bit more over the weekend. Will report back here.

By: pj (pj) 2009-04-30 06:58:59

I can test this branch too, because I'm using only basic functionality with few 7920 phones, so missing transfer feature is not problem for me.
But currently I'm using Asterisk SVN-trunk-r191136, is this skinny-subs branch synchronized with latest trunk?

By: Damien Wedhorn (wedhorn) 2009-04-30 07:03:21

pj, this branch is on automerge (I think - I'm new to svn) and so should stay current with trunk (except skinny changes as they are unlikely to merge cleanly).

mvanbaak is having a bit of a play and it's already core dumped on 79xx's, so you may want to wait a bit before using this code.

By: Michiel van Baak (mvanbaak) 2009-04-30 13:01:44

wedhorn: the branch is on automerge, and it's working.
Looking at the svn log, the last commit was done by 'root' because of a commit in trunk.
If you set the automerge-email property and put your emailaddress in it you'll get a mail when merging fails.

During the weekend I'll spend some time on this branch to see if we can get the crashes fixed.

By: Michiel van Baak (mvanbaak) 2010-03-07 16:07:18.000-0600

Will reopen when work is being restarted.
Discussed with wedhorn on IRC