[Home]

Summary:ASTERISK-14027: Asyncagi break missing
Reporter:Nicola Turato (nikkk)Labels:
Date Opened:2009-04-28 09:13:08Date Closed:2009-05-04 14:31:34
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_agi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090428__bug14985.diff.txt
( 1) 20090429__bug14985__1.6.1.diff.txt
Description:"asyncagi break" command is missing on Asterisk SVN-branch-1.6.1-r190371
Comments:By: Tilghman Lesher (tilghman) 2009-04-28 10:20:40

What does that command do?
By: Nicola Turato (nikkk) 2009-04-28 10:29:35

It Breaks Async AGI loop (since Asterisk 1.6)  

exten => 1234,1,Agi(agi:async)


It is present on Asterisk SVN-branch-1.6.1-r160234
By: Tilghman Lesher (tilghman) 2009-04-28 12:03:38

Patch uploaded, ready for testing.
By: Nicola Turato (nikkk) 2009-04-29 02:31:28

Patch doesn't work, this is the output:

patching file res/res_agi.c
Hunk #1 succeeded at 774 (offset -260 lines).
Hunk #2 FAILED at 2215.
1 out of 2 hunks FAILED -- saving rejects to file res/res_agi.c.rej


res/res_agi.c.rej :

***************
*** 2209,2214 ****
  */
 static struct agi_command commands[] = {
       { { "answer", NULL }, handle_answer, NULL, NULL, 0 },
       { { "channel", "status", NULL }, handle_channelstatus, NULL, NULL, 0 },
       { { "database", "del", NULL }, handle_dbdel, NULL, NULL, 1 },
       { { "database", "deltree", NULL }, handle_dbdeltree, NULL, NULL, 1 },
--- 2215,2221 ----
  */
 static struct agi_command commands[] = {
       { { "answer", NULL }, handle_answer, NULL, NULL, 0 },
+       { { "asyncagi", "break", NULL }, handle_asyncagi_break, NULL, NULL, 1 },
       { { "channel", "status", NULL }, handle_channelstatus, NULL, NULL, 0 },
       { { "database", "del", NULL }, handle_dbdel, NULL, NULL, 1 },
       { { "database", "deltree", NULL }, handle_dbdeltree, NULL, NULL, 1 },
By: Tilghman Lesher (tilghman) 2009-04-29 09:38:48

Patch updated for 1.6.1.  Original patch is for trunk.
By: Nicola Turato (nikkk) 2009-04-29 11:10:31

Ok for 1.6.1, it works fine. Thanks
By: Digium Subversion (svnbot) 2009-05-04 14:29:13

Repository: asterisk
Revision: 192171

U   trunk/include/asterisk/autoconfig.h.in
U   trunk/res/res_agi.c

------------------------------------------------------------------------
r192171 | tilghman | 2009-05-04 14:29:13 -0500 (Mon, 04 May 2009) | 8 lines

Restore 'asyncagi break' command to 1.6.1 and higher.
(closes issue ASTERISK-14027)
Reported by: nikkk
Patches:
      20090428__bug14985.diff.txt uploaded by tilghman (license 14)
      20090429__bug14985__1.6.1.diff.txt uploaded by tilghman (license 14)
Tested by: nikkk

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=192171
By: Digium Subversion (svnbot) 2009-05-04 14:30:35

Repository: asterisk
Revision: 192172

_U  branches/1.6.1/
U   branches/1.6.1/configure
U   branches/1.6.1/res/res_agi.c

------------------------------------------------------------------------
r192172 | tilghman | 2009-05-04 14:30:34 -0500 (Mon, 04 May 2009) | 15 lines

Recorded merge of revisions 192171 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r192171 | tilghman | 2009-05-04 14:29:13 -0500 (Mon, 04 May 2009) | 8 lines
 
 Restore 'asyncagi break' command to 1.6.1 and higher.
 (closes issue ASTERISK-14027)
  Reported by: nikkk
  Patches:
        20090428__bug14985.diff.txt uploaded by tilghman (license 14)
        20090429__bug14985__1.6.1.diff.txt uploaded by tilghman (license 14)
  Tested by: nikkk
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=192172
By: Digium Subversion (svnbot) 2009-05-04 14:31:34

Repository: asterisk
Revision: 192173

_U  branches/1.6.2/
U   branches/1.6.2/configure
U   branches/1.6.2/res/res_agi.c

------------------------------------------------------------------------
r192173 | tilghman | 2009-05-04 14:31:33 -0500 (Mon, 04 May 2009) | 15 lines

Merged revisions 192171 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r192171 | tilghman | 2009-05-04 14:29:13 -0500 (Mon, 04 May 2009) | 8 lines
 
 Restore 'asyncagi break' command to 1.6.1 and higher.
 (closes issue ASTERISK-14027)
  Reported by: nikkk
  Patches:
        20090428__bug14985.diff.txt uploaded by tilghman (license 14)
        20090429__bug14985__1.6.1.diff.txt uploaded by tilghman (license 14)
  Tested by: nikkk
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=192173