[Home]

Summary:ASTERISK-14025: [patch] include contexts based on time causes asterisk to loop on startup
Reporter:teox (teox)Labels:
Date Opened:2009-04-28 03:55:08Date Closed:2009-05-14 11:23:24
Priority:MinorRegression?No
Status:Closed/CompleteComponents:PBX/pbx_config
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090513__issue14983.diff.txt
( 1) backtrace.txt
Description:asterisk 1.6.2-beta1 is looping if a include-context (time-based) is used.

include => incoming-sip,6:00-0:00,mon-fri,*,*

The example above is running with asterisk 1.6.1 but loops on startup with 1.6.2

Comments:By: Tilghman Lesher (tilghman) 2009-04-28 13:17:39

I need some steps to be able to reproduce this.  I've tried including a context before it's defined and after it's defined.  In neither case have I gotten a loop on startup.
By: teox (teox) 2009-04-28 17:11:43

I think the problem could be multiple time-based-include-contexts (if I use only one it's working):

[inbound-iax]

include => incoming-iax,6:00-0:00,mon-fri,*,*
include => incoming-iax,8:00-0:00,sat-sun,*,*
include => night-sip-iax,0:00-6:00,mon-fri,*,*
include => night-sip-iax,0:00-8:00,sat-sun,*,*

[inbound-sip]

include => incoming-sip,6:00-0:00,mon-fri,*,*
include => incoming-sip,8:00-0:00,sat-sun,*,*
include => night-sip-iax,0:00-6:00,mon-fri,*,*
include => night-sip-iax,0:00-8:00,sat-sun,*,*

[incoming-iax]
...
[incoming-sip]

[night-sip-iax]
...


By: Leif Madsen (lmadsen) 2009-05-13 08:45:50

OK, reproduced on 1.6.2.0-beta1 and uploaded the backtrace here. I attached to the running process after it hung on load.
By: teox (teox) 2009-05-13 13:49:38

patch applied and testing. I'll give you a feedback!
By: teox (teox) 2009-05-13 18:20:48

The patch is ok.
No loops and the time-based-contexts are working as sheduled!
Tx
By: Digium Subversion (svnbot) 2009-05-14 11:22:21

Repository: asterisk
Revision: 194430

U   trunk/main/pbx.c

------------------------------------------------------------------------
r194430 | tilghman | 2009-05-14 11:22:20 -0500 (Thu, 14 May 2009) | 7 lines

If the timing ended on a zero, then we would loop forever.
(closes issue ASTERISK-14025)
Reported by: teox
Patches:
      20090513__issue14983.diff.txt uploaded by tilghman (license 14)
Tested by: teox

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=194430
By: Digium Subversion (svnbot) 2009-05-14 11:23:23

Repository: asterisk
Revision: 194431

_U  branches/1.6.2/
U   branches/1.6.2/main/pbx.c

------------------------------------------------------------------------
r194431 | tilghman | 2009-05-14 11:23:23 -0500 (Thu, 14 May 2009) | 14 lines

Merged revisions 194430 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r194430 | tilghman | 2009-05-14 11:22:14 -0500 (Thu, 14 May 2009) | 7 lines
 
 If the timing ended on a zero, then we would loop forever.
 (closes issue ASTERISK-14025)
  Reported by: teox
  Patches:
        20090513__issue14983.diff.txt uploaded by tilghman (license 14)
  Tested by: teox
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=194431