[Home]

Summary:ASTERISK-14023: [patch] Compilation issue on Solaris due to ast_channel_unref
Reporter:snuffy (snuffy)Labels:
Date Opened:2009-04-27 19:35:35Date Closed:2009-05-01 14:56:36
Priority:MinorRegression?Yes
Status:Closed/CompleteComponents:Core/Channels
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090428_14981.patch
Description:Very similar to issue 0014512
Basically i've made the same patch as russell did for the previous time this occurred with ts_zone in the above issue.
Comments:By: snuffy (snuffy) 2009-04-27 20:14:10

I found another instance of this with rtp_engine, so i figured i'd include the patch to fix it as well.

By: Digium Subversion (svnbot) 2009-04-29 03:51:22

Repository: asterisk
Revision: 190989

U   trunk/include/asterisk/channel.h
U   trunk/main/rtp_engine.c

------------------------------------------------------------------------
r190989 | russell | 2009-04-29 03:51:21 -0500 (Wed, 29 Apr 2009) | 5 lines

Resolve Solaris build issues and add some API documentation.

(issue ASTERISK-14023)
Reported by: snuffy

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190989

By: Digium Subversion (svnbot) 2009-04-29 03:51:46

Repository: asterisk
Revision: 190990

_U  branches/1.6.2/

------------------------------------------------------------------------
r190990 | russell | 2009-04-29 03:51:46 -0500 (Wed, 29 Apr 2009) | 12 lines

Blocked revisions 190989 via svnmerge

........
r190989 | russell | 2009-04-29 03:51:21 -0500 (Wed, 29 Apr 2009) | 5 lines

Resolve Solaris build issues and add some API documentation.

(issue ASTERISK-14023)
Reported by: snuffy

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190990

By: Russell Bryant (russell) 2009-04-29 03:52:03

Let me know if that fixes it for you.

By: snuffy (snuffy) 2009-04-30 20:54:39

This works fine now.
If we are going down this path, can we please standardize ?
aka the 0014512 issue made it static inline functions by you instead of keeping it defined as macro.
Is this possible?

By: Russell Bryant (russell) 2009-05-01 14:56:16

For this, I'd rather leave it as a macro for debugging purposes.  It's one less place in the code we have to change if you want to pass the _real_ location of the unref down into the astobj2 code.