[Home]

Summary:ASTERISK-13999: [patch] Can't delete temporary greeting when using IMAP storage
Reporter:Noah Miller (noahisaac)Labels:
Date Opened:2009-04-22 10:33:28Date Closed:2009-11-03 08:31:50.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail/IMAP
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) vm_tempgreeting_removal_1.6.0.patch
( 1) vm_tempgreeting_removal.patch
Description:When using IMAP storage for voicemail, temporary greetings can't be erased.  

****** STEPS TO REPRODUCE ******

When in VoicemailMain() in the mailbox options section, the voice prompts indicate there is a temporary greeting.  If you press 4 to manage temporary greetings and then 2 to erase it, it will immediately tell you there is still a temporary greeting.

****** ADDITIONAL INFORMATION ******

This issue also exists in recent builds of 1.6.0 and 1.6.1 (possibly in all 1.6.X releases).
Comments:By: Noah Miller (noahisaac) 2009-04-22 11:58:36

It looks like this issue only exists when using IMAP storage without using IMAP greetings. (Actually, it looks like there's another bug to file for IMAP greetings)

Just reviewing the relevant stuff in app_voicemail.c - In vm_tempgreeting(), option 2 references DELETE(), which, when we're using IMAP storage, is defined to use vm_imap_delete().  I think this is the problem because vm_imap_delete() has no facility to delete normal files - it only deletes imap messages.

Would it be OK to call delete_file() directly, instead of using the DELETE() macro?  I'll go ahead and create a patch to do this, but maybe there's a good reason to use the macro?
By: Noah Miller (noahisaac) 2009-04-22 12:24:02

Nevermind on the delete_file() suggestion.  I see that's only for ODBC storage.  Maybe vm_delete() or just a direct call to ast_filedelete()?
By: Noah Miller (noahisaac) 2009-04-22 12:43:16

vm_delete() works in this case, but I guess it wouldn't work if using IMAP greetings or ODBC storage.

I think I'll modify vm_imap_delete() to allow file greeting deletions.  I think I just need to add an argument to reference the file, and then call ast_filedelete().


By: Noah Miller (noahisaac) 2009-04-22 13:04:41

OK, patch created and uploaded for 1.6.2-r189816.  I'll create another patch for 1.6.0, too.
By: Leif Madsen (lmadsen) 2009-06-16 13:57:19

Marking this as Ready for Testing. Thanks!
By: Leif Madsen (lmadsen) 2009-07-24 13:50:07

Assigned to Mark for review. No ETA on when he'll be able to look at this though.

Thanks!
By: Jeff Peeler (jpeeler) 2009-09-29 12:12:03

This was merged to trunk in 220833 and merged to all 1.6.x branches:

Make deletion of temporary greetings work properly with IMAP_STORAGE

When imapgreetings was set to yes, the message was being deleted but wasn't
actually being expunged. When imapgreetings was set to no, the file based
message was not being deleted at all. All good now!

(closes issue ASTERISK-13999)
Reported by: noahisaac
Patches:
     vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
     modified by me
By: Digium Subversion (svnbot) 2009-09-29 13:36:39

Repository: asterisk
Revision: 220833

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r220833 | jpeeler | 2009-09-29 13:36:38 -0500 (Tue, 29 Sep 2009) | 12 lines

Make deletion of temporary greetings work properly with IMAP_STORAGE

When imapgreetings was set to yes, the message was being deleted but wasn't
actually being expunged. When imapgreetings was set to no, the file based
message was not being deleted at all. All good now!

(closes issue ASTERISK-13999)
Reported by: noahisaac
Patches:
     vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
     modified by me

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=220833
By: Digium Subversion (svnbot) 2009-09-29 13:36:42

Repository: asterisk
Revision: 220834

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_voicemail.c

------------------------------------------------------------------------
r220834 | jpeeler | 2009-09-29 13:36:42 -0500 (Tue, 29 Sep 2009) | 19 lines

Merged revisions 220833 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r220833 | jpeeler | 2009-09-29 11:58:29 -0500 (Tue, 29 Sep 2009) | 12 lines
 
 Make deletion of temporary greetings work properly with IMAP_STORAGE
 
 When imapgreetings was set to yes, the message was being deleted but wasn't
 actually being expunged. When imapgreetings was set to no, the file based
 message was not being deleted at all. All good now!
 
 (closes issue ASTERISK-13999)
 Reported by: noahisaac
 Patches:
       vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
       modified by me
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=220834
By: Digium Subversion (svnbot) 2009-09-29 13:36:45

Repository: asterisk
Revision: 220835

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_voicemail.c

------------------------------------------------------------------------
r220835 | jpeeler | 2009-09-29 13:36:45 -0500 (Tue, 29 Sep 2009) | 19 lines

Merged revisions 220833 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r220833 | jpeeler | 2009-09-29 11:58:29 -0500 (Tue, 29 Sep 2009) | 12 lines
 
 Make deletion of temporary greetings work properly with IMAP_STORAGE
 
 When imapgreetings was set to yes, the message was being deleted but wasn't
 actually being expunged. When imapgreetings was set to no, the file based
 message was not being deleted at all. All good now!
 
 (closes issue ASTERISK-13999)
 Reported by: noahisaac
 Patches:
       vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
       modified by me
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=220835
By: Digium Subversion (svnbot) 2009-09-29 13:36:49

Repository: asterisk
Revision: 220836

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r220836 | jpeeler | 2009-09-29 13:36:48 -0500 (Tue, 29 Sep 2009) | 19 lines

Merged revisions 220833 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r220833 | jpeeler | 2009-09-29 11:58:29 -0500 (Tue, 29 Sep 2009) | 12 lines
 
 Make deletion of temporary greetings work properly with IMAP_STORAGE
 
 When imapgreetings was set to yes, the message was being deleted but wasn't
 actually being expunged. When imapgreetings was set to no, the file based
 message was not being deleted at all. All good now!
 
 (closes issue ASTERISK-13999)
 Reported by: noahisaac
 Patches:
       vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
       modified by me
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=220836