[Home]

Summary:ASTERISK-13990: Using '@' to specify a context in AEL will cause parse errors
Reporter:Ben Goldsbury (bpgoldsb)Labels:
Date Opened:2009-04-20 14:01:07Date Closed:2009-04-20 16:36:34
Priority:MinorRegression?No
Status:Closed/CompleteComponents:PBX/pbx_ael
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) bug14941.patch
Description:The following code in the older style of dialplan will create a hint for 701 without errors:

exten => 701,1,ParkedCall(701)
exten => 701,hint,park:701@parkedcalls

The equivalent AEL code below will cause the AEL parser to throw a syntax error:

hint(park:701@parkedcalls) 701 => ParkedCall(701)
Comments:By: Ben Goldsbury (bpgoldsb) 2009-04-20 15:37:33

Tested on a clean source and works great.
By: Digium Subversion (svnbot) 2009-04-20 15:58:40

Repository: asterisk
Revision: 189462

U   branches/1.4/pbx/ael/ael.tab.c
U   branches/1.4/pbx/ael/ael.y

------------------------------------------------------------------------
r189462 | seanbright | 2009-04-20 15:58:40 -0500 (Mon, 20 Apr 2009) | 13 lines

Properly handle @s within hints in AEL.

AEL was not handling the case of a device hint containing an @ symbol, which
caused parking hints (e.g. hint(park:exten@context)) to error out the parser.
This patch makes AEL treat the @ the same way it treats colon and ampersand
now, meaning the characters are included in verbatim.

(closes issue ASTERISK-13990)
Reported by: bpgoldsb
Patches:
     bug14941.patch uploaded by seanbright (license 71)
Tested by: bpgoldsb

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=189462
By: Digium Subversion (svnbot) 2009-04-20 16:09:59

Repository: asterisk
Revision: 189464

_U  trunk/
U   trunk/res/ael/ael.tab.c
U   trunk/res/ael/ael.y

------------------------------------------------------------------------
r189464 | seanbright | 2009-04-20 16:09:59 -0500 (Mon, 20 Apr 2009) | 20 lines

Merged revisions 189462 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r189462 | seanbright | 2009-04-20 16:58:39 -0400 (Mon, 20 Apr 2009) | 13 lines
 
 Properly handle @s within hints in AEL.
 
 AEL was not handling the case of a device hint containing an @ symbol, which
 caused parking hints (e.g. hint(park:exten@context)) to error out the parser.
 This patch makes AEL treat the @ the same way it treats colon and ampersand
 now, meaning the characters are included in verbatim.
 
 (closes issue ASTERISK-13990)
 Reported by: bpgoldsb
 Patches:
       bug14941.patch uploaded by seanbright (license 71)
 Tested by: bpgoldsb
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=189464
By: Digium Subversion (svnbot) 2009-04-20 16:31:36

Repository: asterisk
Revision: 189525

_U  branches/1.6.0/
U   branches/1.6.0/res/ael/ael.tab.c
U   branches/1.6.0/res/ael/ael.y

------------------------------------------------------------------------
r189525 | seanbright | 2009-04-20 16:31:36 -0500 (Mon, 20 Apr 2009) | 27 lines

Merged revisions 189464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r189464 | seanbright | 2009-04-20 17:09:59 -0400 (Mon, 20 Apr 2009) | 20 lines
 
 Merged revisions 189462 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r189462 | seanbright | 2009-04-20 16:58:39 -0400 (Mon, 20 Apr 2009) | 13 lines
   
   Properly handle @s within hints in AEL.
   
   AEL was not handling the case of a device hint containing an @ symbol, which
   caused parking hints (e.g. hint(park:exten@context)) to error out the parser.
   This patch makes AEL treat the @ the same way it treats colon and ampersand
   now, meaning the characters are included in verbatim.
   
   (closes issue ASTERISK-13990)
   Reported by: bpgoldsb
   Patches:
         bug14941.patch uploaded by seanbright (license 71)
   Tested by: bpgoldsb
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=189525
By: Digium Subversion (svnbot) 2009-04-20 16:34:36

Repository: asterisk
Revision: 189531

_U  branches/1.6.1/
U   branches/1.6.1/res/ael/ael.tab.c
U   branches/1.6.1/res/ael/ael.y

------------------------------------------------------------------------
r189531 | seanbright | 2009-04-20 16:34:36 -0500 (Mon, 20 Apr 2009) | 27 lines

Merged revisions 189464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r189464 | seanbright | 2009-04-20 17:09:59 -0400 (Mon, 20 Apr 2009) | 20 lines
 
 Merged revisions 189462 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r189462 | seanbright | 2009-04-20 16:58:39 -0400 (Mon, 20 Apr 2009) | 13 lines
   
   Properly handle @s within hints in AEL.
   
   AEL was not handling the case of a device hint containing an @ symbol, which
   caused parking hints (e.g. hint(park:exten@context)) to error out the parser.
   This patch makes AEL treat the @ the same way it treats colon and ampersand
   now, meaning the characters are included in verbatim.
   
   (closes issue ASTERISK-13990)
   Reported by: bpgoldsb
   Patches:
         bug14941.patch uploaded by seanbright (license 71)
   Tested by: bpgoldsb
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=189531
By: Digium Subversion (svnbot) 2009-04-20 16:36:34

Repository: asterisk
Revision: 189533

_U  branches/1.6.2/
U   branches/1.6.2/res/ael/ael.tab.c
U   branches/1.6.2/res/ael/ael.y

------------------------------------------------------------------------
r189533 | seanbright | 2009-04-20 16:36:33 -0500 (Mon, 20 Apr 2009) | 27 lines

Merged revisions 189464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r189464 | seanbright | 2009-04-20 17:09:59 -0400 (Mon, 20 Apr 2009) | 20 lines
 
 Merged revisions 189462 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r189462 | seanbright | 2009-04-20 16:58:39 -0400 (Mon, 20 Apr 2009) | 13 lines
   
   Properly handle @s within hints in AEL.
   
   AEL was not handling the case of a device hint containing an @ symbol, which
   caused parking hints (e.g. hint(park:exten@context)) to error out the parser.
   This patch makes AEL treat the @ the same way it treats colon and ampersand
   now, meaning the characters are included in verbatim.
   
   (closes issue ASTERISK-13990)
   Reported by: bpgoldsb
   Patches:
         bug14941.patch uploaded by seanbright (license 71)
   Tested by: bpgoldsb
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=189533