[Home]

Summary:ASTERISK-13962: [patch] Incorrectly configure (autoconf) when using the --with-something=directory construct with non standard directories
Reporter:Guillaume Knispel (gknispel_proformatique)Labels:
Date Opened:2009-04-15 09:54:48Date Closed:2011-06-07 14:08:28
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090827__issue14906.diff.txt
Description:Asterisk ./configure is broken when trying something like:

./configure --with-libpri=/non_standard_path/to/libpri

(where /non_standard_path/to/libpri contains an unpacked and built version of libpri-1.4.9.tar.gz)

The problem relates to the macro AST_EXT_LIB_CHECK, which is called 3 times for libpri:

AST_EXT_LIB_CHECK([PRI], [pri], [pri_keypad_facility], [libpri.h])
AST_EXT_LIB_CHECK([PRI_VERSION], [pri], [pri_get_version], [libpri.h])
AST_EXT_LIB_CHECK([PRI_INBANDDISCONNECT], [pri], [pri_set_inbanddisconnect], [libpri.h])

The first one generates somethings that make sense:

if test "${USE_PRI}" != "no"; then
  pbxlibdir=""
  if test "x${PRI_DIR}" != "x"; then
     if test -d ${PRI_DIR}/lib; then
      pbxlibdir="-L${PRI_DIR}/lib"
     else
      pbxlibdir="-L${PRI_DIR}"
     fi
  fi
[...]

But the second yields (and the third one yields something similar):
if test "${USE_PRI_VERSION}" != "no"; then
  pbxlibdir=""
  if test "x${PRI_VERSION_DIR}" != "x"; then
     if test -d ${PRI_VERSION_DIR}/lib; then
      pbxlibdir="-L${PRI_VERSION_DIR}/lib"
     else
      pbxlibdir="-L${PRI_VERSION_DIR}"
     fi
  fi
[...]

Of course PRI_VERSION_DIR does not exist and while HAVE_PRI is correctly defined to 1, HAVE_PRI_VERSION (and HAVE_PRI_INBANDDISCONNECT) are incorrectly undefined.

Similar problems exist for other dependencies (include and/or lib paths incorrect in configure script) -- I've not check if everything relates to AST_EXT_LIB_CHECK and its use or if other macros are involved.
Comments:By: Tilghman Lesher (tilghman) 2009-08-26 17:48:30

Patch uploaded against 1.4, because this will go against all current release branches.
By: Digium Subversion (svnbot) 2009-08-27 11:04:29

Repository: asterisk
Revision: 214357

U   branches/1.4/autoconf/ast_ext_lib.m4
U   branches/1.4/configure
U   branches/1.4/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r214357 | tilghman | 2009-08-27 11:04:29 -0500 (Thu, 27 Aug 2009) | 3 lines

Make autoheader descriptions render correctly in our autoconfig.h file.
(Figured out while working with issue ASTERISK-13962)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=214357
By: Digium Subversion (svnbot) 2009-08-27 11:12:42

Repository: asterisk
Revision: 214360

_U  trunk/
U   trunk/autoconf/ast_ext_lib.m4
U   trunk/configure
U   trunk/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r214360 | tilghman | 2009-08-27 11:12:42 -0500 (Thu, 27 Aug 2009) | 10 lines

Merged revisions 214357 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r214357 | tilghman | 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) | 3 lines
 
 Make autoheader descriptions render correctly in our autoconfig.h file.
 (Figured out while working with issue ASTERISK-13962)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=214360
By: Digium Subversion (svnbot) 2009-08-27 11:15:36

Repository: asterisk
Revision: 214361

_U  branches/1.6.0/
U   branches/1.6.0/autoconf/ast_ext_lib.m4
U   branches/1.6.0/configure
U   branches/1.6.0/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r214361 | tilghman | 2009-08-27 11:15:35 -0500 (Thu, 27 Aug 2009) | 17 lines

Merged revisions 214360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r214360 | tilghman | 2009-08-27 11:12:03 -0500 (Thu, 27 Aug 2009) | 10 lines
 
 Merged revisions 214357 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r214357 | tilghman | 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) | 3 lines
   
   Make autoheader descriptions render correctly in our autoconfig.h file.
   (Figured out while working with issue ASTERISK-13962)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=214361
By: Digium Subversion (svnbot) 2009-08-27 11:17:15

Repository: asterisk
Revision: 214363

_U  branches/1.6.2/
U   branches/1.6.2/autoconf/ast_ext_lib.m4
U   branches/1.6.2/configure
U   branches/1.6.2/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r214363 | tilghman | 2009-08-27 11:17:15 -0500 (Thu, 27 Aug 2009) | 17 lines

Merged revisions 214360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r214360 | tilghman | 2009-08-27 11:12:03 -0500 (Thu, 27 Aug 2009) | 10 lines
 
 Merged revisions 214357 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r214357 | tilghman | 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) | 3 lines
   
   Make autoheader descriptions render correctly in our autoconfig.h file.
   (Figured out while working with issue ASTERISK-13962)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=214363
By: Digium Subversion (svnbot) 2009-08-27 11:18:05

Repository: asterisk
Revision: 214365

_U  branches/1.6.1/
U   branches/1.6.1/autoconf/ast_ext_lib.m4
U   branches/1.6.1/configure
U   branches/1.6.1/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r214365 | tilghman | 2009-08-27 11:18:04 -0500 (Thu, 27 Aug 2009) | 17 lines

Merged revisions 214360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r214360 | tilghman | 2009-08-27 11:12:03 -0500 (Thu, 27 Aug 2009) | 10 lines
 
 Merged revisions 214357 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r214357 | tilghman | 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) | 3 lines
   
   Make autoheader descriptions render correctly in our autoconfig.h file.
   (Figured out while working with issue ASTERISK-13962)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=214365
By: Tilghman Lesher (tilghman) 2009-08-27 16:06:23

Patch uploaded (relative to 1.4) that should fix this on all versions.
By: Leif Madsen (lmadsen) 2009-11-04 10:13:18.000-0600

So I tried running this in the newly checked out 1.4 directory:

./configure --with-libpri=~/Development/libpri-1.4-vanilla/

(where I had built libpri 1.4 branch)

I'm not getting any errors... should I be? What am I looking for?
By: Leif Madsen (lmadsen) 2009-11-04 10:58:26.000-0600

Unassigned myself as I played around with this for about 30 minutes, and still have no idea what I'm really looking for, and how to determine if I'm reproducing, and if the patch fixes this.

If someone comes along and can explain this, then I can try picking it up, but for now, I have no idea what I'm looking for.