[Home]

Summary:ASTERISK-13961: [patch] Log message storms prevention.
Reporter:Andriy I Pylypenko (bamby)Labels:
Date Opened:2009-04-15 08:44:14Date Closed:2011-06-07 14:03:02
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) suppress_log_dups.diff
Description:Hi,

Asterisk allows the duplicate log messages to be written to the log without limits. This can lead to quite unpleasant problems with the disk space, like for example it happened recently with the issue 0014723.

The BSD syslogd uses a quite useful technique against such storms - when log message is a duplicate of the previous, then this message is not written to the log, but is silently counted instead. And when a new message comes that differs from the previous one, then the message 'last message repeated N times' is written to the log, following by the new message.

I've implemented this technique for the asterisk. Please see the attached patch.
Comments:By: Sean Bright (seanbright) 2009-05-30 15:26:47

bamby,

Sorry it has taken so long to comment on this patch.  I definitely like the idea.  Would it be possible for you to build a patch against the trunk version of asterisk?

Let me know.  Thanks.

By: Leif Madsen (lmadsen) 2009-07-13 10:32:49

Pinging issue again to see if we can get this updated to trunk. Thanks!

By: Leif Madsen (lmadsen) 2009-07-27 14:52:08

Issue closed for now. If the reporter can reopen and attach the patch, updated for trunk, then that'd be great. Thanks!