[Home]

Summary:ASTERISK-13942: [patch] smsq uses '|' rather than ',' for options in call file
Reporter:Stephen Lewis (stegro)Labels:
Date Opened:2009-04-12 17:25:57Date Closed:2009-04-14 00:29:48
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_sms
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) smsq.patch
Description:The version of utils/smsq shipped with all 1.6 versions still uses the '|' option separator, rather than ','.

For example, the shipped smsq.c will generate a .call file containing:

 Data: 0|s

rather than

 Data: 0,s

The execution of the SMS app therefore expects the queue to be called '0|s', rather than queue '0' with option 's' (act as service centre talking to a phone).

****** ADDITIONAL INFORMATION ******

I'll attach the simple patch.
Comments:By: Stephen Lewis (stegro) 2009-04-12 17:34:21

A clarification: this is only a problem when smsq is being used to enqueue an MT (mobile terminated) message, i.e. when passing it the '-t' flag.

(I'm fairly sure this isn't a dupe of 0012779: that seems to relate to MO messages, enqueued without the '-t' flag.)
By: Digium Subversion (svnbot) 2009-04-14 00:27:53

Repository: asterisk
Revision: 188206

U   trunk/utils/smsq.c

------------------------------------------------------------------------
r188206 | tilghman | 2009-04-14 00:27:53 -0500 (Tue, 14 Apr 2009) | 6 lines

Application delimiter is ',', not '|'.
(closes issue ASTERISK-13942)
Reported by: stegro
Patches:
      smsq.patch uploaded by stegro (license 752)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=188206
By: Digium Subversion (svnbot) 2009-04-14 00:28:34

Repository: asterisk
Revision: 188207

_U  branches/1.6.0/
U   branches/1.6.0/utils/smsq.c

------------------------------------------------------------------------
r188207 | tilghman | 2009-04-14 00:28:33 -0500 (Tue, 14 Apr 2009) | 13 lines

Merged revisions 188206 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r188206 | tilghman | 2009-04-14 00:27:53 -0500 (Tue, 14 Apr 2009) | 6 lines
 
 Application delimiter is ',', not '|'.
 (closes issue ASTERISK-13942)
  Reported by: stegro
  Patches:
        smsq.patch uploaded by stegro (license 752)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=188207
By: Digium Subversion (svnbot) 2009-04-14 00:29:12

Repository: asterisk
Revision: 188208

_U  branches/1.6.1/
U   branches/1.6.1/utils/smsq.c

------------------------------------------------------------------------
r188208 | tilghman | 2009-04-14 00:29:11 -0500 (Tue, 14 Apr 2009) | 13 lines

Merged revisions 188206 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r188206 | tilghman | 2009-04-14 00:27:53 -0500 (Tue, 14 Apr 2009) | 6 lines
 
 Application delimiter is ',', not '|'.
 (closes issue ASTERISK-13942)
  Reported by: stegro
  Patches:
        smsq.patch uploaded by stegro (license 752)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=188208
By: Digium Subversion (svnbot) 2009-04-14 00:29:47

Repository: asterisk
Revision: 188209

_U  branches/1.6.2/
U   branches/1.6.2/utils/smsq.c

------------------------------------------------------------------------
r188209 | tilghman | 2009-04-14 00:29:47 -0500 (Tue, 14 Apr 2009) | 13 lines

Merged revisions 188206 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r188206 | tilghman | 2009-04-14 00:27:53 -0500 (Tue, 14 Apr 2009) | 6 lines
 
 Application delimiter is ',', not '|'.
 (closes issue ASTERISK-13942)
  Reported by: stegro
  Patches:
        smsq.patch uploaded by stegro (license 752)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=188209