| Summary: | ASTERISK-13937: [patch] Missing \r\n in response to JabberSend manager action | ||
| Reporter: | Stefan Reuter (srt) | Labels: | |
| Date Opened: | 2009-04-10 18:03:29 | Date Closed: | 2009-05-30 14:41:31 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Resources/res_jabber |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 05302009_1.4_res_jabber.c.diff ( 1) asterisk_14876.patch ( 2) trunk-14876-2.diff | |
| Description: | The response to a JabberSend action is not properly terminated by "\r\n". | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-04-21 21:53:41 phsultan: I've assigned this to you since you can probably resolve this fairly quickly, especially since a patch has been attached. Let me know if you need me to reassign this. Thanks! By: phsultan (phsultan) 2009-04-22 02:58:53 Yep Leif, I'll handle this one. srt: we need to append an ending sequence too when sending back a manager "Success" response, can you confirm? In that case, the patch would be modified as attached. By: Digium Subversion (svnbot) 2009-05-30 14:36:21 Repository: asterisk Revision: 198370 U branches/1.4/res/res_jabber.c ------------------------------------------------------------------------ r198370 | seanbright | 2009-05-30 14:36:20 -0500 (Sat, 30 May 2009) | 12 lines Properly terminate AMI JabberSend response messages. The response message (either Error or Success) needs an extra trailing \r\n after the fields to inform the client that the message is complete. (closes issue ASTERISK-13937) Reported by: srt Patches: 05302009_1.4_res_jabber.c.diff uploaded by seanbright (license 71) asterisk_14876.patch uploaded by srt (license 378) trunk-14876-2.diff uploaded by phsultan (license 73) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198370 By: Digium Subversion (svnbot) 2009-05-30 14:38:59 Repository: asterisk Revision: 198371 _U trunk/ U trunk/res/res_jabber.c ------------------------------------------------------------------------ r198371 | seanbright | 2009-05-30 14:38:58 -0500 (Sat, 30 May 2009) | 19 lines Merged revisions 198370 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r198370 | seanbright | 2009-05-30 15:36:20 -0400 (Sat, 30 May 2009) | 12 lines Properly terminate AMI JabberSend response messages. The response message (either Error or Success) needs an extra trailing \r\n after the fields to inform the client that the message is complete. (closes issue ASTERISK-13937) Reported by: srt Patches: 05302009_1.4_res_jabber.c.diff uploaded by seanbright (license 71) asterisk_14876.patch uploaded by srt (license 378) trunk-14876-2.diff uploaded by phsultan (license 73) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198371 By: Digium Subversion (svnbot) 2009-05-30 14:40:17 Repository: asterisk Revision: 198372 _U branches/1.6.0/ U branches/1.6.0/res/res_jabber.c ------------------------------------------------------------------------ r198372 | seanbright | 2009-05-30 14:40:17 -0500 (Sat, 30 May 2009) | 26 lines Merged revisions 198371 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r198371 | seanbright | 2009-05-30 15:38:58 -0400 (Sat, 30 May 2009) | 19 lines Merged revisions 198370 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r198370 | seanbright | 2009-05-30 15:36:20 -0400 (Sat, 30 May 2009) | 12 lines Properly terminate AMI JabberSend response messages. The response message (either Error or Success) needs an extra trailing \r\n after the fields to inform the client that the message is complete. (closes issue ASTERISK-13937) Reported by: srt Patches: 05302009_1.4_res_jabber.c.diff uploaded by seanbright (license 71) asterisk_14876.patch uploaded by srt (license 378) trunk-14876-2.diff uploaded by phsultan (license 73) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198372 By: Digium Subversion (svnbot) 2009-05-30 14:40:59 Repository: asterisk Revision: 198373 _U branches/1.6.1/ U branches/1.6.1/res/res_jabber.c ------------------------------------------------------------------------ r198373 | seanbright | 2009-05-30 14:40:59 -0500 (Sat, 30 May 2009) | 26 lines Merged revisions 198371 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r198371 | seanbright | 2009-05-30 15:38:58 -0400 (Sat, 30 May 2009) | 19 lines Merged revisions 198370 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r198370 | seanbright | 2009-05-30 15:36:20 -0400 (Sat, 30 May 2009) | 12 lines Properly terminate AMI JabberSend response messages. The response message (either Error or Success) needs an extra trailing \r\n after the fields to inform the client that the message is complete. (closes issue ASTERISK-13937) Reported by: srt Patches: 05302009_1.4_res_jabber.c.diff uploaded by seanbright (license 71) asterisk_14876.patch uploaded by srt (license 378) trunk-14876-2.diff uploaded by phsultan (license 73) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198373 By: Digium Subversion (svnbot) 2009-05-30 14:41:31 Repository: asterisk Revision: 198374 _U branches/1.6.2/ U branches/1.6.2/res/res_jabber.c ------------------------------------------------------------------------ r198374 | seanbright | 2009-05-30 14:41:30 -0500 (Sat, 30 May 2009) | 26 lines Merged revisions 198371 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r198371 | seanbright | 2009-05-30 15:38:58 -0400 (Sat, 30 May 2009) | 19 lines Merged revisions 198370 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r198370 | seanbright | 2009-05-30 15:36:20 -0400 (Sat, 30 May 2009) | 12 lines Properly terminate AMI JabberSend response messages. The response message (either Error or Success) needs an extra trailing \r\n after the fields to inform the client that the message is complete. (closes issue ASTERISK-13937) Reported by: srt Patches: 05302009_1.4_res_jabber.c.diff uploaded by seanbright (license 71) asterisk_14876.patch uploaded by srt (license 378) trunk-14876-2.diff uploaded by phsultan (license 73) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=198374 | ||