[Home]

Summary:ASTERISK-13926: [patch] Park does not say digits back to caller
Reporter:Noah Miller (noahisaac)Labels:
Date Opened:2009-04-08 14:19:11Date Closed:2009-04-27 18:25:07
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Features/Parking
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) park.patch
( 1) tryme.patch
Description:Hi -

When parking with the latest SVN of the 1.6.0 branch (and the version from at least the past few days), the number of the parking space is not played back to the parker.

I note that on line 593, before say-digits is called that there's a check to see if the digits should be played back.  One of the conditions is supposed to check to see if the original channel name is not zero length.  Currently, it looks like this:

if (peer && (ast_strlen_zero(orig_chan_name) || ...

I'm fairly certain it should be this instead:

if (peer && (!ast_strlen_zero(orig_chan_name) || ...


I'll post a patch to do this in a minute.


Thanks!
Noah


****** STEPS TO REPRODUCE ******

New install of 1.6.0-SVN
Comments:By: Noah Miller (noahisaac) 2009-04-08 14:27:20

Not sure why but Mantis made me sign an agreement again?
By: Noah Miller (noahisaac) 2009-04-08 14:38:07

Looks like this issue is extant in 1.6.2b1, so presumably it's in all versions of 1.6.1, too.
By: Mat Murdock (mmurdock) 2009-04-20 14:56:08

I can replicate this in 1.6.0.9 as well.  Applying noahisaac's patch fixes it for me.  Hope to see this incorporated in 1.6.0.10.

Thanks,

Mat
By: Jeff Peeler (jpeeler) 2009-04-24 14:51:01

I think the patch I just posted is a safer change. The logic to determine whether or not to say the digits has not changed in a while. This also makes 1.6.0 function more like 1.4 does. The later 1.6 releases work differently. Try the patch and see if it works as expected for all your parking scenarios.
By: Noah Miller (noahisaac) 2009-04-24 15:26:52

Thanks, jpeeler!  I'll try the new patch this weekend.
By: Jeff Peeler (jpeeler) 2009-04-27 12:21:39

Success?
By: Mat Murdock (mmurdock) 2009-04-27 12:37:46

Here is my results running 1.6.0.9 with jpeeler's patch.  Here is some relevant features.conf settings:

parkext => 700
blindxfer => *3
atxfer => *2
parkcall => *4

When I do *2700 I am notified which parking lot the call is transferred to.
When I do *3700 I am NOT notified which parking lot the call is transferred to.
When I do *4 I am notified which parking lot the call is transferred to.


By: Digium Subversion (svnbot) 2009-04-27 18:25:06

Repository: asterisk
Revision: 190829

U   branches/1.6.0/main/features.c

------------------------------------------------------------------------
r190829 | jpeeler | 2009-04-27 18:25:06 -0500 (Mon, 27 Apr 2009) | 8 lines

Fix announcement of parking space after transfer to park.

Don't set the orig_chan_name in masq_park_call when the announcement is to be
played. This change was copied from all the other working 1.6 branches.

(closes issue ASTERISK-13926)
Reported by: noahisaac

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190829