[Home]

Summary:ASTERISK-13917: [patch] prevent a segfault when use of RetryDial is incorrect
Reporter:Clod Patry (junky)Labels:
Date Opened:2009-04-07 23:42:46Date Closed:2009-04-08 14:18:58
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Applications/app_dial
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) retry_fix.diff
Description:If you put something:
exten => 144,1,RetryDial(Local/142@default);
in ur dialplan.
(it missings few arguments before the dialargs.


(gdb) bt
#0  0x00007f2d5d9be0b0 in strchr () from /lib/libc.so.6
#1  0x00007f2d5616f5f5 in retrydial_exec (chan=0x1abce80, data=0x414edd40) at app_dial.c:1875
#2  0x000000000048534c in pbx_exec (c=0x1abce80, app=0x1a55170, data=0x414edd40) at pbx.c:537
#3  0x0000000000488b32 in pbx_extension_helper (c=0x1abce80, con=0x0, context=0x1abd0d0 "default", exten=0x1abd120 "144", priority=1, label=0x0, callerid=0x1ab8590 "", action=E_SPAWN) at pbx.c:1863
#4  0x0000000000489dd9 in ast_spawn_extension (c=0x1abce80, context=0x1abd0d0 "default", exten=0x1abd120 "144", priority=1, callerid=0x1ab8590 "") at pbx.c:2320


****** ADDITIONAL INFORMATION ******

Thanks to the group LOG610 at École de Technologie Supérieure, which reports me this crash.
Comments:By: Digium Subversion (svnbot) 2009-04-08 14:16:50

Repository: asterisk
Revision: 187135

U   branches/1.4/apps/app_dial.c

------------------------------------------------------------------------
r187135 | mmichelson | 2009-04-08 14:16:49 -0500 (Wed, 08 Apr 2009) | 8 lines

Fix a crash due to too few arguments to RetryDial.

(closes issue ASTERISK-13917)
Reported by: junky
Patches:
     retry_fix.diff uploaded by junky (license 177)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187135
By: Digium Subversion (svnbot) 2009-04-08 14:18:10

Repository: asterisk
Revision: 187138

_U  trunk/

------------------------------------------------------------------------
r187138 | mmichelson | 2009-04-08 14:18:10 -0500 (Wed, 08 Apr 2009) | 13 lines

Blocked revisions 187135 via svnmerge

........
 r187135 | mmichelson | 2009-04-08 14:16:49 -0500 (Wed, 08 Apr 2009) | 8 lines
 
 Fix a crash due to too few arguments to RetryDial.
 
 (closes issue ASTERISK-13917)
 Reported by: junky
 Patches:
       retry_fix.diff uploaded by junky (license 177)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187138
By: Digium Subversion (svnbot) 2009-04-08 14:18:35

Repository: asterisk
Revision: 187141

_U  branches/1.6.0/

------------------------------------------------------------------------
r187141 | mmichelson | 2009-04-08 14:18:35 -0500 (Wed, 08 Apr 2009) | 19 lines

Blocked revisions 187138 via svnmerge

................
 r187138 | mmichelson | 2009-04-08 14:18:10 -0500 (Wed, 08 Apr 2009) | 13 lines
 
 Blocked revisions 187135 via svnmerge
 
 ........
   r187135 | mmichelson | 2009-04-08 14:16:49 -0500 (Wed, 08 Apr 2009) | 8 lines
   
   Fix a crash due to too few arguments to RetryDial.
   
   (closes issue ASTERISK-13917)
   Reported by: junky
   Patches:
         retry_fix.diff uploaded by junky (license 177)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187141
By: Digium Subversion (svnbot) 2009-04-08 14:18:47

Repository: asterisk
Revision: 187143

_U  branches/1.6.1/

------------------------------------------------------------------------
r187143 | mmichelson | 2009-04-08 14:18:46 -0500 (Wed, 08 Apr 2009) | 19 lines

Blocked revisions 187138 via svnmerge

................
 r187138 | mmichelson | 2009-04-08 14:18:10 -0500 (Wed, 08 Apr 2009) | 13 lines
 
 Blocked revisions 187135 via svnmerge
 
 ........
   r187135 | mmichelson | 2009-04-08 14:16:49 -0500 (Wed, 08 Apr 2009) | 8 lines
   
   Fix a crash due to too few arguments to RetryDial.
   
   (closes issue ASTERISK-13917)
   Reported by: junky
   Patches:
         retry_fix.diff uploaded by junky (license 177)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187143
By: Digium Subversion (svnbot) 2009-04-08 14:18:58

Repository: asterisk
Revision: 187145

_U  branches/1.6.2/

------------------------------------------------------------------------
r187145 | mmichelson | 2009-04-08 14:18:58 -0500 (Wed, 08 Apr 2009) | 19 lines

Blocked revisions 187138 via svnmerge

................
 r187138 | mmichelson | 2009-04-08 14:18:10 -0500 (Wed, 08 Apr 2009) | 13 lines
 
 Blocked revisions 187135 via svnmerge
 
 ........
   r187135 | mmichelson | 2009-04-08 14:16:49 -0500 (Wed, 08 Apr 2009) | 8 lines
   
   Fix a crash due to too few arguments to RetryDial.
   
   (closes issue ASTERISK-13917)
   Reported by: junky
   Patches:
         retry_fix.diff uploaded by junky (license 177)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=187145