[Home]

Summary:ASTERISK-13866: chan_h323 build fails with gcc 3
Reporter:Stuart Henderson (stuarth)Labels:
Date Opened:2009-03-30 20:38:29Date Closed:2009-04-22 16:18:42
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/Portability
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:g++ from gcc 3.3.5 (and probably others) doesn't allow a structure member to have the same name as an included header, in this case "list" in channel.h:1745. same problem as ticket 6446, this time with "AST_LIST_ENTRY(ast_group_info) list" in struct ast_group_info.

****** ADDITIONAL INFORMATION ******

$ cc -v
Reading specs from /usr/lib/gcc-lib/amd64-unknown-openbsd4.5/3.3.5/specs
Configured with:
Thread model: single
gcc version 3.3.5 (propolice)

$ make
[...trim...]
c++ -DNDEBUG -I../../include -include ../../include/asterisk/autoconfig.h -fPIC -DP_USE_PRAGMA -D_REENTRANT -fno-exceptions -I/usr/X11R6/include -I/usr/local/include -Wall  -fPIC -DNDEBUG -I/usr/local/share/pwlib//include -DPASN_NOPRINTON -DPASN_LEANANDMEAN -I/usr/local/include/openh323  -pipe -felide-constructors -Wreorder -I/usr/X11R6/include -I/usr/local/include -c ast_h323.cxx -o ast_h323.o
In file included from ast_h323.cxx:79:
../../include/asterisk/channel.h:1745: error: semicolon missing after struct
  declaration
../../include/asterisk/channel.h:1745: error: abstract declarator `
  ast_group_info::<anonymous struct>' used as declaration
../../include/asterisk/channel.h:1745: error: namespace-scope anonymous
  aggregates must be static
Comments:By: Leif Madsen (lmadsen) 2009-04-01 19:08:36

I've assigned this to jpeeler for now, but he can reassign should be feel that someone else could better handle the issue.

By: Digium Subversion (svnbot) 2009-04-22 16:15:56

Repository: asterisk
Revision: 190057

U   trunk/funcs/func_groupcount.c
U   trunk/include/asterisk/channel.h
U   trunk/main/app.c
U   trunk/main/cli.c

------------------------------------------------------------------------
r190057 | jpeeler | 2009-04-22 16:15:55 -0500 (Wed, 22 Apr 2009) | 9 lines

Fix building of chan_h323 with gcc-3.3

There seems to be a bug with old versions of g++ that doesn't allow a structure
member to use the name list. Rename list member to group_list in ast_group_info
and change the few places it is used.

(closes issue ASTERISK-13866)
Reported by: stuarth

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190057

By: Digium Subversion (svnbot) 2009-04-22 16:17:29

Repository: asterisk
Revision: 190059

_U  branches/1.6.0/
U   branches/1.6.0/funcs/func_groupcount.c
U   branches/1.6.0/include/asterisk/channel.h
U   branches/1.6.0/main/app.c
U   branches/1.6.0/main/cli.c

------------------------------------------------------------------------
r190059 | jpeeler | 2009-04-22 16:17:29 -0500 (Wed, 22 Apr 2009) | 16 lines

Merged revisions 190057 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r190057 | jpeeler | 2009-04-22 16:15:55 -0500 (Wed, 22 Apr 2009) | 9 lines
 
 Fix building of chan_h323 with gcc-3.3
 
 There seems to be a bug with old versions of g++ that doesn't allow a structure
 member to use the name list. Rename list member to group_list in ast_group_info
 and change the few places it is used.
 
 (closes issue ASTERISK-13866)
 Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190059

By: Digium Subversion (svnbot) 2009-04-22 16:18:11

Repository: asterisk
Revision: 190063

_U  branches/1.6.1/
U   branches/1.6.1/funcs/func_groupcount.c
U   branches/1.6.1/include/asterisk/channel.h
U   branches/1.6.1/main/app.c
U   branches/1.6.1/main/cli.c

------------------------------------------------------------------------
r190063 | jpeeler | 2009-04-22 16:18:11 -0500 (Wed, 22 Apr 2009) | 16 lines

Merged revisions 190057 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r190057 | jpeeler | 2009-04-22 16:15:55 -0500 (Wed, 22 Apr 2009) | 9 lines
 
 Fix building of chan_h323 with gcc-3.3
 
 There seems to be a bug with old versions of g++ that doesn't allow a structure
 member to use the name list. Rename list member to group_list in ast_group_info
 and change the few places it is used.
 
 (closes issue ASTERISK-13866)
 Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190063

By: Digium Subversion (svnbot) 2009-04-22 16:18:41

Repository: asterisk
Revision: 190066

_U  branches/1.6.2/
U   branches/1.6.2/funcs/func_groupcount.c
U   branches/1.6.2/include/asterisk/channel.h
U   branches/1.6.2/main/app.c
U   branches/1.6.2/main/cli.c

------------------------------------------------------------------------
r190066 | jpeeler | 2009-04-22 16:18:41 -0500 (Wed, 22 Apr 2009) | 16 lines

Merged revisions 190057 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r190057 | jpeeler | 2009-04-22 16:15:55 -0500 (Wed, 22 Apr 2009) | 9 lines
 
 Fix building of chan_h323 with gcc-3.3
 
 There seems to be a bug with old versions of g++ that doesn't allow a structure
 member to use the name list. Rename list member to group_list in ast_group_info
 and change the few places it is used.
 
 (closes issue ASTERISK-13866)
 Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=190066