Summary:	ASTERISK-13840: [patch] On Dial with Macro, re-INVITE to the caller happens upon callee answer, and not when Macro
Reporter:	Alex Massover (cupotka)	Labels:
Date Opened:	2009-03-26 11:00:42	Date Closed:	2009-10-19 14:58:21
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	This is issue has been reported already in bug # 13200. In any Dial with Macro, there's a re-invite to the caller upon callee answer, although there's a Macro with Playback to the callee. For example if Dial with Macro has also Music-on-Hold flag, MOH is stopped when callee answers (re-invite to caller happens), despite what happens in Macro (for example a long Playback to callee). This also cause many problems with different termination equipment. I can't provide my real dialplan - it's really long and complex. But if needed I can create a more simple one to demonstrate this issue. But I belive this happens in every Dial with Macro in case canreinvite set to yes. It's always reproducible for me on both 1.4.21.2 and 1.4.24.
Comments:	By: Tilghman Lesher (tilghman) 2009-07-17 12:26:41 Have you tried the patch in issue ASTERISK-12488 ?  Did it solve the problem? By: Alex Massover (cupotka) 2009-07-28 03:21:47 We are going to try it. Against what version to try this patch? By: Leif Madsen (lmadsen) 2009-07-29 14:56:36 I have updated the patch from 13200. It is attached to this issue. It will apply to latest 1.4 Asterisk branch. Just waiting for mmichelson to verify that it is ok. Then you can test. By: Leif Madsen (lmadsen) 2009-07-29 15:01:27 Patch won't compile, so I'm removing it. Will try again! By: Leif Madsen (lmadsen) 2009-07-29 15:05:00 After talking to mmichelson on IRC, it seems the patch much as been made against trunk, or some version of 1.6. You could try testing it against trunk, but if you can't, we'll have to figure out a better way of handling this. By: Leif Madsen (lmadsen) 2009-07-29 15:05:44 Unassigning this from me. If someone adds a patch back in here, feel free to reassign back to me so I can test it (or so the reporter can test it). By: Leif Madsen (lmadsen) 2009-09-08 09:38:48 Assigned to Tilghman to review the issue as I have this as a possible blocker for 1.4.27. Thanks! By: Digium Subversion (svnbot) 2009-10-19 14:52:04 Repository: asterisk Revision: 224565 U   branches/1.4/apps/app_dial.c ------------------------------------------------------------------------ r224565 | file | 2009-10-19 14:52:03 -0500 (Mon, 19 Oct 2009) | 5 lines Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it. (closes issue ASTERISK-13840) Reported by: cupotka ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=224565 By: Digium Subversion (svnbot) 2009-10-19 14:53:23 Repository: asterisk Revision: 224567 _U  trunk/ U   trunk/apps/app_dial.c ------------------------------------------------------------------------ r224567 | file | 2009-10-19 14:53:22 -0500 (Mon, 19 Oct 2009) | 12 lines Merged revisions 224565 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r224565 | file | 2009-10-19 16:47:50 -0300 (Mon, 19 Oct 2009) | 5 lines    Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it.    (closes issue ASTERISK-13840)  Reported by: cupotka ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=224567 By: Digium Subversion (svnbot) 2009-10-19 14:54:27 Repository: asterisk Revision: 224568 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_dial.c ------------------------------------------------------------------------ r224568 | file | 2009-10-19 14:54:26 -0500 (Mon, 19 Oct 2009) | 19 lines Merged revisions 224567 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r224567 | file | 2009-10-19 16:49:09 -0300 (Mon, 19 Oct 2009) | 12 lines    Merged revisions 224565 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r224565 | file | 2009-10-19 16:47:50 -0300 (Mon, 19 Oct 2009) | 5 lines        Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it.        (closes issue ASTERISK-13840)    Reported by: cupotka  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=224568 By: Digium Subversion (svnbot) 2009-10-19 14:55:27 Repository: asterisk Revision: 224570 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_dial.c ------------------------------------------------------------------------ r224570 | file | 2009-10-19 14:55:26 -0500 (Mon, 19 Oct 2009) | 19 lines Merged revisions 224567 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r224567 | file | 2009-10-19 16:49:09 -0300 (Mon, 19 Oct 2009) | 12 lines    Merged revisions 224565 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r224565 | file | 2009-10-19 16:47:50 -0300 (Mon, 19 Oct 2009) | 5 lines        Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it.        (closes issue ASTERISK-13840)    Reported by: cupotka  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=224570 By: Digium Subversion (svnbot) 2009-10-19 14:58:19 Repository: asterisk Revision: 224571 _U  branches/1.6.2/ U   branches/1.6.2/apps/app_dial.c ------------------------------------------------------------------------ r224571 | file | 2009-10-19 14:58:19 -0500 (Mon, 19 Oct 2009) | 19 lines Merged revisions 224567 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r224567 | file | 2009-10-19 16:49:09 -0300 (Mon, 19 Oct 2009) | 12 lines    Merged revisions 224565 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r224565 | file | 2009-10-19 16:47:50 -0300 (Mon, 19 Oct 2009) | 5 lines        Do not attempt early media bridging (ie: direct RTP setup) if options are enabled that should prevent it.        (closes issue ASTERISK-13840)    Reported by: cupotka  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=224571