| Summary: | ASTERISK-13831: [patch] Realtime bad Reconstruct of field 'fullcontact' after restart | ||
| Reporter: | Alexei Gradinari (alexei gradinari) | Labels: | |
| Date Opened: | 2009-03-25 15:14:38 | Date Closed: | 2009-06-08 11:14:09 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Registration |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20090504__bug14754.diff.txt ( 1) 20090506__bug14754.diff.txt | |
| Description: | If both sippeers & sipregs set in the extconfig.conf to the same table after restart asterisk there is a bad field 'fullcontact'. This filed contains duplicate value delimited with ';' For example ; extconfig.conf ; Realtime configuration engine ; sipusers => odbc,asterisk,sipbuddies sippeers => odbc,asterisk,sipbuddies sipregs => odbc,asterisk,sipbuddies The field 'fullcontact' in the database contains sip:TEST707@192.168.0.43 after restart asterisk and before this peer registers again if load peer from database asterisk -r -x 'sip show peer TEST707 load' result is Reg. Contact : sip:TEST707@192.168.0.43;sip:TEST707@192.168.0.43 If disable sipregs the result is correct Reg. Contact : sip:TEST707@192.168.0.43 | ||
| Comments: | By: Leif Madsen (lmadsen) 2009-05-04 09:13:19 This issue is marked as to be released in 1.6.0.10, but it is not currently a blocker. By: Leif Madsen (lmadsen) 2009-05-06 10:21:44 I have reproduced and will now test the patch! By: Leif Madsen (lmadsen) 2009-05-06 10:26:15 [CC] chan_sip.c -> chan_sip.o chan_sip.c: In function ‘build_peer’: chan_sip.c:20767: error: initializer element is not constant make[1]: *** [chan_sip.o] Error 1 Does not compile. By: Leif Madsen (lmadsen) 2009-05-07 08:09:19 Appears to be working now! By: Digium Subversion (svnbot) 2009-05-07 11:29:09 Repository: asterisk Revision: 192932 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r192932 | tilghman | 2009-05-07 11:29:09 -0500 (Thu, 07 May 2009) | 10 lines Eliminate repetition of fullcontact during reconstruction. If the fullcontact field appears in both the sippeers and the sipregs table, then during reconstruction of the field, it will otherwise be doubled. (closes issue ASTERISK-13831) Reported by: Alexei Gradinari Patches: 20090506__bug14754.diff.txt uploaded by tilghman (license 14) Tested by: lmadsen ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192932 By: Digium Subversion (svnbot) 2009-05-07 11:43:57 Repository: asterisk Revision: 192933 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r192933 | tilghman | 2009-05-07 11:43:57 -0500 (Thu, 07 May 2009) | 17 lines Merged revisions 192932 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192932 | tilghman | 2009-05-07 11:29:08 -0500 (Thu, 07 May 2009) | 10 lines Eliminate repetition of fullcontact during reconstruction. If the fullcontact field appears in both the sippeers and the sipregs table, then during reconstruction of the field, it will otherwise be doubled. (closes issue ASTERISK-13831) Reported by: Alexei Gradinari Patches: 20090506__bug14754.diff.txt uploaded by tilghman (license 14) Tested by: lmadsen ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192933 By: Digium Subversion (svnbot) 2009-05-07 11:45:24 Repository: asterisk Revision: 192934 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r192934 | tilghman | 2009-05-07 11:45:23 -0500 (Thu, 07 May 2009) | 24 lines Merged revisions 192933 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192933 | tilghman | 2009-05-07 11:43:56 -0500 (Thu, 07 May 2009) | 17 lines Merged revisions 192932 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192932 | tilghman | 2009-05-07 11:29:08 -0500 (Thu, 07 May 2009) | 10 lines Eliminate repetition of fullcontact during reconstruction. If the fullcontact field appears in both the sippeers and the sipregs table, then during reconstruction of the field, it will otherwise be doubled. (closes issue ASTERISK-13831) Reported by: Alexei Gradinari Patches: 20090506__bug14754.diff.txt uploaded by tilghman (license 14) Tested by: lmadsen ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192934 By: Digium Subversion (svnbot) 2009-05-07 11:45:32 Repository: asterisk Revision: 192935 _U branches/1.6.1/ U branches/1.6.1/channels/chan_sip.c ------------------------------------------------------------------------ r192935 | tilghman | 2009-05-07 11:45:32 -0500 (Thu, 07 May 2009) | 24 lines Merged revisions 192933 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192933 | tilghman | 2009-05-07 11:43:56 -0500 (Thu, 07 May 2009) | 17 lines Merged revisions 192932 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192932 | tilghman | 2009-05-07 11:29:08 -0500 (Thu, 07 May 2009) | 10 lines Eliminate repetition of fullcontact during reconstruction. If the fullcontact field appears in both the sippeers and the sipregs table, then during reconstruction of the field, it will otherwise be doubled. (closes issue ASTERISK-13831) Reported by: Alexei Gradinari Patches: 20090506__bug14754.diff.txt uploaded by tilghman (license 14) Tested by: lmadsen ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192935 By: Digium Subversion (svnbot) 2009-05-07 11:45:41 Repository: asterisk Revision: 192936 _U branches/1.6.2/ U branches/1.6.2/channels/chan_sip.c ------------------------------------------------------------------------ r192936 | tilghman | 2009-05-07 11:45:40 -0500 (Thu, 07 May 2009) | 24 lines Merged revisions 192933 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r192933 | tilghman | 2009-05-07 11:43:56 -0500 (Thu, 07 May 2009) | 17 lines Merged revisions 192932 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r192932 | tilghman | 2009-05-07 11:29:08 -0500 (Thu, 07 May 2009) | 10 lines Eliminate repetition of fullcontact during reconstruction. If the fullcontact field appears in both the sippeers and the sipregs table, then during reconstruction of the field, it will otherwise be doubled. (closes issue ASTERISK-13831) Reported by: Alexei Gradinari Patches: 20090506__bug14754.diff.txt uploaded by tilghman (license 14) Tested by: lmadsen ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=192936 | ||