[Home]

Summary:ASTERISK-13818: [patch] autoplay option for VoiceMailMain generates warning about invalid value
Reporter:pj (pj)Labels:
Date Opened:2009-03-24 17:26:22Date Closed:2009-09-30 10:15:15
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) __20090729-app_voicemail-documentation.patch
( 1) issue14740_09022009.diff
Description:When using option 'a' for VoiceMailMain application, it generates unnecessary warning. This warning is generated regardles if I specify folder eg. a(INBOX) or leave option a() alone, ie. to use default - INBOX.
Both svn trunk and 1.6.1 branch are affected

from VoiceMailMain help text:
   a(folder): Skip folder prompt and go directly to <folder> specified.
   Defaults to 'INBOX'.



****** ADDITIONAL INFORMATION ******

[Mar 24 23:18:00]     -- Executing [666@from-cme:9] VoiceMailMain("SIP/cme-gw-b021b4c0", "688,sa(INBOX)") in new stack
[Mar 24 23:18:00] WARNING[27508]: app_voicemail.c:8737 vm_execmain: Invalid value 'INBOX' provided for folder autoplay option

[Mar 24 23:16:57]     -- Executing [666@from-cme:9] VoiceMailMain("SIP/cme-gw-b021b4c0", "688,sa()") in new stack
[Mar 24 23:16:57] WARNING[27485]: app_voicemail.c:8737 vm_execmain: Invalid value '' provided for folder autoplay option

Comments:By: Sean Bright (seanbright) 2009-05-04 13:50:35

The documentation looks to be unclear.  Can you try using numbers instead of the names of the folders?  For example, a(0) or a(1)
By: pj (pj) 2009-05-04 14:13:35

If I specify a(0) it doesn't generate warning, but what does this numbers mean? Help for this should be definitively updated, incl. "default" behaviour, because seems, that some argument should be always specified, even if I want to go to "default" INBOX.
By: Sean Bright (seanbright) 2009-05-04 14:21:25

I think the help text is supposed to mean "If you don't pass an a() option, it will default to 'INBOX.'"

The a() option takes numeric arguments as follows:

0 - INBOX
1 - Old
2 - Work
3 - Family
4 - Friends
5 - Cust1
6 - Cust2
7 - Cust3
8 - Cust4
9 - Cust5

The documentation does needs to be updated and the application should be modified to handle a(INBOX), a(Old), etc.  Will put that on my TODO list.
By: pj (pj) 2009-05-04 14:31:40

It have different behaviour, when I specify a(0) or when I don't specify 'a' at all...

[May  4 21:28:26]     -- Executing [666@from-cme:9] VoiceMailMain("SIP/688-b0173a30", "688,s") in new stack
[May  4 21:28:26]     -- <SIP/688-b0173a30> Playing 'vm-youhave.g729' (language 'en')
[May  4 21:28:27]     -- <SIP/688-b0173a30> Playing 'vm-no.g729' (language 'en')
[May  4 21:28:27]     -- <SIP/688-b0173a30> Playing 'vm-messages.g729' (language 'en')
[May  4 21:28:28]     -- <SIP/688-b0173a30> Playing 'vm-opts.g729' (language 'en')


[May  4 21:29:04]     -- Executing [666@from-cme:9] VoiceMailMain("SIP/688-b0106890", "688,sa(0)") in new stack
[May  4 21:29:04]     -- <SIP/688-b0106890> Playing 'vm-youhave.g729' (language 'en')
[May  4 21:29:05]     -- <SIP/688-b0106890> Playing 'vm-no.g729' (language 'en')
[May  4 21:29:05]     -- <SIP/688-b0106890> Playing 'vm-INBOX.g729' (language 'en')
[May  4 21:29:06]     -- <SIP/688-b0106890> Playing 'vm-messages.g729' (language 'en')
[May  4 21:29:07]     -- <SIP/688-b0106890> Playing 'vm-goodbye.g729' (language 'en')
By: Sean Bright (seanbright) 2009-05-04 16:51:17

> The documentation does needs to be updated and the application should be modified to handle a(INBOX), a(Old), etc.
By: Leif Madsen (lmadsen) 2009-07-29 13:44:08

Reassigned to seanbright now that the documentation has been updated to reflect what is there. Perhaps we should really just commit this documentation change, and then open a new bug to track the "feature" change you plan on adding. Your choice sir!
By: Sean Bright (seanbright) 2009-09-02 09:57:58

Would you mind testing?
By: Leif Madsen (lmadsen) 2009-09-03 08:21:23

Testing this now.
By: Leif Madsen (lmadsen) 2009-09-03 08:42:20

Works great for me! I tested with a(INBOX) and a(1) (after checking the voicemail) and both methods work fine.
By: pj (pj) 2009-09-03 13:35:14

Can you also probe to use 'a' without argument?
It should defaults to 'INBOX' in this case.
By: Digium Subversion (svnbot) 2009-09-30 09:50:44

Repository: asterisk
Revision: 221085

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r221085 | seanbright | 2009-09-30 09:50:43 -0500 (Wed, 30 Sep 2009) | 9 lines

Clarify documentation for VoiceMailMain()'s a() option.

We require box numbers, not names as the documentation implies.
(issue ASTERISK-13818)
Reported by: pj
Patches:
     __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10)
Tested by: seanbright, lmadsen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221085
By: Digium Subversion (svnbot) 2009-09-30 09:55:30

Repository: asterisk
Revision: 221087

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_voicemail.c

------------------------------------------------------------------------
r221087 | seanbright | 2009-09-30 09:55:29 -0500 (Wed, 30 Sep 2009) | 16 lines

Merged revisions 221085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r221085 | seanbright | 2009-09-30 10:47:58 -0400 (Wed, 30 Sep 2009) | 9 lines
 
 Clarify documentation for VoiceMailMain()'s a() option.
 
 We require box numbers, not names as the documentation implies.
 (issue ASTERISK-13818)
 Reported by: pj
 Patches:
       __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10)
 Tested by: seanbright, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221087
By: Digium Subversion (svnbot) 2009-09-30 09:58:00

Repository: asterisk
Revision: 221088

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_voicemail.c

------------------------------------------------------------------------
r221088 | seanbright | 2009-09-30 09:58:00 -0500 (Wed, 30 Sep 2009) | 16 lines

Merged revisions 221085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r221085 | seanbright | 2009-09-30 10:47:58 -0400 (Wed, 30 Sep 2009) | 9 lines
 
 Clarify documentation for VoiceMailMain()'s a() option.
 
 We require box numbers, not names as the documentation implies.
 (issue ASTERISK-13818)
 Reported by: pj
 Patches:
       __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10)
 Tested by: seanbright, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221088
By: Digium Subversion (svnbot) 2009-09-30 09:59:47

Repository: asterisk
Revision: 221089

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r221089 | seanbright | 2009-09-30 09:59:46 -0500 (Wed, 30 Sep 2009) | 16 lines

Merged revisions 221085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r221085 | seanbright | 2009-09-30 10:47:58 -0400 (Wed, 30 Sep 2009) | 9 lines
 
 Clarify documentation for VoiceMailMain()'s a() option.
 
 We require box numbers, not names as the documentation implies.
 (issue ASTERISK-13818)
 Reported by: pj
 Patches:
       __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10)
 Tested by: seanbright, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221089
By: Digium Subversion (svnbot) 2009-09-30 10:14:07

Repository: asterisk
Revision: 221090

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r221090 | seanbright | 2009-09-30 10:14:07 -0500 (Wed, 30 Sep 2009) | 8 lines

Modify VoiceMailMain()'s a() argument to allow mailboxes to be specified by name.

(closes issue ASTERISK-13818)
Reported by: pj
Patches:
     issue14740_09022009.diff uploaded by seanbright (license 71)
Tested by: seanbright, lmadsen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221090
By: Digium Subversion (svnbot) 2009-09-30 10:15:14

Repository: asterisk
Revision: 221091

_U  branches/1.6.2/

------------------------------------------------------------------------
r221091 | seanbright | 2009-09-30 10:15:14 -0500 (Wed, 30 Sep 2009) | 14 lines

Blocked revisions 221090 via svnmerge

........
 r221090 | seanbright | 2009-09-30 11:11:21 -0400 (Wed, 30 Sep 2009) | 8 lines
 
 Modify VoiceMailMain()'s a() argument to allow mailboxes to be specified by name.
 
 (closes issue ASTERISK-13818)
 Reported by: pj
 Patches:
       issue14740_09022009.diff uploaded by seanbright (license 71)
 Tested by: seanbright, lmadsen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221091