| Summary: | ASTERISK-13813: Detection of call pickup code in chan_dahdi should have higher priority than dialplan matches | ||
| Reporter: | Steve Davies . (stevedavies) | Labels: | |
| Date Opened: | 2009-03-24 06:39:50 | Date Closed: | 2009-08-04 13:59:53 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_dahdi |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Hi, Just spent some time investigating why a customer couldn't do *8 from their analogue phones. This on a freepbx system. In the end it turned out that the customer had a dialplan rule that matched "_*." and played a "your call cannot be completed as dialled" message. This is in freepbx's "bad-number" context which is included at the lowest level in the from-internal context. When I looked at the logic in chan_dahdi (and chan_zapata) I was surprised to find that it actually "prefers" a dialplan match over matching the ast_pickup_ext or *69 or the rest. My opinion is that it would be much more sensible to prefer the feature-code match where the dialplan also had a match. Especially where the dialplan match is a pattern match. My logic is that the feature code is like an "exact" exten line. And the concept that "exact matches" have priority over patterns is well established in Asterisk. I also point out that chan_sip in fact does prefer the pickup code over any dialplan match. So at the moment chan_dahdi and chan_sip are inconsistent. Regards, Steve | ||
| Comments: | By: Digium Subversion (svnbot) 2009-08-03 11:15:36 Repository: asterisk Revision: 210067 U branches/1.4/channels/chan_dahdi.c ------------------------------------------------------------------------ r210067 | dbrooks | 2009-08-03 11:15:35 -0500 (Mon, 03 Aug 2009) | 11 lines Fixes dialplan wildcard extension taking precedence over call pickup code. Prior to this patch, a wildcard extension in the dialplan (for example, _*.) would take precedence over picking up a call in the channel's pickup group. This patch simply moves the block of code handling pickup group matching to above the extension matching code. (closes issue ASTERISK-13813) Reported by: stevedavies Review: https://reviewboard.asterisk.org/r/319/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=210067 By: Digium Subversion (svnbot) 2009-08-04 13:59:53 Repository: asterisk Revision: 210436 _U trunk/ ------------------------------------------------------------------------ r210436 | dbrooks | 2009-08-04 13:59:52 -0500 (Tue, 04 Aug 2009) | 17 lines Blocked revisions 210067 via svnmerge ........ r210067 | dbrooks | 2009-08-03 11:15:20 -0500 (Mon, 03 Aug 2009) | 11 lines Fixes dialplan wildcard extension taking precedence over call pickup code. Prior to this patch, a wildcard extension in the dialplan (for example, _*.) would take precedence over picking up a call in the channel's pickup group. This patch simply moves the block of code handling pickup group matching to above the extension matching code. (closes issue ASTERISK-13813) Reported by: stevedavies Review: https://reviewboard.asterisk.org/r/319/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=210436 | ||