Summary:	ASTERISK-13788: [patch] chan_local generates MoH instead of just passing HOLD/UNHOLD further
Reporter:	Dmitry Andrianov (dimas)	Labels:
Date Opened:	2009-03-20 06:27:03	Date Closed:	2009-10-29 13:23:31
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_local
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) v1-14709.patch
Description:	The fix for the issue 7671 made chan_local to start/stop generation of MoH for HOLD/UNHOLD indications. Previously chan_local used to just pass these frames further. As result of the fix, if a SIP user dials into the MeetMe conference not directly but by the means of Local channel and then puts the call on hold, all the participants in the conference hear MoH generated by the chan_local.
Comments:	By: David Woolley (davidw) 2009-03-20 06:53:34 I think this may interact with ASTERISK-12930, i.e. you may need to repeat this indication, as well as ringback, when bridging. By: Dmitry Andrianov (dimas) 2009-05-26 09:57:09 Hmmm... I'm not sure what you mean with "repeat this indication, as well as ringback". My idea was that chan_local should not be providing any audible indications - it should just pass control frames back and forth and it is up to "real" channels to provide various sounds if needed... By: David Woolley (davidw) 2009-05-26 10:04:39 It is possible to reconfigure the connections to one side of a local channel.  When you do that, you need tell its new partner which indications were in progress.  Doing that avoids the need for the local channel to generate audio corresponding to the indications.  However, it still requires memory. However, because this was not working well, we had to change the local channel so that it actually did source ringback.  (That one may be fixed now, but we haven't had a chance to reverify.) By: Dmitry Andrianov (dimas) 2009-05-26 14:22:47 ah.. you saying that in addition to forwarding HOLD down the chain, chan_local should also set some boolean variable (like on_hold) to true and when local channel is rebound to another channel (or what you mean by re-configurre connection), it should also send HOLD frame there if that variable is set? But that means that chan_local should be able to send UNHOLD in the same scenario if the new channel is already held while local channel is not, right? And I'm not sure there is a way in Asterisk to ask if channel is held or not... (and the same appliies to other indications) By: Leif Madsen (lmadsen) 2009-09-18 08:52:59 What is the next step here? Is the patch attached, or the rolling back of issue ASTERISK-7472 desired? If not, then how should this issue proceed? (This is still an issue right? This bug has been opened for a while now.) By: Dmitry Andrianov (dimas) 2009-09-18 08:54:51 Leif, I can only answer to the second part of your question - yes it is still the issue for me and I have to keep my systems patched. I do not know how to solve it properly - probably Russell and David can come up with some ideas. By: David Woolley (davidw) 2009-09-18 09:00:11 What I'm saying is that reverting the change (or applying the patch) is not enough.  You also have to extend ASTERISK-12930's fix to this case. By: David Woolley (davidw) 2009-09-18 09:01:07 PS  I'm not passing an opinion about whether or not it is right for chan_local to generate MOH itself. By: Leif Madsen (lmadsen) 2009-09-18 12:13:47 OK great. Thanks for all the information guys! By: Digium Subversion (svnbot) 2009-10-29 13:16:26 Repository: asterisk Revision: 226531 U   branches/1.4/channels/chan_local.c U   branches/1.4/doc/localchannel.txt ------------------------------------------------------------------------ r226531 | file | 2009-10-29 13:16:25 -0500 (Thu, 29 Oct 2009) | 6 lines Add an option to enabling passing music on hold start and stop requests through instead of acting on them in chan_local. (closes issue ASTERISK-13788) Reported by: dimas ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=226531 By: Digium Subversion (svnbot) 2009-10-29 13:18:41 Repository: asterisk Revision: 226532 _U  trunk/ U   trunk/channels/chan_local.c U   trunk/doc/tex/localchannel.tex ------------------------------------------------------------------------ r226532 | file | 2009-10-29 13:18:41 -0500 (Thu, 29 Oct 2009) | 13 lines Merged revisions 226531 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r226531 | file | 2009-10-29 15:11:26 -0300 (Thu, 29 Oct 2009) | 6 lines    Add an option to enabling passing music on hold start and stop requests through instead of  acting on them in chan_local.    (closes issue ASTERISK-13788)  Reported by: dimas ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=226532 By: Digium Subversion (svnbot) 2009-10-29 13:19:35 Repository: asterisk Revision: 226533 _U  branches/1.6.0/ U   branches/1.6.0/channels/chan_local.c U   branches/1.6.0/doc/tex/localchannel.tex ------------------------------------------------------------------------ r226533 | file | 2009-10-29 13:19:35 -0500 (Thu, 29 Oct 2009) | 20 lines Merged revisions 226532 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r226532 | file | 2009-10-29 15:13:42 -0300 (Thu, 29 Oct 2009) | 13 lines    Merged revisions 226531 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r226531 | file | 2009-10-29 15:11:26 -0300 (Thu, 29 Oct 2009) | 6 lines        Add an option to enabling passing music on hold start and stop requests through instead of    acting on them in chan_local.        (closes issue ASTERISK-13788)    Reported by: dimas  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=226533 By: Digium Subversion (svnbot) 2009-10-29 13:20:41 Repository: asterisk Revision: 226534 _U  branches/1.6.1/ U   branches/1.6.1/channels/chan_local.c U   branches/1.6.1/doc/tex/localchannel.tex ------------------------------------------------------------------------ r226534 | file | 2009-10-29 13:20:41 -0500 (Thu, 29 Oct 2009) | 20 lines Merged revisions 226532 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r226532 | file | 2009-10-29 15:13:42 -0300 (Thu, 29 Oct 2009) | 13 lines    Merged revisions 226531 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r226531 | file | 2009-10-29 15:11:26 -0300 (Thu, 29 Oct 2009) | 6 lines        Add an option to enabling passing music on hold start and stop requests through instead of    acting on them in chan_local.        (closes issue ASTERISK-13788)    Reported by: dimas  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=226534 By: Digium Subversion (svnbot) 2009-10-29 13:23:30 Repository: asterisk Revision: 226540 _U  branches/1.6.2/ U   branches/1.6.2/channels/chan_local.c U   branches/1.6.2/doc/tex/localchannel.tex ------------------------------------------------------------------------ r226540 | file | 2009-10-29 13:23:30 -0500 (Thu, 29 Oct 2009) | 20 lines Merged revisions 226532 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................  r226532 | file | 2009-10-29 15:13:42 -0300 (Thu, 29 Oct 2009) | 13 lines    Merged revisions 226531 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r226531 | file | 2009-10-29 15:11:26 -0300 (Thu, 29 Oct 2009) | 6 lines        Add an option to enabling passing music on hold start and stop requests through instead of    acting on them in chan_local.        (closes issue ASTERISK-13788)    Reported by: dimas  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=226540