[Home]

Summary:ASTERISK-13787: CID matching is wrong
Reporter:klaus3000 (klaus3000)Labels:
Date Opened:2009-03-20 06:14:55Date Closed:2009-09-24 09:33:08
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/PBX
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Hi!

When using CID matching in extensions.conf/ael it uses a wrong matching algorithm:

E.g. CallerID = 699111600
 exten => s/_699.,1,NoOp(bad)
 exten => s/_6991116.,1,NoOp(good)

This will use "bad" although it should match "good" (like the normal extension matching algorithm does)

****** ADDITIONAL INFORMATION ******

This was discussed and classified as bug in the mailing list thread
http://lists.digium.com/pipermail/asterisk-dev/2009-March/037212.html

The bug is at least in 1.4.24 and 1.6.1 branch
Comments:By: Digium Subversion (svnbot) 2009-09-16 13:02:27

Repository: asterisk
Revision: 218867

U   branches/1.4/main/pbx.c

------------------------------------------------------------------------
r218867 | dbrooks | 2009-09-16 13:02:27 -0500 (Wed, 16 Sep 2009) | 13 lines

Fixes CID pattern matching behavior to mirror that of extension pattern matching.

Pattern matching for extensions uses a type of scoring system, giving values for
specificity to each character in the pattern. Unfortunately, this is done character
by character, in order. This does lead to some less specific patterns being first
in line for matching, but it will usually get the job done.

This patch merely brings CID matching to the same level as extension matching.
This patch does not attempt to tackle the problem shared by extension matching.

(closes issue ASTERISK-13787)
Reported by: klaus3000

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218867
By: Digium Subversion (svnbot) 2009-09-16 13:08:24

Repository: asterisk
Revision: 218868

_U  trunk/
U   trunk/main/pbx.c

------------------------------------------------------------------------
r218868 | dbrooks | 2009-09-16 13:08:24 -0500 (Wed, 16 Sep 2009) | 20 lines

Merged revisions 218867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines
 
 Fixes CID pattern matching behavior to mirror that of extension pattern matching.
 
 Pattern matching for extensions uses a type of scoring system, giving values for
 specificity to each character in the pattern. Unfortunately, this is done character
 by character, in order. This does lead to some less specific patterns being first
 in line for matching, but it will usually get the job done.
 
 This patch merely brings CID matching to the same level as extension matching.
 This patch does not attempt to tackle the problem shared by extension matching.
 
 (closes issue ASTERISK-13787)
 Reported by: klaus3000
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218868
By: Digium Subversion (svnbot) 2009-09-16 13:12:55

Repository: asterisk
Revision: 218869

_U  branches/1.6.0/
U   branches/1.6.0/main/pbx.c

------------------------------------------------------------------------
r218869 | dbrooks | 2009-09-16 13:12:55 -0500 (Wed, 16 Sep 2009) | 27 lines

Merged revisions 218868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218868 | dbrooks | 2009-09-16 13:06:42 -0500 (Wed, 16 Sep 2009) | 20 lines
 
 Merged revisions 218867 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines
   
   Fixes CID pattern matching behavior to mirror that of extension pattern matching.
   
   Pattern matching for extensions uses a type of scoring system, giving values for
   specificity to each character in the pattern. Unfortunately, this is done character
   by character, in order. This does lead to some less specific patterns being first
   in line for matching, but it will usually get the job done.
   
   This patch merely brings CID matching to the same level as extension matching.
   This patch does not attempt to tackle the problem shared by extension matching.
   
   (closes issue ASTERISK-13787)
   Reported by: klaus3000
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218869
By: Digium Subversion (svnbot) 2009-09-16 13:24:57

Repository: asterisk
Revision: 218890

_U  branches/1.6.1/
U   branches/1.6.1/main/pbx.c

------------------------------------------------------------------------
r218890 | dbrooks | 2009-09-16 13:24:57 -0500 (Wed, 16 Sep 2009) | 27 lines

Merged revisions 218868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218868 | dbrooks | 2009-09-16 13:06:42 -0500 (Wed, 16 Sep 2009) | 20 lines
 
 Merged revisions 218867 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines
   
   Fixes CID pattern matching behavior to mirror that of extension pattern matching.
   
   Pattern matching for extensions uses a type of scoring system, giving values for
   specificity to each character in the pattern. Unfortunately, this is done character
   by character, in order. This does lead to some less specific patterns being first
   in line for matching, but it will usually get the job done.
   
   This patch merely brings CID matching to the same level as extension matching.
   This patch does not attempt to tackle the problem shared by extension matching.
   
   (closes issue ASTERISK-13787)
   Reported by: klaus3000
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218890
By: Digium Subversion (svnbot) 2009-09-16 14:42:29

Repository: asterisk
Revision: 218938

_U  branches/1.6.2/
U   branches/1.6.2/main/pbx.c

------------------------------------------------------------------------
r218938 | dbrooks | 2009-09-16 14:42:28 -0500 (Wed, 16 Sep 2009) | 27 lines

Merged revisions 218868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r218868 | dbrooks | 2009-09-16 13:06:42 -0500 (Wed, 16 Sep 2009) | 20 lines
 
 Merged revisions 218867 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines
   
   Fixes CID pattern matching behavior to mirror that of extension pattern matching.
   
   Pattern matching for extensions uses a type of scoring system, giving values for
   specificity to each character in the pattern. Unfortunately, this is done character
   by character, in order. This does lead to some less specific patterns being first
   in line for matching, but it will usually get the job done.
   
   This patch merely brings CID matching to the same level as extension matching.
   This patch does not attempt to tackle the problem shared by extension matching.
   
   (closes issue ASTERISK-13787)
   Reported by: klaus3000
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218938