[Home]

Summary:ASTERISK-13775: [patch] PrivacyManager generates a core dump when testing
Reporter:SplatNIX (uxbod)Labels:
Date Opened:2010-01-11 10:21:16.000-0600Date Closed:2010-05-12 11:29:15
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Applications/app_privacy
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100505__issue16576.diff.txt
( 1) gdb.txt
Description:Create a test dialplan extension:

exten => 8100,1,Set(CALLERID(num)="")
exten => 8100,n,Answer()
exten => 8100,n,PrivacyManager()
exten => 8100,n,GotoIf(${[${PRIVACYMGRSTATUS} = FAILED]}?:nocid)
exten => 8100,n,NoOp(Number is ${CALLERID(num)})
exten => 8100,n,Hangup()
exten => 8100,n(nocid),Playback(vm-goodbye)
exten => 8100,n,NoOp(Number is ${CALLERID(num)})
exten => 8100,n,Hangup()

Dial the extension and enter a number.  Once entered Asterisk core dumps; and the following is within the console:

 == Using SIP RTP CoS mark 5
  -- Executing [8100@test:1] Answer("SIP/1001-00000000", "") in new stack
  -- Executing [8100@test:2] Set("SIP/1001-00000000", "CALLERID(all)=""") in new stack
  -- Executing [8100@test:3] PrivacyManager("SIP/1001-00000000", "") in new stack
  -- <SIP/1001-00000000> Playing 'privacy-unident.g729' (language 'en')
  -- <SIP/1001-00000000> Playing 'privacy-prompt.g729' (language 'en')
voip*CLI>
Disconnected from Asterisk server
/usr/sbin/safe_asterisk: line 146: 21648 Segmentation fault

A backtrace shows:

Core was generated by `asterisk -cvvvdg'.
Program terminated with signal 11, Segmentation fault.
[New process 22183]
[New process 22179]
[New process 22178]
[New process 22177]
[New process 22176]
[New process 22155]
[New process 22147]
[New process 22140]
[New process 22139]
[New process 22138]
[New process 22137]
[New process 22136]
[New process 22135]
[New process 22130]
[New process 22129]
[New process 22128]
[New process 22127]
[New process 22126]
[New process 22125]
[New process 22124]
[New process 22123]
[New process 22122]
[New process 22121]
[New process 22120]
[New process 22119]
[New process 22118]
[New process 22117]
[New process 22116]
[New process 22115]
[New process 22114]
[New process 22113]
[New process 22111]
[New process 22110]
[New process 22109]
[New process 22108]
[New process 22107]
[New process 22106]
[New process 22105]
[New process 22104]
[New process 22103]
[New process 22102]
[New process 22100]
#0  0x006b6b58 in privacy_exec (chan=0xb76a27a8, data=0x817c80e) at /usr/src/build/asterisk-1.6.2.0/include/asterisk/strings.h:65
65 return (!s || (*s == '\0'));

Comments:By: Sean Bright (seanbright) 2010-01-11 10:58:45.000-0600

Does changing:

   exten => 8100,n,PrivacyManager()

to:

   exten => 8100,n,PrivacyManager(3)

Keep it from crashing?
By: SplatNIX (uxbod) 2010-01-11 11:10:53.000-0600

Yes :) What does the change do, please ?
By: Sean Bright (seanbright) 2010-01-11 11:20:08.000-0600

Forces argument initialization.  Trying to duplicate the problem here.
By: Sean Bright (seanbright) 2010-01-11 11:45:34.000-0600

I actually can't duplicate this problem with 1.6.2.0 using the dialplan that you provided.  Could you follow the instructions in doc/backtrace.txt so that we can look more closely at this?  Thanks.
By: Leif Madsen (lmadsen) 2010-03-23 09:52:34

Issue closed as Unable to Reproduce after seanbright attempted to reproduce and the reporter was unresponsive.
By: SplatNIX (uxbod) 2010-03-23 09:56:55

Uh ? I attached the gdb backtrace as was requested.
By: Leif Madsen (lmadsen) 2010-03-24 08:41:00

Oh I didn't see. It's advisable to put in a note when adding a file since when triaging sometimes I don't look at the log :)
By: Geoff Stitt (geoff_stitt) 2010-04-21 14:47:43

I am having the same issue.  I'm running 1.6.2.6 on x86 hardware with an error similar to below:

/usr/sbin/safe_asterisk: line 117: 20528 Segmentation fault (core dumped) nice -n $PRIORITY ${ASTSBINDIR}/asterisk -f ${CLIARGS} ${ASTARGS} >&/dev/${TTY} </dev/${TTY}
Asterisk ended with exit status 139
Asterisk exited on signal 11.

Using PrivacyManager(3) stops it from crashing as well.
By: Paul Belanger (pabelanger) 2010-04-21 15:24:31

Like seanbright requested, we need a backtrace (without optimized values) to do anything.

http://svn.asterisk.org/svn/asterisk/trunk/doc/backtrace.txt

---
Thank you for your bug report. In order to move your issue forward, we require a backtrace from the core file produced after the crash. Please see the doc/backtrace.txt file in your Asterisk source directory.

Also, be sure you have DONT_OPTIMIZE enabled in menuselect within the Compiler Flags section, then:

make install

after enabling, reproduce the crash, and then execute the instructions in doc/backtrace.txt.

When complete, attach that file to this issue report. Thanks!
By: Tilghman Lesher (tilghman) 2010-05-05 14:54:32

This appears to be a case of uninitialized variables.  This patch should fix it.  Please report back and verify whether the patch fixes the issue for you.
By: Tilghman Lesher (tilghman) 2010-05-11 14:46:54

uxbod:  your feedback on this issue would be appreciated.
By: SplatNIX (uxbod) 2010-05-11 16:22:19

Sorry. Trying to debug a IMAP issue; will test the patch tomorrow. Thank you
By: SplatNIX (uxbod) 2010-05-12 06:08:05

Hi tilghman, yes that patch does resolve the issue.  Thanks.
By: Digium Subversion (svnbot) 2010-05-12 11:23:27

Repository: asterisk
Revision: 262656

U   trunk/apps/app_privacy.c

------------------------------------------------------------------------
r262656 | tilghman | 2010-05-12 11:23:26 -0500 (Wed, 12 May 2010) | 8 lines

Ensure the arguments are initialized.  Also miscellaneous CG cleanup.

(closes issue ASTERISK-13775)
Reported by: uxbod
Patches:
      20100505__issue16576.diff.txt uploaded by tilghman (license 14)
Tested by: uxbod

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262656
By: Digium Subversion (svnbot) 2010-05-12 11:29:05

Repository: asterisk
Revision: 262658

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_privacy.c

------------------------------------------------------------------------
r262658 | tilghman | 2010-05-12 11:29:04 -0500 (Wed, 12 May 2010) | 15 lines

Merged revisions 262656 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262656 | tilghman | 2010-05-12 11:23:26 -0500 (Wed, 12 May 2010) | 8 lines
 
 Ensure the arguments are initialized.  Also miscellaneous CG cleanup.
 
 (closes issue ASTERISK-13775)
  Reported by: uxbod
  Patches:
        20100505__issue16576.diff.txt uploaded by tilghman (license 14)
  Tested by: uxbod
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262658
By: Digium Subversion (svnbot) 2010-05-12 11:29:14

Repository: asterisk
Revision: 262659

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_privacy.c

------------------------------------------------------------------------
r262659 | tilghman | 2010-05-12 11:29:14 -0500 (Wed, 12 May 2010) | 15 lines

Merged revisions 262656 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r262656 | tilghman | 2010-05-12 11:23:26 -0500 (Wed, 12 May 2010) | 8 lines
 
 Ensure the arguments are initialized.  Also miscellaneous CG cleanup.
 
 (closes issue ASTERISK-13775)
  Reported by: uxbod
  Patches:
        20100505__issue16576.diff.txt uploaded by tilghman (license 14)
  Tested by: uxbod
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262659