Summary:	ASTERISK-13773: [patch] Add Hangupcause to manager action Hangup
Reporter:	Michael Neuhauser (mneuhauser)	Labels:
Date Opened:	2009-03-18 11:33:57	Date Closed:	2009-03-31 19:41:26
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) cause-for-hangup-manager-action.patch
Description:	Unlike the application counterpart, the 'Hangup' manager action does not allow the hangupcause to be specified. The attached patch (for 1.4) fixes this. I've named the new header 'Cause' to match the hangup manager event.
Comments:	By: Michael Neuhauser (mneuhauser) 2009-03-19 05:54:44 I've forgot to mention that the patch applies to trunk too (although I've only tested it with 1.4). By: Mark Michelson (mmichelson) 2009-03-31 19:30:13 This is a great idea. Since this encompasses new functionality, this will only go into Asterisk trunk, though, and not into 1.4 or any of the current 1.6.X branches. You've done a great job here. You've followed the coding guidelines, commented well, and everything is logically sound. The only change I'm going to make is to change the NOTICE message you print to a WARNING instead since it is pointing out a problem in the user's input. I'll get this committed ASAP. By: Digium Subversion (svnbot) 2009-03-31 19:39:02 Repository: asterisk Revision: 185704 U   trunk/CHANGES U   trunk/main/manager.c ------------------------------------------------------------------------ r185704 | mmichelson | 2009-03-31 19:39:02 -0500 (Tue, 31 Mar 2009) | 8 lines Allow the AMI Hangup command to accept a Cause header. (closes issue ASTERISK-13773) Reported by: mneuhauser Patches:      cause-for-hangup-manager-action.patch uploaded by mneuhauser (license 425) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=185704 By: Digium Subversion (svnbot) 2009-03-31 19:40:41 Repository: asterisk Revision: 185705 _U  branches/1.6.2/ ------------------------------------------------------------------------ r185705 | mmichelson | 2009-03-31 19:40:41 -0500 (Tue, 31 Mar 2009) | 13 lines Blocked revisions 185704 via svnmerge ........  r185704 | mmichelson | 2009-03-31 19:39:01 -0500 (Tue, 31 Mar 2009) | 8 lines    Allow the AMI Hangup command to accept a Cause header.    (closes issue ASTERISK-13773)  Reported by: mneuhauser  Patches:        cause-for-hangup-manager-action.patch uploaded by mneuhauser (license 425) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=185705 By: Digium Subversion (svnbot) 2009-03-31 19:40:59 Repository: asterisk Revision: 185706 _U  branches/1.6.1/ ------------------------------------------------------------------------ r185706 | mmichelson | 2009-03-31 19:40:58 -0500 (Tue, 31 Mar 2009) | 13 lines Blocked revisions 185704 via svnmerge ........  r185704 | mmichelson | 2009-03-31 19:39:01 -0500 (Tue, 31 Mar 2009) | 8 lines    Allow the AMI Hangup command to accept a Cause header.    (closes issue ASTERISK-13773)  Reported by: mneuhauser  Patches:        cause-for-hangup-manager-action.patch uploaded by mneuhauser (license 425) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=185706 By: Digium Subversion (svnbot) 2009-03-31 19:41:25 Repository: asterisk Revision: 185707 _U  branches/1.6.0/ ------------------------------------------------------------------------ r185707 | mmichelson | 2009-03-31 19:41:25 -0500 (Tue, 31 Mar 2009) | 13 lines Blocked revisions 185704 via svnmerge ........  r185704 | mmichelson | 2009-03-31 19:39:01 -0500 (Tue, 31 Mar 2009) | 8 lines    Allow the AMI Hangup command to accept a Cause header.    (closes issue ASTERISK-13773)  Reported by: mneuhauser  Patches:        cause-for-hangup-manager-action.patch uploaded by mneuhauser (license 425) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=185707