[Home]

Summary:ASTERISK-13764: Regression: #13867 Reject an incoming call to peer due to call limit with "603 Declined". It`s not correct.
Reporter:David Woolley (davidw)Labels:
Date Opened:2009-03-17 11:42:20Date Closed:2009-05-22 12:55:24
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When the patch for ASTERISK-1376867 got applied to the 1.6.0 branch the test that qualifies the setting of the hangup cause seems to have got inverted, so, in 1.4.0 (SVN 181768) we have:

3079 res = update_call_counter(p, INC_CALL_RINGING);
3080 if ( res != -1 ) {
......
3103 } else {
3104 ast->hangupcause = AST_CAUSE_USER_BUSY;
3105 }
3106 return res;

In 1.6.0.6 (r178024) we have:
4300 res = update_call_counter(p, INC_CALL_RINGING);
4301  
4302 if (res == -1) {
4303 return res;
4304 } else {
4305 ast->hangupcause = AST_CAUSE_USER_BUSY;
4306 }

Note that the != has become an ==.




****** ADDITIONAL INFORMATION ******

The history of this is that I have had reports of calls being rejected during the reconnection of a downstream Cisco server having DIALSTATUS CONGESTION, and HANGUP CAUSE 0.  I don't, at the moment, believe that we had exceeded the call limits, but this error does look to me to negate the fix from ASTERISK-1376867.
Comments:By: David Woolley (davidw) 2009-04-07 05:26:34

ASTERISK-13876 appears to represent a symptomatic manifestation of this problem.


By: David Woolley (davidw) 2009-04-07 08:00:38

I tried the obvious fix of moving the setting of hangupcause into the correct branch and it has restored the 1.6.0 behaviour for issue ASTERISK-1464802.  That doesn't mean that I have tested it for correct behaviour in relation to the ASTERISK-13041 problem.
By: Digium Subversion (svnbot) 2009-04-07 19:01:50

Repository: asterisk
Revision: 186837

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r186837 | mmichelson | 2009-04-07 19:01:49 -0500 (Tue, 07 Apr 2009) | 7 lines

Fix bad merge from fix for issue 13867.

(closes issue ASTERISK-13764)
Reported by: davidw



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=186837
By: Digium Subversion (svnbot) 2009-04-07 19:02:20

Repository: asterisk
Revision: 186838

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r186838 | mmichelson | 2009-04-07 19:02:20 -0500 (Tue, 07 Apr 2009) | 12 lines

Merged revisions 186837 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r186837 | mmichelson | 2009-04-07 19:01:49 -0500 (Tue, 07 Apr 2009) | 7 lines
 
 Fix bad merge from fix for issue 13867.
 
 (closes issue ASTERISK-13764)
 Reported by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=186838
By: Digium Subversion (svnbot) 2009-04-07 19:02:39

Repository: asterisk
Revision: 186839

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r186839 | mmichelson | 2009-04-07 19:02:39 -0500 (Tue, 07 Apr 2009) | 12 lines

Merged revisions 186837 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r186837 | mmichelson | 2009-04-07 19:01:49 -0500 (Tue, 07 Apr 2009) | 7 lines
 
 Fix bad merge from fix for issue 13867.
 
 (closes issue ASTERISK-13764)
 Reported by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=186839
By: Digium Subversion (svnbot) 2009-04-07 19:02:59

Repository: asterisk
Revision: 186840

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r186840 | mmichelson | 2009-04-07 19:02:59 -0500 (Tue, 07 Apr 2009) | 12 lines

Merged revisions 186837 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r186837 | mmichelson | 2009-04-07 19:01:49 -0500 (Tue, 07 Apr 2009) | 7 lines
 
 Fix bad merge from fix for issue 13867.
 
 (closes issue ASTERISK-13764)
 Reported by: davidw
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=186840