Summary:	ASTERISK-13731: Incorrect argument parsing in RetryDial causes asterisk to crash
Reporter:	Gianluigi Tiesi (sherpya)	Labels:
Date Opened:	2009-03-11 19:17:48	Date Closed:	2009-03-12 08:28:40
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	RetryDial(fpm-world-mix|5|3|LOCAL/sherpya) yes syntax is wrong function retrydial_exec line 1993 sleep = atoi(args.sleep) line 1996 loops = atoi(args.retries) same in svn they are two null pointers passed to atoi a check on args.sleep and args.retries is enough :)
Comments:	By: Digium Subversion (svnbot) 2009-03-12 08:24:13 Repository: asterisk Revision: 181612 U   trunk/apps/app_dial.c ------------------------------------------------------------------------ r181612 | file | 2009-03-12 08:24:13 -0500 (Thu, 12 Mar 2009) | 5 lines Fix crash when sleep and retries argument was not given to RetryDial application. (closes issue ASTERISK-13731) Reported by: sherpya ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181612 By: Digium Subversion (svnbot) 2009-03-12 08:27:37 Repository: asterisk Revision: 181613 _U  branches/1.6.0/ U   branches/1.6.0/apps/app_dial.c ------------------------------------------------------------------------ r181613 | file | 2009-03-12 08:27:36 -0500 (Thu, 12 Mar 2009) | 12 lines Merged revisions 181612 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r181612 | file | 2009-03-12 10:24:12 -0300 (Thu, 12 Mar 2009) | 5 lines    Fix crash when sleep and retries argument was not given to RetryDial application.    (closes issue ASTERISK-13731)  Reported by: sherpya ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181613 By: Digium Subversion (svnbot) 2009-03-12 08:28:39 Repository: asterisk Revision: 181614 _U  branches/1.6.1/ U   branches/1.6.1/apps/app_dial.c ------------------------------------------------------------------------ r181614 | file | 2009-03-12 08:28:39 -0500 (Thu, 12 Mar 2009) | 12 lines Merged revisions 181612 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........  r181612 | file | 2009-03-12 10:24:12 -0300 (Thu, 12 Mar 2009) | 5 lines    Fix crash when sleep and retries argument was not given to RetryDial application.    (closes issue ASTERISK-13731)  Reported by: sherpya ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=181614