[Home]

Summary:ASTERISK-13656: [patch] Queue setting to disregard penalty on few queue members
Reporter:Fredrik Liljegren (fiddur)Labels:
Date Opened:2009-02-26 07:10:14.000-0600Date Closed:2009-12-04 12:56:19.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.c.diff
( 1) trunk-199584-1.diff
Description:I've added a queue-setting to disregard members penalties when there are fewer than 'penaltymemberslimit' members in the queue.

E.G.: Setting penaltymemberslimit to 4 makes the queue disregard all members penalty levels if there are 4 or less members.

In queues that normally has many calls and many members prioritizing using penaltiy levels makes good sense.  When these persons work off hours with just a few others and few calls over several hours, they can now get an even distribution during these times.

****** ADDITIONAL INFORMATION ******

I don't know how many people wants this feature, but it's a small addition that won't disturbe anyone not using it, and it's a bothersome feature to add outside of asterisk (having some manager or other check queue membercount and removing penalty, adding it again etc...).

The patch is against trunk, but it works well for branch 1.6.0 as well.
Comments:By: Fredrik Liljegren (fiddur) 2009-02-26 07:11:49.000-0600

I have tested this only with realtime queues and realtime queue members.
By: Fredrik Liljegren (fiddur) 2009-03-26 08:11:02

I have been running this now on production server (1.6.0...) a month; it's working great, stably and predictably.
By: Eliel Sardanons (eliel) 2009-06-08 07:44:25

do not use:
if (a)
  b

always put brackets:
if (a) {
   b;
}

also do not added \n when not needed like:
if () {
}\n <--- not needed.
else {
}
By: Eliel Sardanons (eliel) 2009-06-08 07:54:24

If you are adding an option to the queue configuration you need to modify:
configs/queues.conf with an example, and documentation.
By: Leif Madsen (lmadsen) 2009-06-10 12:04:23

Changed status to 'feedback' until the reporter is able to resolve the issues mentioned by eliel. Thanks!
By: Fredrik Liljegren (fiddur) 2009-06-10 13:38:04

I'm sorry; I should have mentioned: The new patched is supposed to resolve the issues mentioned.  Unless I missed something, it should be conformant to the coding guidelines.
By: Leif Madsen (lmadsen) 2009-06-10 13:47:54

Aha sorry about that, I didn't notice the new file! Thanks!
By: David Vossel (dvossel) 2009-12-02 17:57:00.000-0600

I didn't get to test the patch, but from what I saw the code looked good.  You will need to update CHANGES as well to document this new feature as being released under 1.8.


*edit* I tested the patch, everything works great.  I went ahead an updated the CHANGES file.


By: Digium Subversion (svnbot) 2009-12-04 12:56:16.000-0600

Repository: asterisk
Revision: 233196

U   trunk/apps/app_queue.c
U   trunk/configs/queues.conf.sample

------------------------------------------------------------------------
r233196 | dvossel | 2009-12-04 12:56:16 -0600 (Fri, 04 Dec 2009) | 9 lines


new queue option, penaltymemberslimit, disregards penalty on too few queue members when enabled

(closes issue ASTERISK-13656)
Reported by: fiddur
Patches:
     trunk-199584-1.diff uploaded by fiddur (license 678)
Tested by: fiddur, dvossel

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=233196