[Home]

Summary:ASTERISK-13652: [patch] # for fastforward goes beyond end of message
Reporter:Jeff LaCoursiere (lacoursj)Labels:
Date Opened:2009-02-25 10:26:40.000-0600Date Closed:2009-06-26 16:27:54
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 21761.patch
( 1) file.c.patch
Description:When listening to message playback # and * will fastforward or rewind the playback by 3000ms by default.  When rewinding checks are made to make sure you cannot seek before the beginning of the stream, but no checks are made to make sure you do not seek past the end of the stream when using '#'.  The result is that users will seek past the end of the stream which lands them in the next IVR menu, where '#' will exit the voicemail application.  If a user is trying to fastforward to the end of a message he may hit '#' too many times and find himself disconnected.
Comments:By: Jeff LaCoursiere (lacoursj) 2009-02-25 10:49:22.000-0600

The submitted patch checks for EOF by attempting to grab a byte from the stream.  If EOF has been reached it rewinds the stream one "segment" (def 3000ms) and continues.  Otherwise it puts the byte back into the stream and continues.  Testing has been minimal using SIP and G711u codec from a Polycom IP501 phone.  The seek method seems to be implemented by codec, so further testing might be a good idea with other codecs?
By: snuffy (snuffy) 2009-03-06 22:42:25.000-0600

You should read doc/coding-guidelines.txt
aka you are missing that all if/else must use {}
By: Jeff LaCoursiere (lacoursj) 2009-03-09 17:15:36

Added.  I had not read that doc!  Excellent guidelines for this or any project for that matter.  I noted that the snippet of code following mine has "... else if..." - is "if" exempted from the guidelines for readability?
By: Digium Subversion (svnbot) 2009-06-26 16:16:40

Repository: asterisk
Revision: 203785

U   branches/1.4/main/file.c

------------------------------------------------------------------------
r203785 | russell | 2009-06-26 16:16:40 -0500 (Fri, 26 Jun 2009) | 15 lines

Don't fast forward past the end of a message.

This is nice change for users of the voicemail application.  If someone gets a
little carried away with fast forwarding through a message, they can easily
get to the end and accidentally exit the voicemail application by hitting the
fast forward key during the following prompt.

This adds some safety by not allowing a fast forward past the end of a message.

(closes issue ASTERISK-13652)
Reported by: lacoursj
Patches:
     21761.patch uploaded by lacoursj (license 707)
Tested by: lacoursj

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203785
By: Digium Subversion (svnbot) 2009-06-26 16:21:49

Repository: asterisk
Revision: 203802

_U  trunk/
U   trunk/main/file.c

------------------------------------------------------------------------
r203802 | russell | 2009-06-26 16:21:48 -0500 (Fri, 26 Jun 2009) | 22 lines

Merged revisions 203785 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r203785 | russell | 2009-06-26 16:16:39 -0500 (Fri, 26 Jun 2009) | 15 lines
 
 Don't fast forward past the end of a message.
 
 This is nice change for users of the voicemail application.  If someone gets a
 little carried away with fast forwarding through a message, they can easily
 get to the end and accidentally exit the voicemail application by hitting the
 fast forward key during the following prompt.
 
 This adds some safety by not allowing a fast forward past the end of a message.
 
 (closes issue ASTERISK-13652)
 Reported by: lacoursj
 Patches:
       21761.patch uploaded by lacoursj (license 707)
 Tested by: lacoursj
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203802
By: Digium Subversion (svnbot) 2009-06-26 16:25:53

Repository: asterisk
Revision: 203818

_U  branches/1.6.0/
U   branches/1.6.0/main/file.c

------------------------------------------------------------------------
r203818 | russell | 2009-06-26 16:25:53 -0500 (Fri, 26 Jun 2009) | 29 lines

Merged revisions 203802 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r203802 | russell | 2009-06-26 16:21:48 -0500 (Fri, 26 Jun 2009) | 22 lines
 
 Merged revisions 203785 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r203785 | russell | 2009-06-26 16:16:39 -0500 (Fri, 26 Jun 2009) | 15 lines
   
   Don't fast forward past the end of a message.
   
   This is nice change for users of the voicemail application.  If someone gets a
   little carried away with fast forwarding through a message, they can easily
   get to the end and accidentally exit the voicemail application by hitting the
   fast forward key during the following prompt.
   
   This adds some safety by not allowing a fast forward past the end of a message.
   
   (closes issue ASTERISK-13652)
   Reported by: lacoursj
   Patches:
         21761.patch uploaded by lacoursj (license 707)
   Tested by: lacoursj
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203818
By: Digium Subversion (svnbot) 2009-06-26 16:26:51

Repository: asterisk
Revision: 203823

_U  branches/1.6.1/
U   branches/1.6.1/main/file.c

------------------------------------------------------------------------
r203823 | russell | 2009-06-26 16:26:50 -0500 (Fri, 26 Jun 2009) | 29 lines

Merged revisions 203802 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r203802 | russell | 2009-06-26 16:21:48 -0500 (Fri, 26 Jun 2009) | 22 lines
 
 Merged revisions 203785 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r203785 | russell | 2009-06-26 16:16:39 -0500 (Fri, 26 Jun 2009) | 15 lines
   
   Don't fast forward past the end of a message.
   
   This is nice change for users of the voicemail application.  If someone gets a
   little carried away with fast forwarding through a message, they can easily
   get to the end and accidentally exit the voicemail application by hitting the
   fast forward key during the following prompt.
   
   This adds some safety by not allowing a fast forward past the end of a message.
   
   (closes issue ASTERISK-13652)
   Reported by: lacoursj
   Patches:
         21761.patch uploaded by lacoursj (license 707)
   Tested by: lacoursj
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203823
By: Digium Subversion (svnbot) 2009-06-26 16:27:54

Repository: asterisk
Revision: 203828

_U  branches/1.6.2/
U   branches/1.6.2/main/file.c

------------------------------------------------------------------------
r203828 | russell | 2009-06-26 16:27:54 -0500 (Fri, 26 Jun 2009) | 29 lines

Merged revisions 203802 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r203802 | russell | 2009-06-26 16:21:48 -0500 (Fri, 26 Jun 2009) | 22 lines
 
 Merged revisions 203785 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r203785 | russell | 2009-06-26 16:16:39 -0500 (Fri, 26 Jun 2009) | 15 lines
   
   Don't fast forward past the end of a message.
   
   This is nice change for users of the voicemail application.  If someone gets a
   little carried away with fast forwarding through a message, they can easily
   get to the end and accidentally exit the voicemail application by hitting the
   fast forward key during the following prompt.
   
   This adds some safety by not allowing a fast forward past the end of a message.
   
   (closes issue ASTERISK-13652)
   Reported by: lacoursj
   Patches:
         21761.patch uploaded by lacoursj (license 707)
   Tested by: lacoursj
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=203828